From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795100719; b=xbsRbq8vJVjyd5uzOlpmGLkPGsIPc+R5jRYcyk8UKRGvWxJWkyp0duFpNrAfXWEi5QI9 7ECUxppp2UszIBBjwiI98YVOg7MMpcAeRHDjGiiYjN4C5OxLGYPP9xJeLy+rjc5AO5g1L gI+9yIsGYKZcDHNavd4O9/7P83K7DTCQXHltnJq5yYq36bgTfMTOABq+q12WAoWDDh2pF wJ+P5IUZiF2KdpvZs1t368vhFPJLzi1pxHGOQyZqwrIYujsxc8qjvwHcpMbHZYm+6zt4S sJQnsdd3iCUxSPfSBaVVzjDMnod2E5gaZxC0ys7ksk+AgNe1StqwhdL1KiWXDh90fQw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795100719; h=DMARC-Filter:DKIM-Signature:Received:X-MC-Unique: X-Mimecast-MFC-AGG-ID:Received:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received: X-Received:Received:Date:From:To:Cc:Subject:Message-ID:References: MIME-Version:In-Reply-To:X-Mimecast-Spam-Score:X-Mimecast-MFC-PROC-ID: X-Mimecast-Originator:Content-Type:Content-Disposition; bh=cra6Vs20NtPqxX9EfP/IC1RWThkucYohNUCRfJABY3A=; b=HtYzHzE0t5z5e/tS2NNED9CKbUC+r5yT6ljt/vjZOWC76cAv9+ijdKiB7a1qtPBVGhKb gbklATYAH4OYl2U/WZjD3UrFjNjgyqsFc0iPW3DpJVDdlP8NfW2RCAL8ebQzuXCwNY6a1 g7roa3kTe/lBa/YlqGV3DG507qO/W2fmEn0gSwEAfNP9zkMTA51appap3jWj/cx7W8aJM FDvyqnT09v+rTcCkNDWeK5Y4js3W5awU3VouwjGO7ZesHB90RSpxIoGLxK5bbcD7Xy+iN 1JxXIXbIS1BxZcXPYW0hYn936UK1sxl0GOGAZ5zScJFkQ4KRKpSMztxu6waxUixReog== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=bpi2vh60; arc=none smtp.remote-ip=170.10.133.124 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E4F73606A330 for ; Thu, 19 Nov 2026 15:05:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org E4F73606A330 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=bpi2vh60 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1795100718; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=cra6Vs20NtPqxX9EfP/IC1RWThkucYohNUCRfJABY3A=; b=bpi2vh60xpvl5EGhMPTXOLvzgPqZZdGqCg0GyCAFSeHYeMAe6OtDarzKONIDkq2ly98yvc 6MoKM145XOgKQJ5aVO64FHJq4a1zkKRwcRzmByXB77VwR4+krIe4KvTCLv4/C/QdiWCYZY fT2mC2fHWmYoWlLd7toKJcVDqYCsrDc= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-692--B1PgAVgMtSJw-k9VL88DQ-1; Thu, 19 Nov 2026 10:05:14 -0500 X-MC-Unique: -B1PgAVgMtSJw-k9VL88DQ-1 X-Mimecast-MFC-AGG-ID: -B1PgAVgMtSJw-k9VL88DQ_1795100713 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-49034831bb3so1611288f8f.1 for ; Thu, 19 Nov 2026 07:05:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1795100713; x=1795705513; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=cra6Vs20NtPqxX9EfP/IC1RWThkucYohNUCRfJABY3A=; b=qTaqSPdy27O+ztX1bdeSw7BSJhmxvJUlC9RtNfBP9jXCj3m23SBv4FesVqnyGTC3WG 1abldTDz4u3Blvy1rp9mgnww4GvD7EbNBKDO/avV6jD/+B4SN8p4Z4jQM9yNJh34h3fN fl1G6M9v4tP98GtKBi1loreQi/fSpwkjFtw6ywMXDmw8FzOyYgZwXrGt454mVErr+QPY nlw4bsBowF5O0KSMs40W6jv6bWc1/wMA1quMDGvnrocgdgzMdenNeUx0EmmRdoeNGOQP mlIGr4T1wCKbZ169XIcGlMQlJwkeIVo7wY1aYS+pslU4xpFIkGvzyx7Clex19bO+dOQQ RGZw== X-Forwarded-Encrypted: i=1; AL+hErF/AesMoyZ2LU2FN5vVLTqul1fqmWuLQyxq3BwJUnWlrkFNQCSvkXuH2g4oJXA76562sZ4CDbjzF0M=@vger.kernel.org X-Gm-Message-State: APuU4Z8RDt6GrtRrgup4x3tTooknLA20WeCC0Gd1BCXrlbTDmmOfkza6 1VYjz9VMX8mMu402v2dyAp0vsf8+14JXL3e/wKxuEu7WSfPufmxMfJAggJMcyEWf+Bjiro81u3r GsZWvQwuWEKUE7tuqAbY1ItuoLer15lAsdH/Qj996Xl72nizBhVkFVcuoTQpsUg== X-Gm-Gg: AZFdTZcfXdg5E4uPwjrKaT/tWxDXiBO38TsFDtB8ACEro19EeBFphMAXBQFeMwkZanQ QhT8QrxBjZzVGC9QTE9M02r1Su6TghTthWfKpTcti5bAi8p25OoLeRC0RibbUkKJHdWGh8TNw9N o0Avn4MifzBYMemnw5gxu0mQ1utVW9aG+8ydV+GVlik3uA99qhiidbDK/e6yimylpgO/KpI8yQp koZXl359d8CW25Tb5RZtFxtl4cbzAGBCmeEJ7N9WTKjkXe3Ye9O/p5QZS+v2oyWX0zPXMYQsUNe U7AWU1ipaGMOUdu/tDwH95Ra3XG32o5iEH/NWbbQHbn+v3aqAPzzQHhiXoxaWWpXkMVtE/eiUbv U9TFk+SRZAfDp3mqoqjfFnVVRokqxw8asBif+V38ZwA== X-Received: by 2002:a05:6000:2608:b0:4a9:2728:fdfc with SMTP id ffacd0b85a97d-4a92728ff7amr4686387f8f.28.1795100713249; Thu, 19 Nov 2026 07:05:13 -0800 (PST) X-Received: by 2002:a05:6000:2608:b0:4a9:2728:fdfc with SMTP id ffacd0b85a97d-4a92728ff7amr4686266f8f.28.1795100712535; Thu, 19 Nov 2026 07:05:12 -0800 (PST) Received: from redhat.com ([2a0d:6fc0:1522:6500:ac93:c62:f076:48c6]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4ab6c61e53asm61225f8f.59.2026.11.19.07.05.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Nov 2026 07:05:11 -0800 (PST) Date: Thu, 19 Nov 2026 10:05:05 -0500 From: "Michael S. Tsirkin" To: "Lorenzo Stoakes (ARM)" Cc: Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Madhavan Srinivasan , Nicholas Piggin , Michael Ellerman , "Christophe Leroy (CS GROUP)" , "Ritesh Harjani (IBM)" , Shrikanth Hegde , Haiyang Zhang , Wei Liu , Dexuan Cui , Jason Wang , Eugenio =?iso-8859-1?Q?P=E9rez?= , Xuan Zhuo , Jarkko Sakkinen , Dave Hansen , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Jan Kara , Paul Moore , Stephen Smalley , Ondrej =?utf-8?B?TW9zbsOhxI1law==?= , Joel Stanley , Andrew Jeffery , Ryan Chen , Billy Tsai , Bjorn Andersson , Konrad Dybcio , Abel Vesa , Jens Wiklander , Sumit Garg , Scott Branden , Broadcom internal kernel review list , Arnd Bergmann , Greg Kroah-Hartman , Richard Cochran , David Woodhouse , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm@vger.kernel.org, linux-hyperv@vger.kernel.org, virtualization@lists.linux.dev, linux-sgx@vger.kernel.org, selinux@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-arm-msm@vger.kernel.org, op-tee@lists.trustedfirmware.org, netdev@vger.kernel.org Subject: Re: [PATCH 14/14] vhost-vdpa: convert mmap hook to mmap_prepare Message-ID: <20261119100450-mutt-send-email-mst@kernel.org> References: <20261105-late-2026-mmap_prepare-v1-0-c56aadfbab8a@kernel.org> <20261105-late-2026-mmap_prepare-v1-14-c56aadfbab8a@kernel.org> X-Mailing-List: linux-sgx@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 In-Reply-To: <20261105-late-2026-mmap_prepare-v1-14-c56aadfbab8a@kernel.org> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: TlpWM0bAflyp7w_kyr3DX_d92ilo9iwNyfMgi3ovRQs_1795100713 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Nov 05, 2026 at 09:05:45PM +0000, Lorenzo Stoakes (ARM) wrote: > Move from the deprecated mmap hook to the new mmap_prepare hook. The hook > only validates the request and sets the VMA flags, operations and page > protection. > > Signed-off-by: Lorenzo Stoakes (ARM) feel free to merge with rest of this. > --- > drivers/vhost/vdpa.c | 23 ++++++++++++----------- > 1 file changed, 12 insertions(+), 11 deletions(-) > > diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c > index ff7d90719171..993b2d7c8927 100644 > --- a/drivers/vhost/vdpa.c > +++ b/drivers/vhost/vdpa.c > @@ -1573,19 +1573,19 @@ static const struct vm_operations_struct vhost_vdpa_vm_ops = { > .fault = vhost_vdpa_fault, > }; > > -static int vhost_vdpa_mmap(struct file *file, struct vm_area_struct *vma) > +static int vhost_vdpa_mmap_prepare(struct vm_area_desc *desc) > { > - struct vhost_vdpa *v = vma->vm_file->private_data; > + struct vhost_vdpa *v = desc->file->private_data; > struct vdpa_device *vdpa = v->vdpa; > const struct vdpa_config_ops *ops = vdpa->config; > struct vdpa_notification_area notify; > - unsigned long index = vma->vm_pgoff; > + unsigned long index = desc->pgoff; > > - if (vma->vm_end - vma->vm_start != PAGE_SIZE) > + if (vma_desc_size(desc) != PAGE_SIZE) > return -EINVAL; > - if ((vma->vm_flags & VM_SHARED) == 0) > + if (!vma_desc_test(desc, VMA_SHARED_BIT)) > return -EINVAL; > - if (vma->vm_flags & VM_READ) > + if (vma_desc_test(desc, VMA_READ_BIT)) > return -EINVAL; > if (!ops->get_vq_notification) > return -ENOTSUPP; > @@ -1598,12 +1598,13 @@ static int vhost_vdpa_mmap(struct file *file, struct vm_area_struct *vma) > return -EINVAL; > if (notify.addr & (PAGE_SIZE - 1)) > return -EINVAL; > - if (vma->vm_end - vma->vm_start != notify.size) > + if (vma_desc_size(desc) != notify.size) > return -ENOTSUPP; > > - vma->vm_page_prot = pgprot_noncached(vma->vm_page_prot); > - vm_flags_set(vma, VM_IO | VM_PFNMAP | VM_DONTEXPAND | VM_DONTDUMP); > - vma->vm_ops = &vhost_vdpa_vm_ops; > + desc->page_prot = pgprot_noncached(desc->page_prot); > + vma_desc_set_flags(desc, VMA_IO_BIT, VMA_PFNMAP_BIT, VMA_DONTEXPAND_BIT, > + VMA_DONTDUMP_BIT); > + desc->vm_ops = &vhost_vdpa_vm_ops; > return 0; > } > #endif /* CONFIG_MMU */ > @@ -1615,7 +1616,7 @@ static const struct file_operations vhost_vdpa_fops = { > .write_iter = vhost_vdpa_chr_write_iter, > .unlocked_ioctl = vhost_vdpa_unlocked_ioctl, > #ifdef CONFIG_MMU > - .mmap = vhost_vdpa_mmap, > + .mmap_prepare = vhost_vdpa_mmap_prepare, > #endif /* CONFIG_MMU */ > .compat_ioctl = compat_ptr_ioctl, > }; > > -- > 2.56.0