RE: [PATCH v4 8/9] x86/cpu: Call ENCLS[EUPDATESVN] procedure in microcode update

Zhang, Cathy
2022-04-24T02:18:18Z

Hi Boris,

> -----Original Message-----
> From: Borislav Petkov <bp@alien8.de>
> Sent: Thursday, April 21, 2022 8:07 PM
> To: Zhang, Cathy <cathy.zhang@intel.com>
> Cc: linux-sgx@vger.kernel.org; x86@kernel.org; jarkko@kernel.org; Chatre,
> Reinette <reinette.chatre@intel.com>; Hansen, Dave
> <dave.hansen@intel.com>; Raj, Ashok <ashok.raj@intel.com>; Peng, Chao P
> <chao.p.peng@intel.com>; Zhong, Yang <yang.zhong@intel.com>
> Subject: Re: [PATCH v4 8/9] x86/cpu: Call ENCLS[EUPDATESVN] procedure in
> microcode update
>
> On Thu, Apr 21, 2022 at 07:03:25PM +0800, Cathy Zhang wrote:
> > diff --git a/arch/x86/include/asm/microcode.h
> b/arch/x86/include/asm/microcode.h
> > index d6bfdfb0f0af..ec12392af371 100644
> > --- a/arch/x86/include/asm/microcode.h
> > +++ b/arch/x86/include/asm/microcode.h
> > @@ -3,6 +3,7 @@
> > #define _ASM_X86_MICROCODE_H
> >
> > #include <asm/cpu.h>
> > +#include <asm/sgx.h>
>
> That include looks like a leftover.

Yep, it is. I've removed. Thanks for pointing out! I will pay more attention in future.

>
> --
> Regards/Gruss,
> Boris.
>
> https://people.kernel.org/tglx/notes-about-netiquette