From: "Huang, Kai" <kai.huang@intel.com>
To: "jarkko@kernel.org" <jarkko@kernel.org>,
"Lu, Aaron" <aaron.lu@intel.com>,
"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>
Cc: "linux-sgx@vger.kernel.org" <linux-sgx@vger.kernel.org>,
"Luo, Zhimin" <zhimin.luo@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"x86@kernel.org" <x86@kernel.org>
Subject: Re: [PATCH] x86/sgx: Fix deadloop in __sgx_alloc_epc_page()
Date: Thu, 29 Aug 2024 07:47:42 +0000 [thread overview]
Message-ID: <2cf0b2677ec6239a1fd7aa1b3ee101667c7b06b8.camel@intel.com> (raw)
In-Reply-To: <20240829023800.1671210-1-aaron.lu@intel.com>
On Thu, 2024-08-29 at 10:38 +0800, Aaron Lu wrote:
> When current node doesn't have a EPC section configured by firmware and
> all other EPC sections memory are used up, CPU can stuck inside the
> while loop in __sgx_alloc_epc_page() forever and soft lockup will happen.
> Note how nid_of_current will never equal to nid in that while loop because
> nid_of_current is not set in sgx_numa_mask.
>
> Also worth mentioning is that it's perfectly fine for firmware to not
> seup an EPC section on a node. Setting an EPC section on each node can
seup -> set up.
> be good for performance but that's not a requirement functionality wise.
>
> Fixes: 901ddbb9ecf5 ("x86/sgx: Add a basic NUMA allocation scheme to sgx_alloc_epc_page()")
> Reported-by: Zhimin Luo <zhimin.luo@intel.com>
> Tested-by: Zhimin Luo <zhimin.luo@intel.com>
> Signed-off-by: Aaron Lu <aaron.lu@intel.com>
Reviewed-by: Kai Huang <kai.huang@intel.com>
next prev parent reply other threads:[~2024-08-29 7:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-29 2:38 [PATCH] x86/sgx: Fix deadloop in __sgx_alloc_epc_page() Aaron Lu
2024-08-29 7:47 ` Huang, Kai [this message]
2024-08-29 7:56 ` Huang, Kai
2024-08-29 13:22 ` Aaron Lu
2024-08-29 15:17 ` Dave Hansen
2024-08-30 6:02 ` Aaron Lu
2024-08-30 14:03 ` Dave Hansen
2024-09-02 7:57 ` Aaron Lu
2024-08-29 16:44 ` Jarkko Sakkinen
2024-08-30 6:14 ` Aaron Lu
2024-09-03 16:05 ` Jarkko Sakkinen
2024-09-04 1:39 ` Aaron Lu
2024-09-04 14:17 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2cf0b2677ec6239a1fd7aa1b3ee101667c7b06b8.camel@intel.com \
--to=kai.huang@intel.com \
--cc=aaron.lu@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=jarkko@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sgx@vger.kernel.org \
--cc=x86@kernel.org \
--cc=zhimin.luo@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox