Re: [PATCH v4 2/3] x86/sgx: Fine grained SGX MCA behavior for virtualization

[Zhiquan Li <zhiquan1.li@intel.com>]

On 2022/6/8 16:13, Jarkko Sakkinen wrote:
> On Wed, Jun 08, 2022 at 03:52:46PM +1200, Kai Huang wrote:
>> On Wed, 2022-06-08 at 11:26 +0800, Zhiquan Li wrote:
>>> --- a/arch/x86/kernel/cpu/sgx/main.c
>>> +++ b/arch/x86/kernel/cpu/sgx/main.c
>>> @@ -715,6 +715,8 @@ int arch_memory_failure(unsigned long pfn, int flags)
>>>  	struct sgx_epc_page *page = sgx_paddr_to_page(pfn << PAGE_SHIFT);
>>>  	struct sgx_epc_section *section;
>>>  	struct sgx_numa_node *node;
>>> +	int ret = 0;
>>> +	unsigned long vaddr;
>>
>> Please switch the order of the two variables so all of variables are in reverse
>> Christmas style.
> 
> Yeah, we prefer that. Is it necessary to initialize ret?
> 

No problem, I will switch the order in V5 patch.

I referenced mm/memory-failure.c:kill_proc() to initialize "ret".
Whatever it will be overridden by the return value of force_sig_mceerr(), so it's
not necessary, we can remove it in V5 patch.

Best Regards,
Zhiquan

> BR, Jarkko