From: Dave Hansen <dave.hansen@intel.com>
To: Reinette Chatre <reinette.chatre@intel.com>,
jarkko@kernel.org, dave.hansen@linux.intel.com,
linux-sgx@vger.kernel.org, shuah@kernel.org
Cc: linux-kselftest@vger.kernel.org
Subject: Re: [PATCH 1/4] selftests/sgx: Fix segfault upon early test failure
Date: Fri, 28 Jan 2022 11:26:26 -0800 [thread overview]
Message-ID: <35d888c6-ffed-fb89-d02d-8c7ef15cd902@intel.com> (raw)
In-Reply-To: <8993eb98-ae1a-9af8-353b-e13895f9804b@intel.com>
On 1/28/22 11:22, Reinette Chatre wrote:
> if (encl->segment_tbl) {
> + /*
> + * Most segments form part of the enclave binary
> + * and have their mappings deleted with earlier
> + * munmap() of encl->bin.
> + * As a mapping of anonymous memory the heap
> + * segment is separate from the enclave
> + * binary and needs its mapping deleted separately.
> + */
> heap_seg = &encl->segment_tbl[encl->nr_segments - 1];
> munmap(heap_seg->src, heap_seg->size);
I was more wondering why the status of heap_seg->src is tied to
encl->segment_tbl.
next prev parent reply other threads:[~2022-01-28 19:26 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-28 18:23 [PATCH 0/4] selftests/sgx: Early enclave loading error path fixes Reinette Chatre
2022-01-28 18:23 ` [PATCH 1/4] selftests/sgx: Fix segfault upon early test failure Reinette Chatre
2022-01-28 18:43 ` Dave Hansen
2022-01-28 19:22 ` Reinette Chatre
2022-01-28 19:26 ` Dave Hansen [this message]
2022-01-28 20:08 ` Reinette Chatre
2022-02-15 19:39 ` Jarkko Sakkinen
2022-01-28 18:23 ` [PATCH 2/4] selftests/sgx: Do not attempt enclave build without valid enclave Reinette Chatre
2022-01-28 19:03 ` Dave Hansen
2022-01-28 19:23 ` Reinette Chatre
2022-02-15 19:35 ` Jarkko Sakkinen
2022-01-28 18:23 ` [PATCH 3/4] selftests/sgx: Ensure enclave data available during debug print Reinette Chatre
2022-01-28 19:06 ` Dave Hansen
2022-01-28 19:40 ` Reinette Chatre
2022-02-15 19:35 ` Jarkko Sakkinen
2022-01-28 18:23 ` [PATCH 4/4] selftests/sgx: Remove extra newlines in test output Reinette Chatre
2022-01-28 19:07 ` Dave Hansen
2022-02-15 19:34 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=35d888c6-ffed-fb89-d02d-8c7ef15cd902@intel.com \
--to=dave.hansen@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=jarkko@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-sgx@vger.kernel.org \
--cc=reinette.chatre@intel.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox