From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F40EC48BD1 for ; Fri, 11 Jun 2021 22:48:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F2C506124B for ; Fri, 11 Jun 2021 22:48:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230211AbhFKWun (ORCPT ); Fri, 11 Jun 2021 18:50:43 -0400 Received: from mail-io1-f48.google.com ([209.85.166.48]:34380 "EHLO mail-io1-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230269AbhFKWun (ORCPT ); Fri, 11 Jun 2021 18:50:43 -0400 Received: by mail-io1-f48.google.com with SMTP id 5so32829142ioe.1 for ; Fri, 11 Jun 2021 15:48:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=rQPaBTxH6zmCmow24Ez/25u3aT/BbkT5Z3FMYjKkQD4=; b=foHbHgWLRUOeDdrUUtQo5W+xDkKSaogccxeI9Y3GB8DlJwljzOJ+Lg597umTqeTMTb fY8gJ47PnGJQo/RVPEvNf5PdZaDGNecOGl19KtekqED2TDtZX43KUTLiorhzUp/6lBt2 oz5w8QecWW942LM1RxHrObEkHehi60fovjjJM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=rQPaBTxH6zmCmow24Ez/25u3aT/BbkT5Z3FMYjKkQD4=; b=eUmUon33zgeenrUioEEIcdYnuzKS7lEYiLa7eT6hd0tyoCbS538Oj5BfCuuV9AQwoS JTMN1SDhvBMN9UW7TpmD+CdaxoUFZL7KA8MjNZMqNcTA6SYxah54K+0OZWu9UbIeeKCZ OAXdYWt8aaCdxSo1OMhhGriYC6OUoK4MHnYnrn20KMOiN0vziwcvi74v7z3nofafGD6b RCPEnRqH8lTAQzJPG4MRd5NlHFzn3osHLq5sPZuQH0CfTiZ/OiBZvfBr5MbxckP0GVs8 q4umcdNGjGWa8WTp/0CbsGNKtD/yqQPk7y5wfe14Vwmp2XkyrGmJbld73r/sqaHj+X5v K+tw== X-Gm-Message-State: AOAM532oA8qlD8kU3qfIROMLkVl3l4D4gbusXotLFx0wcAYOIjgr9hYn b9EKoFb5l/PZtRyhFSj7vvRsbQ== X-Google-Smtp-Source: ABdhPJzYhIxyLeAPQfmBQvodXCR2Xj9xHbnPvzsaxcBbNu4D4KPVCTAAKGS5ajq24bteysnPjY0wXg== X-Received: by 2002:a5d:9c88:: with SMTP id p8mr5082265iop.31.1623451651344; Fri, 11 Jun 2021 15:47:31 -0700 (PDT) Received: from [192.168.1.112] (c-24-9-64-241.hsd1.co.comcast.net. [24.9.64.241]) by smtp.gmail.com with ESMTPSA id y17sm4160145ilb.60.2021.06.11.15.47.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 11 Jun 2021 15:47:31 -0700 (PDT) Subject: Re: [PATCH v8 1/5] selftests/sgx: Rename 'eenter' and 'sgx_call_vdso' To: Dave Hansen , Jarkko Sakkinen , shuah@kernel.org Cc: linux-kselftest@vger.kernel.org, linux-sgx@vger.kernel.org, Reinette Chatre , Dave Hansen , linux-kernel@vger.kernel.org, Shuah Khan References: <20210610083021.392269-1-jarkko@kernel.org> <8d071d3f-604f-1876-05bb-91568dd3c563@linuxfoundation.org> From: Shuah Khan Message-ID: <6378d2a9-9f55-18f8-ce46-7ea954ac159c@linuxfoundation.org> Date: Fri, 11 Jun 2021 16:47:30 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <8d071d3f-604f-1876-05bb-91568dd3c563@linuxfoundation.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-sgx@vger.kernel.org On 6/11/21 11:35 AM, Shuah Khan wrote: > On 6/10/21 9:45 AM, Dave Hansen wrote: >> On 6/10/21 1:30 AM, Jarkko Sakkinen wrote: >>> Rename symbols for better clarity: >>> >>> * 'eenter' might be confused for directly calling ENCLU[EENTER].  It >>> does >>>    not.  It calls into the VDSO, which actually has the EENTER >>> instruction. >>> * 'sgx_call_vdso' is *only* used for entering the enclave.  It's not >>> some >>>    generic SGX call into the VDSO. >>> >>> Signed-off-by: Jarkko Sakkinen >> >> These all look fine to me.  Feel free to add my ack on them. >> >> Since these are pure x86 selftests and the initial code went through the >> x86 maintainers, should these got through them as well?  Or, since this >> is only selftest code, should Shuah pick them up? >> > > I will queue these up for 5.14-rc1 > I almost applied these. Does this require root access, if so, please add logic to skip the test if non-root user runs it. Please check for code paths that require root access and skip the tests. thanks, -- Shuah