From: Dave Hansen <dave.hansen@intel.com>
To: Reinette Chatre <reinette.chatre@intel.com>,
Jarkko Sakkinen <jarkko@kernel.org>,
Shuah Khan <shuah@kernel.org>
Cc: Dave Hansen <dave.hansen@linux.intel.com>,
linux-kselftest@vger.kernel.org, linux-sgx@vger.kernel.org
Subject: Re: [PATCH] selftests/sgx: Fix corrupted cpuid macro invocation
Date: Mon, 6 Dec 2021 15:36:36 -0800 [thread overview]
Message-ID: <81e45f9e-046c-c708-cb98-080cc19587c2@intel.com> (raw)
In-Reply-To: <c4257eaf-ecf8-ed35-aa67-5594005aa68c@intel.com>
On 12/6/21 3:32 PM, Reinette Chatre wrote:
> My concern is actually about the kselftest framework where I could not
> answer the following question with certainty: why are there so many
> usages of cpuid but everybody writes their own instead of including
> cpuid.h? I am concerned that there are some environment constraints that
> I am not familiar with and thus decided to follow the custom.
I'm probably guilty of a case or two. There was no logic behind it,
just that I took and out-of-tree test and plopped it into the kernel
tree without looking for any selftest infrastructure.
next prev parent reply other threads:[~2021-12-06 23:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-04 20:23 [PATCH] selftests/sgx: Fix corrupted cpuid macro invocation Jarkko Sakkinen
2021-12-05 0:32 ` Reinette Chatre
2021-12-06 22:54 ` Dave Hansen
2021-12-06 23:32 ` Reinette Chatre
2021-12-06 23:36 ` Dave Hansen [this message]
2021-12-15 0:19 ` Reinette Chatre
2021-12-22 0:40 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=81e45f9e-046c-c708-cb98-080cc19587c2@intel.com \
--to=dave.hansen@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=jarkko@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-sgx@vger.kernel.org \
--cc=reinette.chatre@intel.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox