From: Jarkko Sakkinen <jarkko@kernel.org>
To: Kai Huang <kai.huang@intel.com>, "Du, Fan" <fan.du@intel.com>,
"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
"Li, Zhiquan1" <zhiquan1.li@intel.com>,
"linux-sgx@vger.kernel.org" <linux-sgx@vger.kernel.org>,
"Luck, Tony" <tony.luck@intel.com>,
"Hansen, Dave" <dave.hansen@intel.com>,
"Zhang, Cathy" <cathy.zhang@intel.com>
Cc: "Christopherson,, Sean" <seanjc@google.com>
Subject: Re: [PATCH v3 0/3] x86/sgx: fine grained SGX MCA behavior
Date: Tue, 07 Jun 2022 09:35:36 +0300 [thread overview]
Message-ID: <86eb19b512771098136e43fcdac95be8646357e4.camel@kernel.org> (raw)
In-Reply-To: <ccfc5dacc80454e35b0f13410abc8606832f7517.camel@intel.com>
On Mon, 2022-06-06 at 22:40 +1200, Kai Huang wrote:
> On Fri, 2022-06-03 at 13:15 +1200, Du, Fan wrote:
> > >
> > > This applies on top of Cathy's series, right? Why not send one
> > > series with all 12 patches included?
> > >
> > > It makes reviewing easier, and we are well beyond 5.19 timeline
> > > for these features.
> >
> > Patches from Zhiquan try to improve SGX MCA handling, actually this is a BUG
> > being
> > discussed with customer with SGX deployment already - SGX VM instance got
> > killed
> > in case of SGX application inside VM consumed poison EPC pages. Expected
> > behavior:
> > SGX application get killed only in such scenario.
> >
> > Seamless patchset from Catchy is another standalone feature, the design seems
> > still under discussion. Combining those two distinct purpose-built patchset
> > together
> > looks wired.
>
> Right. Those are two different features and I don't see why they should be sent
> out together.
>
> Btw, please also note Cathy's SGX rebootless recovery may never get accepted:
>
> https://lore.kernel.org/linux-sgx/Yo0xSNt0JKGgOG59@zn.tnic/T/#m4d1a56fc3ed547d200443dab50bed6484e6d2e1d
> https://lore.kernel.org/all/20220524185324.28395-1-bp@alien8.de/
Considering Zhiquan's series: all the patches have different message ID,
which puts them into different threads and makes it hard to apply.
E.g.
https://lore.kernel.org/linux-sgx/20220525100625.760633-1-zhiquan1.li@intel.com/T/#u
https://lore.kernel.org/linux-sgx/20220525100730.760815-1-zhiquan1.li@intel.com/T/#u
Zhiquan: can you send your patch series as a single series? Easiest
way to do it is to use git send-email. Right now the series broken.
BR, Jarkko
next prev parent reply other threads:[~2022-06-07 6:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-25 10:06 [PATCH v3 0/3] x86/sgx: fine grained SGX MCA behavior Zhiquan Li
2022-05-26 0:35 ` Jarkko Sakkinen
2022-06-03 1:15 ` Du, Fan
2022-06-06 10:40 ` Kai Huang
2022-06-07 6:35 ` Jarkko Sakkinen [this message]
2022-06-07 7:02 ` Zhiquan Li
2022-06-07 8:26 ` Jarkko Sakkinen
2022-06-07 15:43 ` Luck, Tony
2022-06-08 0:19 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86eb19b512771098136e43fcdac95be8646357e4.camel@kernel.org \
--to=jarkko@kernel.org \
--cc=cathy.zhang@intel.com \
--cc=dave.hansen@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=fan.du@intel.com \
--cc=kai.huang@intel.com \
--cc=linux-sgx@vger.kernel.org \
--cc=seanjc@google.com \
--cc=tony.luck@intel.com \
--cc=zhiquan1.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox