From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A9FDC48BD1 for ; Fri, 11 Jun 2021 17:36:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 69BA36136D for ; Fri, 11 Jun 2021 17:36:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230301AbhFKRio (ORCPT ); Fri, 11 Jun 2021 13:38:44 -0400 Received: from mail-il1-f169.google.com ([209.85.166.169]:44889 "EHLO mail-il1-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230083AbhFKRin (ORCPT ); Fri, 11 Jun 2021 13:38:43 -0400 Received: by mail-il1-f169.google.com with SMTP id i17so5871707ilj.11 for ; Fri, 11 Jun 2021 10:36:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=nfvuYmRSsrqKkyjyEJwVlbMYo9k7O1ojDR6LlSwhXjU=; b=XfOj3FwiQP8K/u3OJsZnizHlOFJfxR7Bd2wdLmqLUvqlqgrZvJaPzxA4nbAOh/LRXA +AAy3TtUD6/9mkfjBi8aXfYt1c1ZlTu5t0evVr5bNT900vs1SkvBBZ703Xd+DIH6qSe7 bBkogkR7NRSQtJdE8ad0j27TtzS1+/ksNmO1I= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=nfvuYmRSsrqKkyjyEJwVlbMYo9k7O1ojDR6LlSwhXjU=; b=o7sy3dn2cW3ApzXvES38vqO+Cj6awwJKMOfOw3CfvgAHOj+rR8lyMo7RAgvRgQiMW/ 1Hj20Chnbe62/jDbmQIdb+tSMIqUa3ztwQLw5B7rg2HrU3YqiACjSFjS69x194xOagDe NNtDFgEojr3/gWzGTHHSHtcOv7Bx3h8UVT+jWyY3sGOGmJM4ZjtMGq7qMkWjWubFZKR8 NhzmBcbKGcQYMp2C2ydgqj+M4MMeXyJx0R19yXAt6maC3cTgqPWnMl69gwvSPMMWJs6R 08slHFioHXh1hqgzWX5/3GKAGftnRHfFafwFPB9o+AjIiXkfnxdrtqhKHVsa4OX61dXS eH1w== X-Gm-Message-State: AOAM531l0TCoINLzzpT9m3/UCdQ7uxFUdK7aQfhOqukhFJs1rPK/XR0V 0I9dTYL9d3MsQqK0BfsDsR1R4g== X-Google-Smtp-Source: ABdhPJz2zS1moGpo4B3D+0PtoX9xhcuTLbzySQZz0s0BhV0VneF0Gb0XIcx3oyV4Aos51v9UFu1y2g== X-Received: by 2002:a05:6e02:20c8:: with SMTP id 8mr3946175ilq.67.1623432945447; Fri, 11 Jun 2021 10:35:45 -0700 (PDT) Received: from [192.168.1.112] (c-24-9-64-241.hsd1.co.comcast.net. [24.9.64.241]) by smtp.gmail.com with ESMTPSA id p10sm3980850ile.35.2021.06.11.10.35.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 11 Jun 2021 10:35:44 -0700 (PDT) Subject: Re: [PATCH v8 1/5] selftests/sgx: Rename 'eenter' and 'sgx_call_vdso' To: Dave Hansen , Jarkko Sakkinen , shuah@kernel.org Cc: linux-kselftest@vger.kernel.org, linux-sgx@vger.kernel.org, Reinette Chatre , Dave Hansen , linux-kernel@vger.kernel.org, Shuah Khan References: <20210610083021.392269-1-jarkko@kernel.org> From: Shuah Khan Message-ID: <8d071d3f-604f-1876-05bb-91568dd3c563@linuxfoundation.org> Date: Fri, 11 Jun 2021 11:35:44 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-sgx@vger.kernel.org On 6/10/21 9:45 AM, Dave Hansen wrote: > On 6/10/21 1:30 AM, Jarkko Sakkinen wrote: >> Rename symbols for better clarity: >> >> * 'eenter' might be confused for directly calling ENCLU[EENTER]. It does >> not. It calls into the VDSO, which actually has the EENTER instruction. >> * 'sgx_call_vdso' is *only* used for entering the enclave. It's not some >> generic SGX call into the VDSO. >> >> Signed-off-by: Jarkko Sakkinen > > These all look fine to me. Feel free to add my ack on them. > > Since these are pure x86 selftests and the initial code went through the > x86 maintainers, should these got through them as well? Or, since this > is only selftest code, should Shuah pick them up? > I will queue these up for 5.14-rc1 thanks, -- Shuah