From: Zhiquan Li <zhiquan1.li@intel.com>
To: Jarkko Sakkinen <jarkko@kernel.org>, <dave.hansen@linux.intel.com>
Cc: <linux-sgx@vger.kernel.org>, <tony.luck@intel.com>,
<tglx@linutronix.de>, <bp@alien8.de>, <seanjc@google.com>,
<kai.huang@intel.com>, <fan.du@intel.com>,
<cathy.zhang@intel.com>
Subject: Re: [PATCH RESEND v6 2/3] x86/sgx: Introduce union with vepc_vaddr field for virtualization case
Date: Mon, 29 Aug 2022 09:27:08 +0800 [thread overview]
Message-ID: <981df5cb-cd6a-e941-dc98-151257d4f1a8@intel.com> (raw)
In-Reply-To: <YwqQ1HRzdZNWM1VX@kernel.org>
On 2022/8/28 05:47, Jarkko Sakkinen wrote:
>> - struct sgx_encl_page *encl_owner;
>> + union {
>> + struct sgx_encl_page *encl_owner;
>> + /* Use when SGX_EPC_PAGE_KVM_GUEST set in ->flags: */
>> + void __user *vepc_vaddr;
> Revisiting this, I'd tend to think that simple
> "void *owner" would be less complicated option
> than this.
>
> Thoughts?
>
> BR, Jarkko
>
Thanks for your thought, Jarkko.
The reason is in the reply of patch 01, let's discuss it there.
Best Regards,
Zhiquan
next prev parent reply other threads:[~2022-08-29 1:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-26 16:05 [PATCH RESEND v6 0/3] x86/sgx: fine grained SGX MCA behavior Zhiquan Li
2022-08-26 16:05 ` [PATCH RESEND v6 1/3] x86/sgx: Rename the owner field of struct sgx_epc_page as encl_owner Zhiquan Li
2022-08-28 3:27 ` Jarkko Sakkinen
2022-08-29 1:23 ` Zhiquan Li
2022-08-29 12:14 ` Jarkko Sakkinen
2022-08-30 2:24 ` Zhiquan Li
2022-08-26 16:05 ` [PATCH RESEND v6 2/3] x86/sgx: Introduce union with vepc_vaddr field for virtualization case Zhiquan Li
2022-08-27 21:47 ` Jarkko Sakkinen
2022-08-29 1:27 ` Zhiquan Li [this message]
2022-08-29 12:29 ` Jarkko Sakkinen
2022-08-26 16:05 ` [PATCH RESEND v6 3/3] x86/sgx: Fine grained SGX MCA behavior for virtualization Zhiquan Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=981df5cb-cd6a-e941-dc98-151257d4f1a8@intel.com \
--to=zhiquan1.li@intel.com \
--cc=bp@alien8.de \
--cc=cathy.zhang@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=fan.du@intel.com \
--cc=jarkko@kernel.org \
--cc=kai.huang@intel.com \
--cc=linux-sgx@vger.kernel.org \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox