Re: [PATCH v3 04/28] x86/sgx: Use sgx_epc_lru_lists for existing active page list

Haitao Huang
2023-07-31T20:44:27Z

On Mon, 17 Jul 2023 07:47:01 -0500, Jarkko Sakkinen <jarkko@kernel.org>
wrote:

> On Wed Jul 12, 2023 at 11:01 PM UTC, Haitao Huang wrote:
>> From: Kristen Carlson Accardi <kristen@linux.intel.com>
>>
>> Replace the existing sgx_active_page_list and its spinlock with
>> a global sgx_epc_lru_lists struct.
>
> Similarly as the previous patch, I would extend this story a tiny
> bit forward to see the connection with the follow-up patches.
>
Sure

I also feel it may flow better by moving all changes related to
'unreclaimable' such as owner field for VA, flags for types of owners,
storing unreclaimables to LRU, etc. to later after all changes dealing
with reclaimables are introduced. The unreclaimables are only of concern
when OOM is involved so it'd be better to do them right before OOM.

Thanks
Haitao