From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8557CC0015E for ; Fri, 28 Jul 2023 19:04:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232453AbjG1TET (ORCPT ); Fri, 28 Jul 2023 15:04:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35270 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229572AbjG1TEQ (ORCPT ); Fri, 28 Jul 2023 15:04:16 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 999B93AB3; Fri, 28 Jul 2023 12:04:15 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0AC36621DA; Fri, 28 Jul 2023 19:04:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8E5FDC433C7; Fri, 28 Jul 2023 19:04:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690571054; bh=8DaWYZaCw2Xuxw5riz8+1tlUJan7UILXAqdOAeCekrE=; h=Date:Cc:Subject:From:To:References:In-Reply-To:From; b=iu97QwjZRPD1dV3JIDfuMmsy98jTiapiijoGQ5PPMgXnYqJiiiYJrFs9zRG7irxTC hWGquvIJSKt/jm8cfWonpOVx+HVoYWettmt88p7BTRR1iBAg1qkxnfxIW31cqPJPlw NaxQ3tdZskTlaqogr3a6y1qFOKiR8B/bIBTkVOkGQ1Pu2xFK3MlpLU6Z6jjQb5rQyv kE3LJuj2cSwO9om5EXncNvgiFPSnHvn5xi0x8ipyWbkf038zcyVFDhyarK56r9+xuI RbLlKQv8kYeKub7kpgWD5hqfuliU+VKBc5pUrBMTEd9Yq634WOawbGc6/a15HLhGM9 fGw5V0uqIgScQ== Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 28 Jul 2023 19:04:11 +0000 Message-Id: Cc: Subject: Re: [PATCH 1/5] selftests/sgx: Fix uninitialized pointer dereference in error path. From: "Jarkko Sakkinen" To: "Jo Van Bulck" , , X-Mailer: aerc 0.14.0 References: <20230724165832.15797-1-jo.vanbulck@cs.kuleuven.be> <20230724165832.15797-2-jo.vanbulck@cs.kuleuven.be> In-Reply-To: <20230724165832.15797-2-jo.vanbulck@cs.kuleuven.be> Precedence: bulk List-ID: X-Mailing-List: linux-sgx@vger.kernel.org On Mon Jul 24, 2023 at 4:58 PM UTC, Jo Van Bulck wrote: > Ensure ctx is zero-initialized, such that the encl_measure function will > not call EVP_MD_CTX_destroy with an uninitialized ctx pointer in case of = an > early error during key generation. > > Signed-off-by: Jo Van Bulck > --- > tools/testing/selftests/sgx/sigstruct.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/sgx/sigstruct.c b/tools/testing/self= tests/sgx/sigstruct.c > index a07896a46364..dd1fdab90e26 100644 > --- a/tools/testing/selftests/sgx/sigstruct.c > +++ b/tools/testing/selftests/sgx/sigstruct.c > @@ -318,9 +318,9 @@ bool encl_measure(struct encl *encl) > struct sgx_sigstruct *sigstruct =3D &encl->sigstruct; > struct sgx_sigstruct_payload payload; > uint8_t digest[SHA256_DIGEST_LENGTH]; > + EVP_MD_CTX *ctx =3D NULL; > unsigned int siglen; > RSA *key =3D NULL; > - EVP_MD_CTX *ctx; > int i; > =20 > memset(sigstruct, 0, sizeof(*sigstruct)); > --=20 > 2.34.1 Ditto. BR, Jarkko