Re: [RFC PATCH v3 03/27] x86/sgx: Remove a warn from sgx_free_epc_page()

Jarkko Sakkinen
2021-02-03T10:04:34Z

On Mon, Feb 01, 2021 at 01:11:10PM +1300, Kai Huang wrote:
> On Wed, 27 Jan 2021 14:26:52 +1300 Kai Huang wrote:
> > On Tue, 26 Jan 2021 17:12:12 -0800 Dave Hansen wrote:
> > > On 1/26/21 5:08 PM, Kai Huang wrote:
> > > > I don't have deep understanding of SGX driver. Would you help to answer?
> > >
> > > Kai, as the patch submitter, you are expected to be able to at least
> > > minimally explain what the patch is doing. Please endeavor to obtain
> > > this understanding before sending patches in the future.
> >
> > I see. Thanks.
>
> Hi Jarkko,
>
> I think I'll remove this patch in next version, since it is not related to KVM
> SGX. And I'll rebase your second patch based on current tip/x86/sgx. You may
> send out this patch independently. Let me know if you have comment.

I don't like to pre-ack changes.

My main concern is not to introduce multiple disjoint versions
of sgx_free_epc_page(). It is just not sane because you can do
an implementation where those don't exist.

/Jarkko