Re: [RFC PATCH v4 05/26] x86/sgx: Introduce virtual EPC for use by KVM guests

Jarkko Sakkinen
2021-02-12T12:15:34Z

On Tue, Feb 09, 2021 at 01:36:06PM -0800, Dave Hansen wrote:
> On 2/9/21 1:19 PM, Jarkko Sakkinen wrote:
> >> Without that clearly documented, it would be unwise to merge this.
> > E.g.
> >
> > - Have ioctl() to turn opened fd as vEPC.
> > - If FLC is disabled, you could only use the fd for creating vEPC.
> >
> > Quite easy stuff to implement.
>
> The most important question to me is not how close vEPC is today, but
> how close it will be in the future. It's basically the age old question
> of: do we make one syscall that does two things or two syscalls?
>
> Is there a _compelling_ reason to change direction? How much code would
> we save?

I'm not really concerned about saving any code, at all. I'm more
concerned of adding unnecessary bells and whistles to uapi.

IMHO when new uapi is adding it has the burden of ensuring that it is
relevant, and necessary.

For me it like now to be frank that I'm sure, which one is the right
way to go, i.e. I'm not positioned to any side. But being unsure neither
is not a great position to ack anything.

/Jarkko