From: Jarkko Sakkinen <jarkko@kernel.org>
To: Raoul Strackx <raoul.strackx@fortanix.com>
Cc: linux-sgx@vger.kernel.org
Subject: Re: [PATCH 1/3] x86/sgx: Adding eextend ioctl
Date: Thu, 1 Apr 2021 02:22:21 +0300 [thread overview]
Message-ID: <YGUELcaqrETXiv3R@kernel.org> (raw)
In-Reply-To: <1b002a72-139d-0ed3-28ea-0d4980e110f3@fortanix.com>
On Wed, Mar 31, 2021 at 02:18:50PM +0200, Raoul Strackx wrote:
> The current sgx driver can only launch enclaves that always measure 4K
> pages. That may not necessarily be the case. This patch adds an ioctl to
> enable users to add the enclave measurement per 256 byte.
Please run scripts/checkpatch.pl. You cannot write a long description in
a single line.
Also please write 'SGX' instead of 'sgx'.
I do understand the code change but also the current ioctl measure per 256
byte the full page. What I'm saying that the long description does not
contain any information what this patch adds to that. It neither makes the
case why it makes sense to have enclaves where full pages are not measured.
/Jarkko
next prev parent reply other threads:[~2021-03-31 23:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-31 12:18 [PATCH 1/3] x86/sgx: Adding eextend ioctl Raoul Strackx
2021-03-31 23:22 ` Jarkko Sakkinen [this message]
2021-04-01 14:52 ` Raoul Strackx
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YGUELcaqrETXiv3R@kernel.org \
--to=jarkko@kernel.org \
--cc=linux-sgx@vger.kernel.org \
--cc=raoul.strackx@fortanix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox