Re: [PATCH 3/4] selftests/sgx: Ensure enclave data available during debug print

Jarkko Sakkinen
2022-02-15T19:35:12Z

On Fri, Jan 28, 2022 at 10:23:58AM -0800, Reinette Chatre wrote:
> In support of debugging the SGX tests print details from
> the enclave and its memory mappings if any failure is encountered
> during enclave loading.
>
> When a failure is encountered no data is printed because the
> printing of the data is preceded by cleanup of the data.
>
> Move the data cleanup after the data print.
>
> Fixes: 147172148909 ("selftests/sgx: Dump segments and /proc/self/maps only on failure")
> Signed-off-by: Reinette Chatre <reinette.chatre@intel.com>
> ---
> tools/testing/selftests/sgx/main.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/testing/selftests/sgx/main.c b/tools/testing/selftests/sgx/main.c
> index a7cd2c3e6f7e..b0bd95a4730d 100644
> --- a/tools/testing/selftests/sgx/main.c
> +++ b/tools/testing/selftests/sgx/main.c
> @@ -186,8 +186,6 @@ static bool setup_test_encl(unsigned long heap_size, struct encl *encl,
> return true;
>
> err:
> - encl_delete(encl);
> -
> for (i = 0; i < encl->nr_segments; i++) {
> seg = &encl->segment_tbl[i];
>
> @@ -208,6 +206,8 @@ static bool setup_test_encl(unsigned long heap_size, struct encl *encl,
>
> TH_LOG("Failed to initialize the test enclave.\n");
>
> + encl_delete(encl);
> +
> return false;
> }
>
> --
> 2.25.1
>

Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>

/Jarkko