From: Jarkko Sakkinen <jarkko@kernel.org>
To: Kai Huang <kai.huang@intel.com>
Cc: Zhiquan Li <zhiquan1.li@intel.com>,
linux-sgx@vger.kernel.org, tony.luck@intel.com,
dave.hansen@linux.intel.com, seanjc@google.com, fan.du@intel.com,
cathy.zhang@intel.com
Subject: Re: [PATCH v4 2/3] x86/sgx: Fine grained SGX MCA behavior for virtualization
Date: Wed, 8 Jun 2022 11:13:21 +0300 [thread overview]
Message-ID: <YqBaIXHTnleGcEJB@iki.fi> (raw)
In-Reply-To: <4d0ff55937942835d45d629e4f53597a4b893c0a.camel@intel.com>
On Wed, Jun 08, 2022 at 03:52:46PM +1200, Kai Huang wrote:
> On Wed, 2022-06-08 at 11:26 +0800, Zhiquan Li wrote:
> > --- a/arch/x86/kernel/cpu/sgx/main.c
> > +++ b/arch/x86/kernel/cpu/sgx/main.c
> > @@ -715,6 +715,8 @@ int arch_memory_failure(unsigned long pfn, int flags)
> > struct sgx_epc_page *page = sgx_paddr_to_page(pfn << PAGE_SHIFT);
> > struct sgx_epc_section *section;
> > struct sgx_numa_node *node;
> > + int ret = 0;
> > + unsigned long vaddr;
>
> Please switch the order of the two variables so all of variables are in reverse
> Christmas style.
Yeah, we prefer that. Is it necessary to initialize ret?
BR, Jarkko
next prev parent reply other threads:[~2022-06-08 8:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-08 3:26 [PATCH v4 0/3] x86/sgx: fine grained SGX MCA behavior Zhiquan Li
2022-06-08 3:26 ` [PATCH v4 1/3] x86/sgx: Repurpose the owner field as the virtual address of virtual EPC page Zhiquan Li
2022-06-08 3:45 ` Zhiquan Li
2022-06-08 3:54 ` Kai Huang
2022-06-08 3:26 ` [PATCH v4 2/3] x86/sgx: Fine grained SGX MCA behavior for virtualization Zhiquan Li
2022-06-08 3:52 ` Kai Huang
2022-06-08 8:13 ` Jarkko Sakkinen [this message]
2022-06-08 8:33 ` Zhiquan Li
2022-06-08 3:26 ` [PATCH v4 3/3] x86/sgx: Fine grained SGX MCA behavior for normal case Zhiquan Li
2022-06-08 8:10 ` [PATCH v4 0/3] x86/sgx: fine grained SGX MCA behavior Jarkko Sakkinen
2022-06-08 9:12 ` Jarkko Sakkinen
2022-06-08 9:48 ` Zhiquan Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YqBaIXHTnleGcEJB@iki.fi \
--to=jarkko@kernel.org \
--cc=cathy.zhang@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=fan.du@intel.com \
--cc=kai.huang@intel.com \
--cc=linux-sgx@vger.kernel.org \
--cc=seanjc@google.com \
--cc=tony.luck@intel.com \
--cc=zhiquan1.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox