From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88AE9C6FA82 for ; Thu, 8 Sep 2022 23:32:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230355AbiIHXcT (ORCPT ); Thu, 8 Sep 2022 19:32:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34256 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230353AbiIHXb7 (ORCPT ); Thu, 8 Sep 2022 19:31:59 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DE77D1402C; Thu, 8 Sep 2022 16:29:30 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D86E661E6B; Thu, 8 Sep 2022 23:28:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BEDDFC433D6; Thu, 8 Sep 2022 23:28:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662679705; bh=Eo93VCMrgvKOMrm1ftkl2pC8sCfd6qOMdIaidBm6YlQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=attQb81Uoww89Ha9CLEDtpSNRdfmtwWQWGtN35eNo1MneyQZGUwbuD4CIi7WvoL0B eVhzP3RMDshfKAmslGCe6m9pFRkYAL9YOzeQC2Yl37k8sWpmsaHuFMwX32gB6u4as1 AAOopsHyXyg/A5NmE456sAqQMDJPf4W75+nPOrEJcSZR1o82HYS9BY5oSocbVFnusb IqFQkoXcJ2yfjj7mrJoFJamv/9m+n+Gk7qEdcYXAhDF5lG6lN5A24E42TztURIiUHe nXnEygMWqwBw3qwKURRbS5rqhvPeRTxIun5Hzf5ZY/DE8sa0W2gw8fkEKsD+fFhD3K HVJhoDA8HfGCA== Date: Fri, 9 Sep 2022 02:28:18 +0300 From: Jarkko Sakkinen To: Reinette Chatre Cc: linux-sgx@vger.kernel.org, Haitao Huang , Vijay Dhanraj , Dave Hansen , Shuah Khan , "open list:KERNEL SELFTEST FRAMEWORK" , open list Subject: Re: [PATCH v2 5/5] selftests/sgx: Add SGX selftest augment_via_eaccept_long Message-ID: References: <20220905020411.17290-1-jarkko@kernel.org> <20220905020411.17290-6-jarkko@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-sgx@vger.kernel.org On Thu, Sep 08, 2022 at 03:44:29PM -0700, Reinette Chatre wrote: > Hi Jarkko and Vijay, > > On 9/4/2022 7:04 PM, Jarkko Sakkinen wrote: > > From: Vijay Dhanraj > > > > Add a new test case which is same as augment_via_eaccept but adds a > > larger number of EPC pages to stress test EAUG via EACCEPT. > > > > Signed-off-by: Vijay Dhanraj > > Signed-off-by: Jarkko Sakkinen > > --- > > ... > > > diff --git a/tools/testing/selftests/sgx/main.c b/tools/testing/selftests/sgx/main.c > > index 78c3b913ce10..e596b45bc5f8 100644 > > --- a/tools/testing/selftests/sgx/main.c > > +++ b/tools/testing/selftests/sgx/main.c > > @@ -22,8 +22,10 @@ > > #include "main.h" > > > > static const size_t ENCL_HEAP_SIZE_DEFAULT = PAGE_SIZE; > > +static const unsigned long TIMEOUT_DEFAULT = 900; > > I am not sure about the naming here ... it is _very_ close to > (and thus appears to be in the same namespace as) > TEST_TIMEOUT_DEFAULT from the included kselftest_harness.h. > > This is surely a nitpick but how about SGX_TEST_TIMEOUT_DEFAULT? Agreed, I would use ENCL_TEST_TIMEOUT_DEFAULT (better match with existing names). > > > static const uint64_t MAGIC = 0x1122334455667788ULL; > > static const uint64_t MAGIC2 = 0x8877665544332211ULL; > > + > > There is an extra empty line here ... but it looks like intended code > organization? Yeah, I think it'd make sense to have it there and would not be productive to make it a separate patch. > > > vdso_sgx_enter_enclave_t vdso_sgx_enter_enclave; > > > > /* > > > Apart from the naming comment this addition looks good. > > This is a valuable addition to the SGX tests. > > Reinette Thank you. BR, Jarkko