Re: [PATCH v3 17/28] x86/sgx: fix a NULL pointer

Jarkko Sakkinen
2023-07-17T18:52:21Z

On Mon Jul 17, 2023 at 3:49 PM UTC, Dave Hansen wrote:
> On 7/17/23 05:48, Jarkko Sakkinen wrote:
> > On Wed Jul 12, 2023 at 11:01 PM UTC, Haitao Huang wrote:
> >> Under heavy load, the SGX EPC reclaimers (ksgxd or future EPC cgroup
> >> worker) may reclaim SECS EPC page for an enclave and set
> >> encl->secs.epc_page to NULL. But the SECS EPC page is required for EAUG
> >> in #PF handler and is used without checking for NULL and reloading.
> >>
> >> Fix this by checking if SECS is loaded before EAUG and load it if it was
> >> reclaimed.
> >>
> >> Signed-off-by: Haitao Huang <haitao.huang@linux.intel.com>
> > A bug fix should be 1/*.
>
> No, bug fixes should not even be _part_ of another series. Send bug
> fixes separately, please.

Yes, that would be of course a better option.

BR, Jarkko