From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7049C283C93; Mon, 29 Jun 2026 17:41:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782754874; cv=none; b=QSWJd0o1lNkifAqvxo6AZM4s4FkTXEmkNs/OWRTKQ31KIuPYEUM4kUmE+0WB3ncm9rz8FTRgXw7haoXdjckk802ak6DOyHF4Z7Nl0tsCDTFPS1AVKHVnFYmcnWI7O8Hv1c9WrSVgMxfARakGuDULi/Vgh5iJyYKDcjs1cisNoA4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782754874; c=relaxed/simple; bh=7ogGndBpHueGVWrVa5AFFYzim8+s377QhCGSJtKEE4Y=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=HqNgkNH63iYbJl//aXWeZhI4qbF9JTi6yeWgRgPboabelH82so8iCclbwZfwjPzGSuGkyeRA+NdwIlyrMD7UjAeOPBPv6zmS2MRo0U73Q15M7hzH4vT9ZPSeJzP79ECU8mqd9TxsMnP0qUNcvnG0VpQ4hVr0pONI0T2cIsRqq1c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=JwaoyB6l; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="JwaoyB6l" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5EA521F000E9; Mon, 29 Jun 2026 17:40:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782754873; bh=aQOiijNvdTgOg0ZDAoyrNzD33sjFLDelNYagWZ6KgVc=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=JwaoyB6lWKH7ik47HITJbeTKRuRVfEO/0pfh+FINdeuw0SW8eTRpmytBGps7cxq+S kCNxhF/4sUF9JTuYBPt+gxEficptfxjI4Ts803QKT6eKGg4SzB2GwWxKUWqlCQn0l9 8f9cXn9tIT+sPqdX3U0y0w9x3G09VMFKEVU1DGcxCD4GVjIrlUxjbdU0zRQEz8q7QC mcugOs41Y7eE/Nj43NtJtSgVb0EqBim8qmc/DbOOo6P9Tky+uXOtwwn26EwNHq3UCN XCWemy+r6UszZnRM3oT+U8VC1D0qCApuNOrmYwKXCeFmYfWusMxcdVWgEhsuAemzi7 qVl/nL+loLawQ== Date: Mon, 29 Jun 2026 18:40:51 +0100 From: Lorenzo Stoakes To: Gregory Price Cc: Andrew Morton , Russell King , Dinh Nguyen , Simon Schuster , "James E . J . Bottomley" , Helge Deller , Jarkko Sakkinen , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Ian Abbott , H Hartley Sweeten , Lucas Stach , David Airlie , Simona Vetter , Patrik Jakobsson , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Clark , Dmitry Baryshkov , Tomi Valkeinen , Thierry Reding , Mikko Perttunen , Jonathan Hunter , Christian Koenig , Huang Rui , Ankit Agrawal , Alex Williamson , Alexander Viro , Christian Brauner , Dan Williams , Muchun Song , Oscar Salvador , David Hildenbrand , Suren Baghdasaryan , "Liam R . Howlett" , Matthew Wilcox , Marek Szyprowski , Peter Zijlstra , Arnaldo Carvalho de Melo , Namhyung Kim , Masami Hiramatsu , Oleg Nesterov , Steven Rostedt , SeongJae Park , Miaohe Lin , Hugh Dickins , Mike Rapoport , Kees Cook , Paolo Bonzini , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-parisc@vger.kernel.org, linux-sgx@vger.kernel.org, etnaviv@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-tegra@vger.kernel.org, kvm@vger.kernel.org, linux-fsdevel@vger.kernel.org, nvdimm@lists.linux.dev, linux-mm@kvack.org, iommu@lists.linux.dev, linux-perf-users@vger.kernel.org, linux-trace-kernel@vger.kernel.org, kasan-dev@googlegroups.com, damon@lists.linux.dev, Pedro Falcato , Rik van Riel , Harry Yoo , Jann Horn Subject: Re: [PATCH 05/30] mm/rmap: update mm/interval_tree.c comments Message-ID: References: <80d482a927b2e9862487b812e0ab48ebc1289a70.1782735110.git.ljs@kernel.org> Precedence: bulk X-Mailing-List: linux-sgx@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Jun 29, 2026 at 01:11:19PM -0400, Gregory Price wrote: > On Mon, Jun 29, 2026 at 05:41:16PM +0100, Lorenzo Stoakes wrote: > > On Mon, Jun 29, 2026 at 12:01:02PM -0400, Gregory Price wrote: > > > On Mon, Jun 29, 2026 at 01:23:16PM +0100, Lorenzo Stoakes wrote: > > > > Update the file comment to clarify that both file-backed and anonymous > > > > interval trees are provided, referencing the relevant data types for > > > > clarity. > > > > > > > > > > Isn't this self-evident by nature of the function definitions? > > > (one takes a vm_area_struct, the other takes an anon_vma_chain) > > > > Well you see you're already hitting up on issues there, they both take an > > rb_root_cached and the vma_*() ones do not instantly scream 'file-backed' do > > they? As VMAs are obviously used for buth anon and file-backed... > > > > But later patches fix this stuff :) > > > > And I feel it's hard visually to see where one set of definitions end and > > another begins, which was really the motive for this, as trivial as it is! > > > > Fair enough, I scanned the rest initially but trying to wrap my head > around everything as i go through one by one. Generally this really > screams "fix the apis" not "comment the bad ones" - but i suppose that's > the whole point here. Yeah intent is to eventually completely remove the anon stuff from here at least :) And Pedro I think is looking at the file rmap so we'll get there :) > > It's definitely an improvement either way. > > Reviewed-by: Gregory Price > > ~Gregory Cheers, Lorenzo