From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f44.google.com (mail-qv1-f44.google.com [209.85.219.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 03C1B33B97A for ; Thu, 9 Jul 2026 15:49:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783612169; cv=none; b=ive5RTeeY9BYVkHaBncxA3EYY/nHE+TTP0AKWYFcYNxKzozbnhxDVSHD+DRBeL4kCg3oZpRmNe4D6AKslSVb25qpaqWkqvcOnTQmkdNsOUhVNlAcqz6Xc4LyM5wjDJiF3GbJygfpOM91QHxa7hRXIuIuBI5Z1OI8v066E//N82Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783612169; c=relaxed/simple; bh=0qkqAHRaBHgpB2UR0C6dAMPOVUmsbtzeoEt8MNK67Xo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=q36yZ3StuIXiXxLqV85jHaVBxzqMFO4QOG2Od6PMmCgN2Jo6f3mn1xVOs+MGUuDyNCu9vMf368c5SUlhHN0VX1P+hnqXORLEWw1z1AXL4bOtkp3DjrOubK0jZPUmUrP0VT5HRwxte9PROvV1RoVbw8aZ29zNl7Gz7y3osE1vhDY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net; spf=pass smtp.mailfrom=gourry.net; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b=MkQCpSd2; arc=none smtp.client-ip=209.85.219.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gourry.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b="MkQCpSd2" Received: by mail-qv1-f44.google.com with SMTP id 6a1803df08f44-8efef6533aaso436056d6.0 for ; Thu, 09 Jul 2026 08:49:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1783612166; x=1784216966; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=hryUWYzOZzjuIh9gJx+Hzg+n+E360+tJZh4R7BZGeLA=; b=MkQCpSd2m04untsXU1nx9KbvtduhWS0cCQoIcza8A3pVIhVf9PRW/CsEN/DZAtCuls p7RoVeKsjloxBKU2AfxnCCAN8lhXWQBNDMfPG7gVZRfQmXhyKackY8MGGcFAEPPVy0Fv SDU2e8AQxkDk3sY44SjU+DAZTvcrqgnaYjF6Y4p8tOSybH+22dFesBK1qZJowyT//dMI 6ZToGGs97IuDvRPOGP/+9UTODYx8cfsPo8904OY1zAoe+0Q0w2DVPfcKw8nstjaGRKyi ELgcN2ve0gKuNONy45AfjzXvUlPyOrsp6pJgUy/3Xnn2gf7Puzf5UJmIyCvxOjIpgVPr CZNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783612166; x=1784216966; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=hryUWYzOZzjuIh9gJx+Hzg+n+E360+tJZh4R7BZGeLA=; b=ItwOJZlo0Ynu9gE13iCi7y5Jv6Se7ALxCQwaHch40BYKWqHAswmCZgCG0e1Ukt0BDm 64dfk4aAxRGvO5vI+grUJUarOvtpvwa9sfYAsgKBQdSLKSXXyJKHlsqyWgPICWIXgZrZ QrnjdLJ5xiOuAYqrQAKf6zU/ThqOQ/Lqw90ILxNJfsb8RanxR+zMRomnxidg2OVVPZxw eAJZeWLu83cPNwg9iZybtZfJ3waRiz/JkIRJu0VdAY90lBXCHeGsn/BqaojWc9wq/0nM e+9dIsAejrYErmJ7AxVlbWwbMgQo0Ap2SYxgyyB1CG2LxRXPSwTmd7yeAMO1bKvrBV74 jxuQ== X-Forwarded-Encrypted: i=1; AHgh+Rqjp3tFnFWHO64YaCJGLLayAugM4GYupqbcuDl1mqf7ec7ugPf/5UzPL9r+lZFo7vp1JZbY0y1//AM=@vger.kernel.org X-Gm-Message-State: AOJu0YzIWvSL787rV2qUp7OO+hA7AuBgPaMpnJ7N0zVkx07VFwC19hVc cLXp1gknSvOnDWK6p59XeXA0nO1V+wc814k42Y2VckqZn0HzgVP/4tcP/H2BMO1gPq0= X-Gm-Gg: AfdE7cn6/YRGewhlNXfpT+8kMLLCAMsn3qd+lZjjuQZNev/eBXzxlHA23MLLu8cEVwc YWv1xvjgk4GpB6gH0jWhOeLTUvIMGK+j6qxHALyu5y4U8Dnstdw9thWg/dZt7yXhtyT7EgQdE9u zsOpyU3q86o4jmJzfXq+pixsBSKuKv9Y2sMa6Qh0YArc9eEyy6Unb734PkvvFxL+Iru8ScLV3ck JuS3TzGqYodlFaJR5Xepl4HGPsmjw1di9ZfbqvK0kLHmpgXmY85P+bTLuA0i/kYkBywi0UvljKE MiV7wji/+J1JYJdmyhUiI2WE1D5X7Ajam/Yadxmo4+HibxN3kz+tgrypHOTvf17wAlvCTzi04XD RY4fcQ/HzcYoqhS7kdVa1xK4T4qu/Z7ORsr9aIEvNkYx13jKUcwr8vmoaapIt+F3bWobhhKa8n0 r6l6ys60hWxUsOMyNipP3NdyLGboWx/2kM/YlyVN8UUw/tXBhBsje2mNYRH/wUUIMxCFg3 X-Received: by 2002:ad4:5c8a:0:b0:8cc:2a92:48e4 with SMTP id 6a1803df08f44-8fec217b8bfmr87997286d6.32.1783612165998; Thu, 09 Jul 2026 08:49:25 -0700 (PDT) Received: from gourry-fedora-PF4VCD3F (pool-173-79-60-52.washdc.fios.verizon.net. [173.79.60.52]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8ffd7c1d9f6sm20164456d6.23.2026.07.09.08.49.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Jul 2026 08:49:24 -0700 (PDT) Date: Thu, 9 Jul 2026 11:49:18 -0400 From: Gregory Price To: Lorenzo Stoakes Cc: Pedro Falcato , Andrew Morton , Russell King , Dinh Nguyen , Simon Schuster , "James E . J . Bottomley" , Helge Deller , Jarkko Sakkinen , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Ian Abbott , H Hartley Sweeten , Lucas Stach , David Airlie , Simona Vetter , Patrik Jakobsson , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Clark , Dmitry Baryshkov , Tomi Valkeinen , Thierry Reding , Mikko Perttunen , Jonathan Hunter , Christian Koenig , Huang Rui , Ankit Agrawal , Alex Williamson , Alexander Viro , Christian Brauner , Dan Williams , Muchun Song , Oscar Salvador , David Hildenbrand , Suren Baghdasaryan , "Liam R . Howlett" , Matthew Wilcox , Marek Szyprowski , Peter Zijlstra , Arnaldo Carvalho de Melo , Namhyung Kim , Masami Hiramatsu , Oleg Nesterov , Steven Rostedt , SeongJae Park , Miaohe Lin , Hugh Dickins , Mike Rapoport , Kees Cook , Paolo Bonzini , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-parisc@vger.kernel.org, linux-sgx@vger.kernel.org, etnaviv@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-tegra@vger.kernel.org, kvm@vger.kernel.org, linux-fsdevel@vger.kernel.org, nvdimm@lists.linux.dev, linux-mm@kvack.org, iommu@lists.linux.dev, linux-perf-users@vger.kernel.org, linux-trace-kernel@vger.kernel.org, kasan-dev@googlegroups.com, damon@lists.linux.dev, Rik van Riel , Harry Yoo , Jann Horn Subject: Re: [PATCH 17/30] mm: prefer vma_[start,end]_pgoff() to vma->vm_pgoff in kernel/ Message-ID: References: Precedence: bulk X-Mailing-List: linux-sgx@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Jul 02, 2026 at 12:30:59PM +0100, Lorenzo Stoakes wrote: > ... > static inline unsigned long vma_offset(const struct vm_area_struct *vma, > const unsigned long address) > { > /* Retains page offset and tags. */ > return address - vma->vm_start; > } > ... > And I'm not sure it's really all that useful. Perhaps retaining vma_offset() > would be though. > Silly question: What's the purpose of retaining tags in a non-address value? That sounds like there's fragility just waiting to be broken. (I presume you are talking about things like ARM MTE and such, right?) > This is one that I think makes more sense. > > But in general, I'd rather hold off from yet more churn here. > > I'm making these changes to establish a basis for virtual page offsets > introduced in [0], rather than just cleaning up in general. > I agree with this. If the refactors here suddenly have to think about corner cases on things like tags, that's better resolved separately. ~Gregory