From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f175.google.com (mail-qt1-f175.google.com [209.85.160.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2E0393BB68F for ; Fri, 10 Jul 2026 21:21:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783718467; cv=none; b=uBZrpwedmVWxUU0T5/HcnetrwEnCqMSaUTy+MxDfoZtkU3AfHOjYSubsG6SWhoNUEfty7d/gfQEoDAzdqrrVFe3bnhxSePPBsWh0fhgGZV4zC2DO5CUiRoWgFQVHboItEYZNBknVpWrvyqSuYvJXEmfXzBv2O6rt+nwbmzDM0RU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783718467; c=relaxed/simple; bh=OrArmp546t2joLiGKmZojGNI2jG19j2P4RpxQaXcMQU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=W3wJSMCppR2Emg4ipdPjH1XIKgKZK0O0REVT7M7TfxGfPJUE5xwm2/76zparDSHI8Op2yp6ILgW7Q59qQ9+nDTBYAmcbFYbPKBW6CyqTUGXEfMcLUU65YA6D4Hh1KjPf0/MPoQCn+MC21YPQNd9ufdC5T8KJxh0aS9JW0QnC43U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net; spf=pass smtp.mailfrom=gourry.net; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b=WrsZLakZ; arc=none smtp.client-ip=209.85.160.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gourry.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b="WrsZLakZ" Received: by mail-qt1-f175.google.com with SMTP id d75a77b69052e-51bfad59921so8387191cf.0 for ; Fri, 10 Jul 2026 14:21:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1783718463; x=1784323263; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=kBOMvPUpfjw5N1/s9nVKhxGNiyKZIoN9dPtD8sVM7ho=; b=WrsZLakZJT/5oETG2Se79/v9kdjkpEQDr7Yp+OGw79X3NAKPcDAh1QSIBTgD1APIk9 PcNtWnmXjzVyA/ekAuc9J1Ldf1520O+Ezw0w/Ib2rmg9zLzxvlAdRLVhZhEA8PmWUNiK TQNQjHvefwSfVxq1+ZCz986aNPT/4H/tI61eQYAsQJpO4szsu8Cjyex71k+0GpxpujLy wBnlnlMi5HipUbm2ZzOkDOrRTbcr6VJAyIpY72aJ/E32HuOp1s4SJDdzj0BVE5V3xg8/ VUpFjW6w8Fy4sl1gdFaDfoPbhesiNrFc9fyD8+l3IKOSNiiupFoFQbmh3CqhrxND/l+7 UddQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783718463; x=1784323263; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=kBOMvPUpfjw5N1/s9nVKhxGNiyKZIoN9dPtD8sVM7ho=; b=X4MdWW+G0Nf+nxYyJwg+c9xuUxHM289tni9iMsQh94t7qES4gvsdtE0ITtNM2YT0wd IpQoLbbxCm//B6YAJjhQkz3SnWmUn8MlbONeq6GWFZWrourpgJmjm2DvZXckbTBmmAYQ UNcc2m4d4rIqdAAfbgnWTDTO/0X8HsrVTGXDyAghxpI4Bm/wG9J5SiXYe82QahoJG1qX UVwspm1bKwnQdhIgkib/MeGIsU33ohRW3nsFmcQJfw5fQJJqfVu4hGdU/fAlXxk68Yi+ hRt9Howbbra+tpKtXGcSyMCnuy3CIzCQDEXgxGmlTUYgq8UanTO5K0nh4t2dflxkQMnQ TjYw== X-Forwarded-Encrypted: i=1; AHgh+Rrfr/yKgQi4RV+SDipcKemG3n6rGie6i13GECLjcveitbokiOetU9SuJLTUZLvgg4Q6DyxAv+ifwME=@vger.kernel.org X-Gm-Message-State: AOJu0YxJHYWET3FSUppQhjD1lvuUChTfzeCCeVJ0oBVSGb4X2B3NDvH8 n8QQHx0dtUcY88TPB1OHZrEoesdrpj1xlDOTANonN8KtlkxMSZIN3TZbKYw+0YH37zY= X-Gm-Gg: AfdE7clcKstMTgydyv7JDqhNrC2ybXLb8BAelqqM4tXt9pbdGwKxr/XW48fxwrhz3cX gfJnuEi+yRBlJhcDDADdGdwdCm4abA70pW0/vyrqTnkUYAFR4ac3tZCCHv5vR0JB0RTPxEikO/V s6HcMbSxvZucK6mw3H1uXNyjjzwfgwGDmCFjl1HQrvCj+7KaQBOqeAR3zkW2T1M6uIMU82VjfRt KdrEOT6BIcw5sUuE4wHD6Lvn+/ugT8V+LjuWaGy4E0VeD6k5n5dm0cvbks2f8FucXq3cDG06MFb E/vQAqAzosguNdlhkk4RcdS1o0FDWYDnWZGfRHbiudyfygTQuqZ5YGQ6Xnn4lXlrhy8TBZAd+j5 6aQt7qHIM/s8+D2pdMBcTyeAsXdM+ojFJ919syMR+gi/p/xxUVYAdUpDw/ir78esCv8qesUqGQ+ jEwvIOOoDE5/w8R0piuB7Uu8PKx42fBPXYSRbFCTts2YZkk0xsZYyZrKWlRf40ddy87169 X-Received: by 2002:ac8:5ace:0:b0:51c:7b11:41ae with SMTP id d75a77b69052e-51cbf2dffb2mr6287721cf.74.1783718463047; Fri, 10 Jul 2026 14:21:03 -0700 (PDT) Received: from gourry-fedora-PF4VCD3F (pool-173-79-60-52.washdc.fios.verizon.net. [173.79.60.52]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-51caaf621e6sm23894971cf.24.2026.07.10.14.21.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jul 2026 14:21:01 -0700 (PDT) Date: Fri, 10 Jul 2026 17:20:56 -0400 From: Gregory Price To: Lorenzo Stoakes Cc: Andrew Morton , David Hildenbrand , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Rik van Riel , Harry Yoo , Jann Horn , Lance Yang , Pedro Falcato , Russell King , Dinh Nguyen , Simon Schuster , "James E.J. Bottomley" , Helge Deller , Alexander Viro , Christian Brauner , Jan Kara , Dan Williams , Matthew Wilcox , Muchun Song , Oscar Salvador , Masami Hiramatsu , Oleg Nesterov , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , x86@kernel.org, "H. Peter Anvin" , Ian Abbott , H Hartley Sweeten , Lucas Stach , Christian Gmeiner , David Airlie , Simona Vetter , Patrik Jakobsson , Paolo Bonzini , Shakeel Butt , Usama Arif , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-parisc@vger.kernel.org, linux-fsdevel@vger.kernel.org, nvdimm@lists.linux.dev, linux-perf-users@vger.kernel.org, linux-trace-kernel@vger.kernel.org, damon@lists.linux.dev, iommu@lists.linux.dev, kasan-dev@googlegroups.com, linux-sgx@vger.kernel.org, etnaviv@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-tegra@vger.kernel.org, kvm@vger.kernel.org, Russell King Subject: Re: [PATCH v2 26/33] mm/vma: update vma_shrink() to not pass start, pgoff parameters Message-ID: References: <20260710-b4-pre-scalable-cow-v2-0-2a5aa403d977@kernel.org> <20260710-b4-pre-scalable-cow-v2-26-2a5aa403d977@kernel.org> Precedence: bulk X-Mailing-List: linux-sgx@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260710-b4-pre-scalable-cow-v2-26-2a5aa403d977@kernel.org> On Fri, Jul 10, 2026 at 09:17:07PM +0100, Lorenzo Stoakes wrote: > vma_shrink() is only used by relocate_vma_down() to shrink the tail of a > VMA. Therefore neither the start nor the pgoff parameters make any sense. > > It seemed we were passing the pgoff parameter solely to satisfy > vma_set_range()'s requirement for pgoff being specified. > > Since vma_set_range() is now isolated to vma.c, we can simply introduce > __vma_set_range() which sets only vma->vm_[start, end], and invoke this > instead, removing start and pgoff from vma_shrink() altogether. > > No functional change intended. > > Reviewed-by: Pedro Falcato > Signed-off-by: Lorenzo Stoakes Carry over from v1 Reviewed-by: Gregory Price