From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66D9AC49361 for ; Mon, 14 Jun 2021 20:17:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5321C61246 for ; Mon, 14 Jun 2021 20:17:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234836AbhFNUTV (ORCPT ); Mon, 14 Jun 2021 16:19:21 -0400 Received: from mail-ot1-f52.google.com ([209.85.210.52]:34700 "EHLO mail-ot1-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234787AbhFNUTU (ORCPT ); Mon, 14 Jun 2021 16:19:20 -0400 Received: by mail-ot1-f52.google.com with SMTP id w22-20020a0568304116b02904060c6415c7so9751579ott.1 for ; Mon, 14 Jun 2021 13:17:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=hOOlcHmoJBs6LQNLgT05L8MZVpTB0XNq9JFGsS9UAmY=; b=YdJ/kzTceSN94t2UrgrvaDVjmYdqq/+un1rAO6TKwE1MUTJT1Zeo/Boqf5onMt+mL/ hmk56MPSs7jZeCFPKR/exvnfIPzAMmKbHflF7THbfbAez+YSJpCEGwnbiTlYwkOooOEA PUNxOVYoUJ5ZhD2rxvEQtjhUmvKt/v6gFSC5k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=hOOlcHmoJBs6LQNLgT05L8MZVpTB0XNq9JFGsS9UAmY=; b=ssZ6fE97ZzbCh4XPC9sPOqS7Q3l9emE1dgak3xLQROxa3rowqG5KeIMSIMlPTCgaQj PSSBRFPOhpp3ZjYtd2Du39SbzFc3SBK5SmjiJyV4JN2/LIrHBhBlI7qtr4NoUlkQg7Db VRe5PHKhRUcUyPFQaLDYGkkbx/qAwmjUvw5Qo23ibiJbgyB8gnNosz0YVI/u2mUbG3ue 2lpKLFfChssLmVaqcu1Fl5xY6hdD2Q3opeuQWhhuL7LXr2C2kPUKRRH27J9II8fhIOoU mDqL+iJICQwuyd46beGB1h4t947UtcPmNtyyCy50mBdYNjtOlu4TpOTHyJY9jqZV2+Cg 50DA== X-Gm-Message-State: AOAM533E3CRQUBfFSL4gjxwU0V71RP8iUHzSovnSRT1ik9hjivQf4hrs UEnspUqIR7H4BTvvtQAh6540Tg== X-Google-Smtp-Source: ABdhPJw1WFHlL52QYsydZyxdmDIQlaJFxO/pMyttFGCSrVmvo4WbwgmvznQBGndync8tE4sSUVPJ6Q== X-Received: by 2002:a9d:7f8e:: with SMTP id t14mr15079324otp.49.1623701776807; Mon, 14 Jun 2021 13:16:16 -0700 (PDT) Received: from [192.168.1.112] (c-24-9-64-241.hsd1.co.comcast.net. [24.9.64.241]) by smtp.gmail.com with ESMTPSA id x2sm3259215oog.10.2021.06.14.13.16.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Jun 2021 13:16:16 -0700 (PDT) Subject: Re: [PATCH v8 5/5] selftests/sgx: Refine the test enclave to have storage To: Jarkko Sakkinen , shuah@kernel.org Cc: linux-kselftest@vger.kernel.org, linux-sgx@vger.kernel.org, Reinette Chatre , Dave Hansen , linux-kernel@vger.kernel.org, Shuah Khan References: <20210610083021.392269-1-jarkko@kernel.org> <20210610083021.392269-5-jarkko@kernel.org> From: Shuah Khan Message-ID: Date: Mon, 14 Jun 2021 14:16:15 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210610083021.392269-5-jarkko@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-sgx@vger.kernel.org On 6/10/21 2:30 AM, Jarkko Sakkinen wrote: > Extend the enclave to have two operations: ENCL_OP_PUT and ENCL_OP_GET. > ENCL_OP_PUT stores value inside the enclave address space and > ENCL_OP_GET reads it. The internal buffer can be later extended to be > variable size, and allow reclaimer tests. > > Signed-off-by: Jarkko Sakkinen > --- > tools/testing/selftests/sgx/defines.h | 10 ++++ > tools/testing/selftests/sgx/main.c | 57 ++++++++++++++++++----- > tools/testing/selftests/sgx/test_encl.c | 19 +++++++- > tools/testing/selftests/sgx/test_encl.lds | 3 +- > 4 files changed, 74 insertions(+), 15 deletions(-) > Test output before applying the series: TAP version 13 1..1 # selftests: sgx: test_sgx # Unable to open /dev/sgx_enclave: No such file or directory # 1..0 # SKIP cannot load enclaves ok 1 selftests: sgx: test_sgx # SKIP Test output after applying second patch selftests/sgx: Migrate to kselftest harness Output changes to the following. It doesn't look like the second patch adds any new tests. What is the point in running the tests that fail if /dev/sgx_enclave is missing. Unfortunately this series doesn't have a cover letter that explains what this series is doing. I don't like the fact that the test output and behavior changes when migrating the test to kselftest harness. Shouldn't the output stay the same as in skip the tests if /dev/sgx_enclave fails. TAP version 13 1..1 # selftests: sgx: test_sgx # TAP version 13 # 1..3 # # Starting 3 tests from 2 test cases. # # RUN enclave.unclobbered_vdso ... # Unable to open /dev/sgx_enclave: No such file or directory # ok 2 # SKIP cannot load enclaves # # Planned tests != run tests (3 != 1) # # Totals: pass:0 fail:0 xfail:0 xpass:0 skip:1 error:0 # # unclobbered_vdso: Test failed at step #4 # # FAIL enclave.unclobbered_vdso # not ok 1 enclave.unclobbered_vdso # # RUN enclave.clobbered_vdso ... # Unable to open /dev/sgx_enclave: No such file or directory # ok 3 # SKIP cannot load enclaves # # Planned tests != run tests (3 != 2) # # Totals: pass:0 fail:1 xfail:0 xpass:0 skip:1 error:0 # # clobbered_vdso: Test failed at step #4 # # FAIL enclave.clobbered_vdso # not ok 2 enclave.clobbered_vdso # # RUN enclave.clobbered_vdso_and_user_function ... # Unable to open /dev/sgx_enclave: No such file or directory # ok 4 # SKIP cannot load enclaves # # Totals: pass:0 fail:2 xfail:0 xpass:0 skip:1 error:0 # # clobbered_vdso_and_user_function: Test failed at step #4 # # FAIL enclave.clobbered_vdso_and_user_function # not ok 3 enclave.clobbered_vdso_and_user_function # # FAILED: 0 / 3 tests passed. # # Totals: pass:0 fail:3 xfail:0 xpass:0 skip:0 error:0 not ok 1 selftests: sgx: test_sgx # exit=1 thanks, -- Shuah