public inbox for linux-sgx@vger.kernel.org
 help / color / mirror / Atom feed
From: Dave Hansen <dave.hansen@intel.com>
To: Zhiquan Li <zhiquan1.li@intel.com>,
	linux-sgx@vger.kernel.org, tony.luck@intel.com,
	jarkko@kernel.org, dave.hansen@linux.intel.com
Cc: seanjc@google.com, kai.huang@intel.com, fan.du@intel.com,
	cathy.zhang@intel.com
Subject: Re: [PATCH v5 3/3] x86/sgx: Fine grained SGX MCA behavior for normal case
Date: Thu, 21 Jul 2022 09:57:15 -0700	[thread overview]
Message-ID: <b70b4902-24f5-8a76-5e72-e51de20d1d59@intel.com> (raw)
In-Reply-To: <20220622093705.2891642-4-zhiquan1.li@intel.com>

On 6/22/22 02:37, Zhiquan Li wrote:
> When the application accesses a SGX EPC page with memory failure, the
> task will receive a SIGBUS signal without any extra info, unless the
> EPC page has SGX_EPC_PAGE_KVM_GUEST flag. However, in some cases,
> we only use SGX in sub-task and we don't expect the entire task group
> be killed due to a SGX EPC page for a sub-task has memory failure.
> 
> To fix it, we extend the solution for normal case. That is, the SGX
> regular EPC page with memory failure will trigger a SIGBUS signal with
> code BUS_MCEERR_AR and additional info, so that the user has opportunity
> to make further decision.
> 
> Suppose an enclave is shared by multiple processes, when an enclave page
> triggers a machine check, the enclave will be disabled so that it
> couldn't be entered again. Killing other processes with the same enclave
> mapped would perhaps be overkill, but they are going to find that the
> enclave is "dead" next time they try to use it. Thanks for Jarkko's head
> up and Tony's clarification on this point.
> 
> Our intension is to provide additional info so that the application has
> more choices. Current behavior looks gently, and we don't want to change
> it.
> 
> Signed-off-by: Zhiquan Li <zhiquan1.li@intel.com>

I honestly have zero idea what this patch is doing.

  reply	other threads:[~2022-07-21 16:57 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-22  9:37 [PATCH v5 0/3] x86/sgx: fine grained SGX MCA behavior Zhiquan Li
2022-06-22  9:37 ` [PATCH v5 1/3] x86/sgx: Repurpose the owner field as the virtual address of virtual EPC page Zhiquan Li
2022-07-21 16:42   ` Dave Hansen
2022-07-21 23:27     ` Kai Huang
2022-06-22  9:37 ` [PATCH v5 2/3] x86/sgx: Fine grained SGX MCA behavior for virtualization Zhiquan Li
2022-07-21 16:54   ` Dave Hansen
2022-07-22 16:21     ` Zhiquan Li
2022-06-22  9:37 ` [PATCH v5 3/3] x86/sgx: Fine grained SGX MCA behavior for normal case Zhiquan Li
2022-07-21 16:57   ` Dave Hansen [this message]
2022-07-22 17:28     ` Zhiquan Li
2022-06-26  6:04 ` [PATCH v5 0/3] x86/sgx: fine grained SGX MCA behavior Jarkko Sakkinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b70b4902-24f5-8a76-5e72-e51de20d1d59@intel.com \
    --to=dave.hansen@intel.com \
    --cc=cathy.zhang@intel.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=fan.du@intel.com \
    --cc=jarkko@kernel.org \
    --cc=kai.huang@intel.com \
    --cc=linux-sgx@vger.kernel.org \
    --cc=seanjc@google.com \
    --cc=tony.luck@intel.com \
    --cc=zhiquan1.li@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox