From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9DCCECAAD1 for ; Wed, 31 Aug 2022 18:38:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232177AbiHaSiw (ORCPT ); Wed, 31 Aug 2022 14:38:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60326 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233076AbiHaSiG (ORCPT ); Wed, 31 Aug 2022 14:38:06 -0400 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3DB322A404; Wed, 31 Aug 2022 11:35:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1661970914; x=1693506914; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=oZ81GBOoxsRgNamHItqt8q6nDc0jiyU7IDPS+Ea0r+4=; b=LWusMo6P62gbPWSXVorSKmkVHwjSUUNBLDvsPBLmfjp5LXO/JKezxHju lIBcN0KN8zMYsVBfR902fplhM/W+9qwRS+xt5AH26jksyc1hsfIBVAtVc YxfeJHvFnlSHoJ9Mw0R/niMv1gWtvxrYmNnmxG/UC8l6xIOkBUeB9928/ 6lowxvXYPuGtt1DbxXvkYMGtQ2Ud3KhOGplo3Hki6mX4pWxPUOWdiLDno WomEeT9SFyWJohnhVlQxAirP8cl/l6zb6n1PC6W8rd/hZTzxA8cju/XAY SG+pVvq1xtyEnqCgK9NU8kCgf1A0Xqt2pHjNAuBk3DQfbls+iH+0fnSN3 Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10456"; a="296798210" X-IronPort-AV: E=Sophos;i="5.93,278,1654585200"; d="scan'208";a="296798210" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Aug 2022 11:35:11 -0700 X-IronPort-AV: E=Sophos;i="5.93,278,1654585200"; d="scan'208";a="612191393" Received: from nkrobins-mobl2.amr.corp.intel.com (HELO [10.212.220.19]) ([10.212.220.19]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Aug 2022 11:35:11 -0700 Message-ID: Date: Wed, 31 Aug 2022 11:35:10 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 1/6] x86/sgx: Do not consider unsanitized pages an error Content-Language: en-US To: "jarkko@kernel.org" , Haitao Huang Cc: "Huang, Kai" , "pmenzel@molgen.mpg.de" , "linux-sgx@vger.kernel.org" , "x86@kernel.org" , "dave.hansen@linux.intel.com" , "Dhanraj, Vijay" , "Chatre, Reinette" , "mingo@redhat.com" , "tglx@linutronix.de" , "bp@alien8.de" , "hpa@zytor.com" , "linux-kernel@vger.kernel.org" References: <20220830031206.13449-2-jarkko@kernel.org> <1f43e7b9-c101-3872-bd1b-add66933b285@intel.com> <1b3308a364317d36ad41961ea9cfee24aa122f02.camel@intel.com> From: Dave Hansen In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-sgx@vger.kernel.org Jarkko, Kai and Haitao, Can you three please start trimming your replies? You don't need to and should not quote the entirety of your messages every time you reply. On 8/31/22 11:28, jarkko@kernel.org wrote: >> Will it cause racing if we expose dev nodes to user space before >> ksgxd is started and sensitization done? > I'll to explain this. > > So the point is to fix the issue at hand, and fix it locally. > > Changing initialization order is simply out of context. It's > not really an argument for or against changing it > > We are fixing sanitization here, and only that with zero > side-effects to any other semantics. > > It's dictated by the development process [*] but more > importantly it's also just plain common sense. Kai, I think your suggestion is reasonable. You make a good point about not needing ksgxd for vepc. *But*, I think it's a bit too much for a bugfix that's headed to -stable. I'm concerned that it will have unintended side effects, *especially* when there's a working, tested alternative.