Re: [RFC PATCH v3 02/27] x86/cpufeatures: Make SGX_LC feature bit depend on SGX bit

Kai Huang
2021-02-01T00:08:57Z

On Sat, 30 Jan 2021 15:22:49 +0200 Jarkko Sakkinen wrote:
> On Tue, Jan 26, 2021 at 10:30:17PM +1300, Kai Huang wrote:
> > Move SGX_LC feature bit to CPUID dependency table as well, along with
> > new added SGX1 and SGX2 bit, to make clearing all SGX feature bits
> > easier. Also remove clear_sgx_caps() since it is just a wrapper of
> > setup_clear_cpu_cap(X86_FEATURE_SGX) now.
> >
> > Suggested-by: Sean Christopherson <seanjc@google.com>
> > Signed-off-by: Kai Huang <kai.huang@intel.com>
>
> Acked-by: Jarkko Sakkinen <jarkko@kernel.org>
>
> So could this be an improvement to the existing code? If so, then
> this should be the first patch. Also, I think that then this can
> be merged independently from rest of the patch set.

W/o SGX1/SGX2, I don't know whether it is worth to put SGX_LC into cpuid
dependency table, and kill clear_sgx_caps(). And since both you and Dave
already provided Acked-by, I am a little bit reluctant to switch the order
(because obviously both patches will be different).

Let me know if you still want me to switch patch order.