Re: [PATCH v4 1/3] x86/sgx: Repurpose the owner field as the virtual address of virtual EPC page

[Zhiquan Li <zhiquan1.li@intel.com>]

On 2022/6/8 11:26, Zhiquan Li wrote:
> When a page triggers a machine check, it only reports the
> physical address of EPC page. But in order to inject #MC into
> hypervisor, the virtual address is required. Then repurpose the
> "owner" field as the virtual address of the virtual EPC page so that
> arch_memory_failure() can easily retrieve it.
> 
> Add a new EPC page flag - SGX_EPC_PAGE_KVM_GUEST to interpret the
> meaning of the field.
> 
> Signed-off-by: Zhiquan Li <zhiquan1.li@intel.com>

Hi Cathy,

I forgot to add your signature here.

The flag SGX_EPC_PAGE_KVM_GUEST is taken from your patch:
https://lore.kernel.org/linux-sgx/YoveWpEsH6Hghc5Y@kernel.org/T/#u

Can I add "Co-developed-by" as well as "Signed-off-by" for you?

Best Regards,
Zhiquan

> ---
> Changes since V3:
> - Move the definition of EPC page flag SGX_EPC_PAGE_KVM_GUEST from
>   Cathy's third patch of SGX rebootless recovery patch set but discard
>   irrelevant portion, since it might need more time to re-forge and
>   these are two different features.
>   Link: https://lore.kernel.org/linux-sgx/41704e5d4c03b49fcda12e695595211d950cfb08.camel@kernel.org/T/#m9782d23496cacecb7da07a67daa79f4b322ae170
> 
> Changes since V2:
> - Rework the patch suggested by Jarkko.
> - Remove struct sgx_vepc_page and relevant code.
> - Remove new EPC page flag SGX_EPC_PAGE_IS_VEPC definition as it is
>   duplicated to SGX_EPC_PAGE_KVM_GUEST.
>   Link: https://lore.kernel.org/linux-sgx/eb95b32ecf3d44a695610cf7f2816785@intel.com/T/#u
> 
> Changes since V1:
> - Add documentation suggested by Jarkko.