From: "Haitao Huang" <haitao.huang@linux.intel.com>
To: "hpa@zytor.com" <hpa@zytor.com>,
"linux-sgx@vger.kernel.org" <linux-sgx@vger.kernel.org>,
"x86@kernel.org" <x86@kernel.org>,
"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
"cgroups@vger.kernel.org" <cgroups@vger.kernel.org>,
"bp@alien8.de" <bp@alien8.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"jarkko@kernel.org" <jarkko@kernel.org>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"Mehta, Sohil" <sohil.mehta@intel.com>,
"tj@kernel.org" <tj@kernel.org>,
"mingo@redhat.com" <mingo@redhat.com>,
"Huang, Kai" <kai.huang@intel.com>
Cc: "kristen@linux.intel.com" <kristen@linux.intel.com>,
"yangjie@microsoft.com" <yangjie@microsoft.com>,
"Li, Zhiquan1" <zhiquan1.li@intel.com>, "Christopherson,,
Sean" <seanjc@google.com>,
"mikko.ylinen@linux.intel.com" <mikko.ylinen@linux.intel.com>,
"Zhang, Bo" <zhanb@microsoft.com>,
"anakrish@microsoft.com" <anakrish@microsoft.com>
Subject: Re: [PATCH v4 03/18] x86/sgx: Add sgx_epc_lru_lists to encapsulate LRU lists
Date: Fri, 15 Sep 2023 11:28:28 -0500 [thread overview]
Message-ID: <op.2bbmpqncwjvjmi@hhuan26-mobl.amr.corp.intel.com> (raw)
In-Reply-To: <851f9b3043732c17cd8f86a77ccee0b7c6caa22f.camel@intel.com>
On Thu, 14 Sep 2023 05:31:30 -0500, Huang, Kai <kai.huang@intel.com> wrote:
> Some non-technical staff:
>
> On Tue, 2023-09-12 at 21:06 -0700, Haitao Huang wrote:
>> From: Kristen Carlson Accardi <kristen@linux.intel.com>
>
> The patch was from Kristen, but ...
>
>>
>> Introduce a data structure to wrap the existing reclaimable list and its
>> spinlock. Each cgroup later will have one instance of this structure to
>> track EPC pages allocated for processes associated with the same cgroup.
>> Just like the global SGX reclaimer (ksgxd), an EPC cgroup reclaims pages
>> from the reclaimable list in this structure when its usage reaches near
>> its limit.
>>
>> Currently, ksgxd does not track the VA, SECS pages. They are considered
>> as 'unreclaimable' pages that are only deallocated when their respective
>> owning enclaves are destroyed and all associated resources released.
>>
>> When an EPC cgroup can not reclaim any more reclaimable EPC pages to
>> reduce its usage below its limit, the cgroup must also reclaim those
>> unreclaimables by killing their owning enclaves. The VA and SECS pages
>> later are also tracked in an 'unreclaimable' list added to this
>> structure
>> to support this OOM killing of enclaves.
>>
>> Signed-off-by: Sean Christopherson <sean.j.christopherson@intel.com>
>> Signed-off-by: Kristen Carlson Accardi <kristen@linux.intel.com>
>
> ... it was firstly signed by Sean and then Kristen, which doesn't sound
> right.
>
> If the patch was from Kristen, then either Sean's SoB should come after
> Kristen's (which means Sean took Kristen's patch and signed it), or you
> need to
> have a Co-developed-by tag for Sean right before his SoB (which
> indicates Sean
> participated in the development of the patch but likely he wasn't the
> main
> developer).
>
> But I _guess_ the patch was just from Sean.
>
From what I see:
In v1 kristen included a "From" tsg for Sean. In v2 she split the original
patch into two and added some wrappers/ At that time, she removed the
"From" tag for both patches but kept the SOB and CC.
@Kristen, could you confirm?
I only removed the wrappers from v2 based on Dave's comments.
So if confirmed by Kristen, should we add "From" tag for Sean?
I'll double check the other patches.
Thanks
Haitao
next prev parent reply other threads:[~2023-09-15 16:29 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-13 4:06 [PATCH v4 00/18] Add Cgroup support for SGX EPC memory Haitao Huang
2023-09-13 4:06 ` [PATCH v4 01/18] cgroup/misc: Add per resource callbacks for CSS events Haitao Huang
2023-09-13 9:39 ` Jarkko Sakkinen
2023-09-16 4:11 ` Haitao Huang
2023-09-25 16:57 ` Jarkko Sakkinen
2023-09-15 17:55 ` Tejun Heo
2023-09-15 17:58 ` Tejun Heo
2023-09-16 1:27 ` Haitao Huang
2023-09-13 4:06 ` [PATCH v4 02/18] cgroup/misc: Add SGX EPC resource type and export APIs for SGX driver Haitao Huang
2023-09-13 9:43 ` Jarkko Sakkinen
2023-09-13 4:06 ` [PATCH v4 03/18] x86/sgx: Add sgx_epc_lru_lists to encapsulate LRU lists Haitao Huang
2023-09-13 9:46 ` Jarkko Sakkinen
2023-09-14 10:31 ` Huang, Kai
2023-09-14 16:13 ` Dave Hansen
2023-09-14 21:58 ` Huang, Kai
2023-09-15 16:28 ` Haitao Huang [this message]
2023-09-13 4:06 ` [PATCH v4 04/18] x86/sgx: Use sgx_epc_lru_lists for existing active page list Haitao Huang
2023-09-13 15:00 ` Jarkko Sakkinen
2023-09-13 4:06 ` [PATCH v4 05/18] x86/sgx: Store reclaimable EPC pages in sgx_epc_lru_lists Haitao Huang
2023-09-13 15:14 ` Jarkko Sakkinen
2023-09-13 4:06 ` [PATCH v4 06/18] x86/sgx: Introduce EPC page states Haitao Huang
2023-09-13 15:15 ` Jarkko Sakkinen
2023-09-13 4:06 ` [PATCH v4 07/18] x86/sgx: Introduce RECLAIM_IN_PROGRESS state Haitao Huang
2023-09-13 4:06 ` [PATCH v4 08/18] x86/sgx: Use a list to track to-be-reclaimed pages Haitao Huang
2023-09-13 15:30 ` Jarkko Sakkinen
2023-09-13 4:06 ` [PATCH v4 09/18] x86/sgx: Store struct sgx_encl when allocating new VA pages Haitao Huang
2023-09-13 15:31 ` Jarkko Sakkinen
2023-09-13 4:06 ` [PATCH v4 10/18] x86/sgx: Add EPC page flags to identify owner types Haitao Huang
2023-09-13 4:06 ` [PATCH v4 11/18] x86/sgx: store unreclaimable pages in LRU lists Haitao Huang
2023-09-13 15:33 ` Jarkko Sakkinen
2023-09-13 4:06 ` [PATCH v4 12/18] x86/sgx: Add EPC OOM path to forcefully reclaim EPC Haitao Huang
2023-09-13 15:34 ` Jarkko Sakkinen
2023-09-16 4:19 ` Haitao Huang
2023-09-13 4:06 ` [PATCH v4 13/18] x86/sgx: Expose sgx_reclaim_pages() for use by EPC cgroup Haitao Huang
2023-09-13 15:36 ` Jarkko Sakkinen
2023-09-13 4:06 ` [PATCH v4 14/18] x86/sgx: Add helper to grab pages from an arbitrary EPC LRU Haitao Huang
2023-09-13 4:06 ` [PATCH v4 15/18] x86/sgx: Prepare for multiple LRUs Haitao Huang
2023-09-13 15:42 ` Jarkko Sakkinen
2023-09-16 4:18 ` Haitao Huang
2023-09-13 4:06 ` [PATCH v4 16/18] x86/sgx: Limit process EPC usage with misc cgroup controller Haitao Huang
2023-09-13 15:48 ` Jarkko Sakkinen
2023-09-13 4:06 ` [PATCH v4 17/18] Docs/x86/sgx: Add description for cgroup support Haitao Huang
2023-09-13 4:06 ` [PATCH v4 18/18] selftests/sgx: Add scripts for epc cgroup testing Haitao Huang
2023-09-15 18:26 ` [PATCH v4 00/18] Add Cgroup support for SGX EPC memory Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=op.2bbmpqncwjvjmi@hhuan26-mobl.amr.corp.intel.com \
--to=haitao.huang@linux.intel.com \
--cc=anakrish@microsoft.com \
--cc=bp@alien8.de \
--cc=cgroups@vger.kernel.org \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jarkko@kernel.org \
--cc=kai.huang@intel.com \
--cc=kristen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sgx@vger.kernel.org \
--cc=mikko.ylinen@linux.intel.com \
--cc=mingo@redhat.com \
--cc=seanjc@google.com \
--cc=sohil.mehta@intel.com \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=x86@kernel.org \
--cc=yangjie@microsoft.com \
--cc=zhanb@microsoft.com \
--cc=zhiquan1.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox