linux-sh.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 041/228] cpufreq: sh: use cpufreq_table_validate_and_show()
       [not found] <cover.1379063063.git.viresh.kumar@linaro.org>
@ 2013-09-13 13:11 ` Viresh Kumar
  2013-09-13 13:12 ` [PATCH 085/228] cpufreq: sh: Use generic cpufreq routines Viresh Kumar
  2013-09-13 13:13 ` [PATCH 122/228] cpufreq: sh: don't initialize part of policy that is set by core too Viresh Kumar
  2 siblings, 0 replies; 3+ messages in thread
From: Viresh Kumar @ 2013-09-13 13:11 UTC (permalink / raw)
  To: linux-arm-kernel

Lets use cpufreq_table_validate_and_show() instead of calling
cpufreq_frequency_table_cpuinfo() and cpufreq_frequency_table_get_attr().

Cc: Paul Mundt <lethal@linux-sh.org>
Cc: linux-sh@vger.kernel.org
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
 drivers/cpufreq/sh-cpufreq.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/cpufreq/sh-cpufreq.c b/drivers/cpufreq/sh-cpufreq.c
index f671aa1..f1fb944 100644
--- a/drivers/cpufreq/sh-cpufreq.c
+++ b/drivers/cpufreq/sh-cpufreq.c
@@ -117,9 +117,9 @@ static int sh_cpufreq_cpu_init(struct cpufreq_policy *policy)
 	if (freq_table) {
 		int result;
 
-		result = cpufreq_frequency_table_cpuinfo(policy, freq_table);
-		if (!result)
-			cpufreq_frequency_table_get_attr(freq_table, cpu);
+		result = cpufreq_table_validate_and_show(policy, freq_table);
+		if (result)
+			return result;
 	} else {
 		dev_notice(dev, "no frequency table found, falling back "
 			   "to rate rounding.\n");
-- 
1.7.12.rc2.18.g61b472e


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH 085/228] cpufreq: sh: Use generic cpufreq routines
       [not found] <cover.1379063063.git.viresh.kumar@linaro.org>
  2013-09-13 13:11 ` [PATCH 041/228] cpufreq: sh: use cpufreq_table_validate_and_show() Viresh Kumar
@ 2013-09-13 13:12 ` Viresh Kumar
  2013-09-13 13:13 ` [PATCH 122/228] cpufreq: sh: don't initialize part of policy that is set by core too Viresh Kumar
  2 siblings, 0 replies; 3+ messages in thread
From: Viresh Kumar @ 2013-09-13 13:12 UTC (permalink / raw)
  To: linux-arm-kernel

Most of the CPUFreq drivers do similar things in .exit() and .verify() routines
and .attr. So its better if we have generic routines for them which can be used
by cpufreq drivers then.

This patch uses these generic routines for this driver.

Cc: Paul Mundt <lethal@linux-sh.org>
Cc: linux-sh@vger.kernel.org
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
 drivers/cpufreq/sh-cpufreq.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/drivers/cpufreq/sh-cpufreq.c b/drivers/cpufreq/sh-cpufreq.c
index f1fb944..c681b86 100644
--- a/drivers/cpufreq/sh-cpufreq.c
+++ b/drivers/cpufreq/sh-cpufreq.c
@@ -151,11 +151,6 @@ static int sh_cpufreq_cpu_exit(struct cpufreq_policy *policy)
 	return 0;
 }
 
-static struct freq_attr *sh_freq_attr[] = {
-	&cpufreq_freq_attr_scaling_available_freqs,
-	NULL,
-};
-
 static struct cpufreq_driver sh_cpufreq_driver = {
 	.name		= "sh",
 	.get		= sh_cpufreq_get,
@@ -163,7 +158,7 @@ static struct cpufreq_driver sh_cpufreq_driver = {
 	.verify		= sh_cpufreq_verify,
 	.init		= sh_cpufreq_cpu_init,
 	.exit		= sh_cpufreq_cpu_exit,
-	.attr		= sh_freq_attr,
+	.attr		= cpufreq_generic_attr,
 };
 
 static int __init sh_cpufreq_module_init(void)
-- 
1.7.12.rc2.18.g61b472e


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH 122/228] cpufreq: sh: don't initialize part of policy that is set by core too
       [not found] <cover.1379063063.git.viresh.kumar@linaro.org>
  2013-09-13 13:11 ` [PATCH 041/228] cpufreq: sh: use cpufreq_table_validate_and_show() Viresh Kumar
  2013-09-13 13:12 ` [PATCH 085/228] cpufreq: sh: Use generic cpufreq routines Viresh Kumar
@ 2013-09-13 13:13 ` Viresh Kumar
  2 siblings, 0 replies; 3+ messages in thread
From: Viresh Kumar @ 2013-09-13 13:13 UTC (permalink / raw)
  To: linux-arm-kernel

Many common initializations of struct policy are moved to core now and hence
this driver doesn't need to do it. This patch removes such code.

Most recent of those changes is to call ->get() in the core after calling
->init().

Cc: Paul Mundt <lethal@linux-sh.org>
Cc: linux-sh@vger.kernel.org
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
 drivers/cpufreq/sh-cpufreq.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/cpufreq/sh-cpufreq.c b/drivers/cpufreq/sh-cpufreq.c
index c681b86..387af12 100644
--- a/drivers/cpufreq/sh-cpufreq.c
+++ b/drivers/cpufreq/sh-cpufreq.c
@@ -111,8 +111,6 @@ static int sh_cpufreq_cpu_init(struct cpufreq_policy *policy)
 		return PTR_ERR(cpuclk);
 	}
 
-	policy->cur = sh_cpufreq_get(cpu);
-
 	freq_table = cpuclk->nr_freqs ? cpuclk->freq_table : NULL;
 	if (freq_table) {
 		int result;
-- 
1.7.12.rc2.18.g61b472e


^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2013-09-13 13:13 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <cover.1379063063.git.viresh.kumar@linaro.org>
2013-09-13 13:11 ` [PATCH 041/228] cpufreq: sh: use cpufreq_table_validate_and_show() Viresh Kumar
2013-09-13 13:12 ` [PATCH 085/228] cpufreq: sh: Use generic cpufreq routines Viresh Kumar
2013-09-13 13:13 ` [PATCH 122/228] cpufreq: sh: don't initialize part of policy that is set by core too Viresh Kumar

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).