* Re: [PATCH 0/4 v2] ARM: shmobile: r8a7778: pinctrl support
2013-04-10 9:29 [PATCH 0/4 v2] ARM: shmobile: r8a7778: pinctrl support Kuninori Morimoto
@ 2013-04-10 10:58 ` Laurent Pinchart
2013-04-11 0:45 ` Simon Horman
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Laurent Pinchart @ 2013-04-10 10:58 UTC (permalink / raw)
To: linux-sh
Hi Morimoto-san,
On Wednesday 10 April 2013 02:29:37 Kuninori Morimoto wrote:
> Hi Laurent, Simon, Magnus
>
> These patches are v2 of r8a7778 pinctrl support
> I removed [RFC] from Subject
>
> These are based on
>
> renesas-next-20130405v2
> + simon/defconfig-bockw
> + simon/soc-r8a7778
> + simon/boards-bockw
>
> and Laurent's this patch
>
> Subject: [PATCH v2 1/3] gpio-rcar: Add RCAR_GP_PIN macro
> Date: Mon, 8 Apr 2013 12:05:30 +0200
>
> Kuninori Morimoto (3):
> sh-pfc: Add r8a7778 pinmux support
> ARM: shmobile: r8a7778: Register PFC device
> ARM: shmobile: bockw: add pinctrl support
The patches look good, I just had a couple of comments on 1/3. I've acked 2/3
and 3/3 already from v1, could you pick up the acks and add them to v3 ? In
general picking Acked-by, Reviewed-by and Tested-by lines from the list when
submitting a new version is a good idea, as it helps reviewer skip patches
they have already reviewed.
> arch/arm/mach-shmobile/Kconfig | 1 +
> arch/arm/mach-shmobile/board-bockw.c | 13 +
> arch/arm/mach-shmobile/include/mach/r8a7778.h | 1 +
> arch/arm/mach-shmobile/setup-r8a7778.c | 13 +
> drivers/pinctrl/sh-pfc/Kconfig | 5 +
> drivers/pinctrl/sh-pfc/Makefile | 1 +
> drivers/pinctrl/sh-pfc/core.c | 3 +
> drivers/pinctrl/sh-pfc/core.h | 1 +
> drivers/pinctrl/sh-pfc/pfc-r8a7778.c | 2369 ++++++++++++++++++++++
> 9 files changed, 2407 insertions(+)
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH 0/4 v2] ARM: shmobile: r8a7778: pinctrl support
2013-04-10 9:29 [PATCH 0/4 v2] ARM: shmobile: r8a7778: pinctrl support Kuninori Morimoto
2013-04-10 10:58 ` Laurent Pinchart
@ 2013-04-11 0:45 ` Simon Horman
2013-04-11 2:49 ` Kuninori Morimoto
2013-04-15 10:35 ` Laurent Pinchart
3 siblings, 0 replies; 5+ messages in thread
From: Simon Horman @ 2013-04-11 0:45 UTC (permalink / raw)
To: linux-sh
On Wed, Apr 10, 2013 at 12:58:47PM +0200, Laurent Pinchart wrote:
> Hi Morimoto-san,
>
> On Wednesday 10 April 2013 02:29:37 Kuninori Morimoto wrote:
> > Hi Laurent, Simon, Magnus
> >
> > These patches are v2 of r8a7778 pinctrl support
> > I removed [RFC] from Subject
> >
> > These are based on
> >
> > renesas-next-20130405v2
> > + simon/defconfig-bockw
> > + simon/soc-r8a7778
> > + simon/boards-bockw
> >
> > and Laurent's this patch
> >
> > Subject: [PATCH v2 1/3] gpio-rcar: Add RCAR_GP_PIN macro
> > Date: Mon, 8 Apr 2013 12:05:30 +0200
> >
> > Kuninori Morimoto (3):
> > sh-pfc: Add r8a7778 pinmux support
> > ARM: shmobile: r8a7778: Register PFC device
> > ARM: shmobile: bockw: add pinctrl support
>
> The patches look good, I just had a couple of comments on 1/3. I've acked 2/3
> and 3/3 already from v1, could you pick up the acks and add them to v3 ? In
> general picking Acked-by, Reviewed-by and Tested-by lines from the list when
> submitting a new version is a good idea, as it helps reviewer skip patches
> they have already reviewed.
It also helps the maintainer not to forget to add them :^)
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 0/4 v2] ARM: shmobile: r8a7778: pinctrl support
2013-04-10 9:29 [PATCH 0/4 v2] ARM: shmobile: r8a7778: pinctrl support Kuninori Morimoto
2013-04-10 10:58 ` Laurent Pinchart
2013-04-11 0:45 ` Simon Horman
@ 2013-04-11 2:49 ` Kuninori Morimoto
2013-04-15 10:35 ` Laurent Pinchart
3 siblings, 0 replies; 5+ messages in thread
From: Kuninori Morimoto @ 2013-04-11 2:49 UTC (permalink / raw)
To: linux-sh
Hi Simon, Laurent
> > The patches look good, I just had a couple of comments on 1/3. I've acked 2/3
> > and 3/3 already from v1, could you pick up the acks and add them to v3 ? In
> > general picking Acked-by, Reviewed-by and Tested-by lines from the list when
> > submitting a new version is a good idea, as it helps reviewer skip patches
> > they have already reviewed.
>
> It also helps the maintainer not to forget to add them :^)
Thank you for pointing it.
And sorry for my immature behavior :(
Best regards
---
Kuninori Morimoto
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 0/4 v2] ARM: shmobile: r8a7778: pinctrl support
2013-04-10 9:29 [PATCH 0/4 v2] ARM: shmobile: r8a7778: pinctrl support Kuninori Morimoto
` (2 preceding siblings ...)
2013-04-11 2:49 ` Kuninori Morimoto
@ 2013-04-15 10:35 ` Laurent Pinchart
3 siblings, 0 replies; 5+ messages in thread
From: Laurent Pinchart @ 2013-04-15 10:35 UTC (permalink / raw)
To: linux-sh
On Wednesday 10 April 2013 19:49:25 Kuninori Morimoto wrote:
> Hi Simon, Laurent
>
> > > The patches look good, I just had a couple of comments on 1/3. I've
> > > acked 2/3 and 3/3 already from v1, could you pick up the acks and add
> > > them to v3 ? In general picking Acked-by, Reviewed-by and Tested-by
> > > lines from the list when submitting a new version is a good idea, as it
> > > helps reviewer skip patches they have already reviewed.
> >
> > It also helps the maintainer not to forget to add them :^)
>
> Thank you for pointing it.
> And sorry for my immature behavior :(
No worries. I've also forgotten to pick up acks several times in the past :-)
--
Laurent Pinchart
^ permalink raw reply [flat|nested] 5+ messages in thread