From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH 1/2] v4l: vsp1: Add missing #include <linux/sched.h>
Date: Mon, 25 Jan 2016 19:03:51 +0000 [thread overview]
Message-ID: <11540092.dX60pYHxh5@avalon> (raw)
In-Reply-To: <1452536727-19538-1-git-send-email-geert+renesas@glider.be>
Hi Geert,
On Monday 25 January 2016 08:50:04 Geert Uytterhoeven wrote:
> On Mon, Jan 25, 2016 at 1:37 AM, Laurent Pinchart wrote:
> > I wonder, though, whether the right solution wouldn't be to fix wait.h and
> > sched.h. They seem to depend on each other.
>
> Include shuffling involving sched.h usually breaks something else, due to
> include hell.
Hence why I think that's where the real fix should go :-)
> >> ---
> >> Against renesas-drivers-2016-01-05-v4.4-rc8
> >>
> >> drivers/media/platform/vsp1/vsp1_pipe.c | 1 +
> >> 1 file changed, 1 insertion(+)
> >>
> >> diff --git a/drivers/media/platform/vsp1/vsp1_pipe.c
> >> b/drivers/media/platform/vsp1/vsp1_pipe.c index
> >> 96f0e7d4c400172e..2283e64f12faadd1 100644
> >> --- a/drivers/media/platform/vsp1/vsp1_pipe.c
> >> +++ b/drivers/media/platform/vsp1/vsp1_pipe.c
> >> @@ -13,6 +13,7 @@
> >>
> >> #include <linux/delay.h>
> >> #include <linux/list.h>
> >>
> >> +#include <linux/sched.h>
--
Regards,
Laurent Pinchart
prev parent reply other threads:[~2016-01-25 19:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-11 18:25 [PATCH 1/2] v4l: vsp1: Add missing #include <linux/sched.h> Geert Uytterhoeven
2016-01-25 0:37 ` Laurent Pinchart
2016-01-25 7:50 ` Geert Uytterhoeven
2016-01-25 19:03 ` Laurent Pinchart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11540092.dX60pYHxh5@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox