From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adrian McMenamin Date: Mon, 24 Mar 2008 17:18:13 +0000 Subject: Re: [PATCH] 3/3 maple: update bus driver to support Dreamcast VMU Message-Id: <1206379093.7543.8.camel@localhost.localdomain> List-Id: References: <1206207805.6324.13.camel@localhost.localdomain> <1206209786.6324.41.camel@localhost.localdomain> <20080324033344.GB15872@linux-sh.org> <20080324144647.GC2899@logfs.org> <1206371178.6283.37.camel@localhost.localdomain> <20080324152952.GF2899@logfs.org> <1206373900.6283.39.camel@localhost.localdomain> <20080324160429.GG2899@logfs.org> <20080324170707.GH2899@logfs.org> In-Reply-To: <20080324170707.GH2899@logfs.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: =?ISO-8859-1?Q?J=F6rn?= Engel Cc: Andrew Morton , linux-sh , Greg KH , LKML , Paul Mundt , MTD , dwmw2 On Mon, 2008-03-24 at 18:07 +0100, Jörn Engel wrote: > On Mon, 24 March 2008 17:04:29 +0100, Jörn Engel wrote: > > > > Then we should be fine. I'll try to beat the code into submission. > > And here go two more interesting patches. The first is removing all > locking from the mtd driver. Since the existing locking code is nearly > impossibly to verify, I'd rather have something simple and wrong than > something complicated and wrong. > > The second rearranges the list locking a bit. Previously it was > possible to touch maple_waitq or maple_sentq without holding the lock. > With my limited understanding of the driver, the second patch may > already be enough to prevent the type of corruption you've been seeing. > > Jörn > These will fail. Removing the locks just about guarantees memory corruption and maple_waitq is not the issue - it is the objects held in maple_waitq that are the issue. I have an idea though, so let me hack at it