From: Adrian McMenamin <adrian@newgolddream.dyndns.info>
To: Paul Mundt <lethal@linux-sh.org>
Cc: Adrian Bunk <bunk@kernel.org>,
linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: drivers/sh/maple/maple.c compile error
Date: Mon, 28 Jul 2008 20:51:48 +0000 [thread overview]
Message-ID: <1217278308.6875.3.camel@localhost.localdomain> (raw)
In-Reply-To: <20080728204438.GC20019@linux-sh.org>
On Tue, 2008-07-29 at 05:44 +0900, Paul Mundt wrote:
> On Mon, Jul 28, 2008 at 11:20:12PM +0300, Adrian Bunk wrote:
> > Commit 306cfd630a4d121cf4e08b894d8b4c4cf106e57e
> > (maple: tidy maple_driver code by removing redundant connect/disconnect)
> > causes the following compile error:
> >
> > <-- snip -->
> >
> > ...
> > CC drivers/sh/maple/maple.o
> > /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/sh/maple/maple.c: In function 'attach_matching_maple_driver':
> > /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/sh/maple/maple.c:259: error: 'struct maple_driver' has no member named 'connect'
> > /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/sh/maple/maple.c: In function 'maple_detach_driver':
> > /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/sh/maple/maple.c:272: error: 'struct maple_driver' has no member named 'disconnect'
> > /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/sh/maple/maple.c:273: error: 'struct maple_driver' has no member named 'disconnect'
> > make[4]: *** [drivers/sh/maple/maple.o] Error 1
> >
> > <-- snip -->
> >
> Adrian was supposed to send follow-up patches for this, which never
> happened. I thought I had dropped this already, but in this case I'll
> just revert it.
Actually I wasn't asked about this, but to submit a fix/replacement for
a patch that didn't apply.
I will submit a patch for the whole thing then - as I cannot actually
match the commit Adrian has quoted to anything.
I think the problem is that I am trying to get a change in the bus and
in the drivers (which have different maintainers) to go in together and
that has never quite worked. The code runs fine on my box and has done
for months now.
Adrian
next prev parent reply other threads:[~2008-07-28 20:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-28 20:20 drivers/sh/maple/maple.c compile error Adrian Bunk
2008-07-28 20:44 ` Paul Mundt
2008-07-28 20:51 ` Adrian McMenamin [this message]
2008-07-28 21:01 ` Paul Mundt
2008-07-28 21:13 ` Adrian McMenamin
2008-07-28 21:24 ` Paul Mundt
2008-07-28 21:24 ` Adrian McMenamin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1217278308.6875.3.camel@localhost.localdomain \
--to=adrian@newgolddream.dyndns.info \
--cc=bunk@kernel.org \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox