From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Magnus Damm <magnus.damm@gmail.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
iommu@lists.linux-foundation.org,
Linux-sh list <linux-sh@vger.kernel.org>
Subject: Re: [PATCH 10/10] ARM: shmobile: r8a7791: Add IPMMU DT nodes
Date: Mon, 15 Dec 2014 23:16:14 +0000 [thread overview]
Message-ID: <13017667.c6lii1vn0L@avalon> (raw)
In-Reply-To: <CANqRtoSYX10aaWu0r9GOPe+EvO2NkS4UJdLbST-aoHrv4XjG4A@mail.gmail.com>
Hi Magnus,
On Tuesday 16 December 2014 07:44:32 Magnus Damm wrote:
> On Tue, Dec 16, 2014 at 3:44 AM, Laurent Pinchart wrote:
> > On Monday 15 December 2014 14:07:52 Geert Uytterhoeven wrote:
> >> On Mon, Dec 15, 2014 at 1:13 AM, Laurent Pinchart wrote:
> >> > Add the seven IPMMU instances found in the r8a7791 to DT with a
> >> > disabled status.
> >> >
> >> > Signed-off-by: Laurent Pinchart
> >> > <laurent.pinchart+renesas@ideasonboard.com>
> >>
> >> The addresses and interrupt numbers look OK to me.
> >> However, my comment about the "0x800" offset is still valid.
> >> Shouldn't we have two register blocks, and let the driver use only the
> >> second one?
> >>
> >> If you ignore, feel free to add my
> >> Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>
> >
> > I don't want to ignore your comment, but I don't know what to do here :-/
> > The datasheet lacks detailed information about secure vs. non-secure mode
> > and how the two register sets are supposed to interoperate and be handled
> > by the operating system.
>
> I don't know about that either.
>
> But how about differences within R-Car Gen2 series so far? If there
> are known differences then perhaps we should use part number in the
> compatible string?
I haven't noticed differences between H2 and M2. V2 and E2 are extended with
IOMMU performance monitoring registers, so a specific compatible string is
needed.
"renesas,ipmmu-vmsa" should be the default fallback compatible string. I was
thinking about playing with the newer SoCs first to see how the IOMMU react
and then most likely add SoC-specific compatible strings.
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2014-12-15 23:16 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-15 0:13 [PATCH 00/10] Renesas IPMMU-VMSA fixes and DT support Laurent Pinchart
2014-12-15 0:13 ` [PATCH 02/10] iommu/ipmmu-vmsa: Flush P[UM]D entry before freeing the child page table Laurent Pinchart
2014-12-15 0:13 ` [PATCH 03/10] iommu/ipmmu-vmsa: Invalidate TLB after unmapping Laurent Pinchart
[not found] ` <1418602429-11276-1-git-send-email-laurent.pinchart+renesas-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>
2014-12-15 0:13 ` [PATCH 01/10] iommu/ipmmu-vmsa: Cleanup failures of ARM mapping creation or attachment Laurent Pinchart
2014-12-15 0:13 ` [PATCH 04/10] iommu/ipmmu-vmsa: Return proper error if devm_request_irq fails Laurent Pinchart
2014-12-15 0:13 ` [PATCH 05/10] iommu/ipmmu-vmsa: Add device tree bindings documentation Laurent Pinchart
2014-12-15 0:13 ` [PATCH 06/10] iommu/ipmmu-vmsa: Add device tree support Laurent Pinchart
2014-12-15 0:13 ` [PATCH 07/10] iommu/ipmmu-vmsa: Support multiple micro TLBs per device Laurent Pinchart
2014-12-15 0:13 ` [PATCH 08/10] iommu/ipmmu-vmsa: Remove platform data support Laurent Pinchart
2014-12-15 0:13 ` [PATCH 09/10] ARM: shmobile: r8a7790: Add IPMMU DT nodes Laurent Pinchart
2014-12-15 0:13 ` [PATCH 10/10] ARM: shmobile: r8a7791: " Laurent Pinchart
2014-12-15 13:07 ` Geert Uytterhoeven
[not found] ` <CAMuHMdWtkk=Q=Mfcyz03LBzXMuBOr8BZGNyCsQb9bwDty-4OiQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-12-15 18:44 ` Laurent Pinchart
2014-12-15 22:44 ` Magnus Damm
2014-12-15 23:16 ` Laurent Pinchart [this message]
2014-12-16 11:54 ` Magnus Damm
2014-12-16 10:02 ` Geert Uytterhoeven
2014-12-16 11:47 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13017667.c6lii1vn0L@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=geert@linux-m68k.org \
--cc=iommu@lists.linux-foundation.org \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox