From: Simon Horman <horms@verge.net.au>
To: linux-mmc@vger.kernel.org, linux-sh@vger.kernel.org
Cc: Magnus Damm <magnus.damm@gmail.com>,
Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
Paul Mundt <lethal@linux-sh.org>, Chris Ball <cjb@laptop.org>,
Simon Horman <horms@verge.net.au>
Subject: [PATCH 1/5] mmc: tmio: name 0xd8 as CTL_DMA_ENABLE
Date: Mon, 20 Jun 2011 23:00:08 +0000 [thread overview]
Message-ID: <1308610812-3479-2-git-send-email-horms@verge.net.au> (raw)
In-Reply-To: <1308610812-3479-1-git-send-email-horms@verge.net.au>
This reflects at least the current usage of this register
and I think it improves the readability of the code ever so slightly.
Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: Magnus Damm <magnus.damm@gmail.com>
Signed-off-by: Simon Horman <horms@verge.net.au>
---
Dependencies: none known
---
drivers/mmc/host/tmio_mmc_dma.c | 2 +-
include/linux/mmc/tmio.h | 1 +
2 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/mmc/host/tmio_mmc_dma.c b/drivers/mmc/host/tmio_mmc_dma.c
index 25f1ad6..9c4da66 100644
--- a/drivers/mmc/host/tmio_mmc_dma.c
+++ b/drivers/mmc/host/tmio_mmc_dma.c
@@ -26,7 +26,7 @@ static void tmio_mmc_enable_dma(struct tmio_mmc_host *host, bool enable)
{
#if defined(CONFIG_SUPERH) || defined(CONFIG_ARCH_SHMOBILE)
/* Switch DMA mode on or off - SuperH specific? */
- writew(enable ? 2 : 0, host->ctl + (0xd8 << host->bus_shift));
+ writew(enable ? 2 : 0, host->ctl + (CTL_DMA_ENABLE << host->bus_shift));
#endif
}
diff --git a/include/linux/mmc/tmio.h b/include/linux/mmc/tmio.h
index 19490b9..0a6e40d 100644
--- a/include/linux/mmc/tmio.h
+++ b/include/linux/mmc/tmio.h
@@ -30,6 +30,7 @@
#define CTL_TRANSACTION_CTL 0x34
#define CTL_SDIO_STATUS 0x36
#define CTL_SDIO_IRQ_MASK 0x38
+#define CTL_DMA_ENABLE 0xd8
#define CTL_RESET_SD 0xe0
#define CTL_SDIO_REGS 0x100
#define CTL_CLK_AND_WAIT_CTL 0x138
--
1.7.4.4
next prev parent reply other threads:[~2011-06-20 23:00 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-20 23:00 [PATCH 0/5 v2] mmc: sdhi: Allow waiting for idle Simon Horman
2011-06-20 23:00 ` Simon Horman [this message]
2011-06-20 23:00 ` [PATCH 2/5] mmc: tmio: Share register access functions Simon Horman
2011-06-20 23:00 ` [PATCH 3/5] mmc: sdhi: Add write16_hook Simon Horman
2011-06-21 0:36 ` Magnus Damm
2011-06-21 0:50 ` Simon Horman
2011-06-21 0:59 ` Magnus Damm
2011-06-21 1:13 ` Simon Horman
2011-06-21 1:36 ` Magnus Damm
2011-06-21 2:09 ` Simon Horman
2011-06-21 2:34 ` Magnus Damm
2011-06-20 23:00 ` [PATCH 4/5] ARM: mach-shmobile: ag5evm: consistently name sdhi info structures Simon Horman
2011-06-21 8:50 ` Paul Mundt
2011-06-20 23:00 ` [PATCH 5/5] ARM: mach-shmobile: ag5evm: SDHI requires waiting for idle Simon Horman
2011-06-21 16:10 ` Chris Ball
2011-06-21 16:27 ` Paul Mundt
2011-06-21 16:37 ` Chris Ball
-- strict thread matches above, loose matches on Subject: below --
2011-06-20 6:06 [PATCH 0/5] mmc: sdhi: Allow " Simon Horman
2011-06-20 6:06 ` [PATCH 1/5] mmc: tmio: name 0xd8 as CTL_DMA_ENABLE Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1308610812-3479-2-git-send-email-horms@verge.net.au \
--to=horms@verge.net.au \
--cc=cjb@laptop.org \
--cc=g.liakhovetski@gmx.de \
--cc=lethal@linux-sh.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox