From: Bastian Hecht <hechtb@googlemail.com>
To: linux-sh@vger.kernel.org, linux-mtd@lists.infradead.org
Cc: Magnus Damm <magnus.damm@gmail.com>,
Laurent Pichart <laurent.pinchart@ideasonboard.com>
Subject: [PATCH v3 2/7] mtd: sh_flctl: Reorder empty_fifo() calls
Date: Thu, 01 Mar 2012 09:48:36 +0000 [thread overview]
Message-ID: <1330595321-2728-2-git-send-email-hechtb@gmail.com> (raw)
In-Reply-To: <1330595321-2728-1-git-send-email-hechtb@gmail.com>
Reorders the calls to make it a bit shorter and match the calling
procedure displayed in the datasheet.
Signed-off-by: Bastian Hecht <hechtb@gmail.com>
---
changelog: There was an inconsistency between patch 2/7 and 3/7. An empty_fifo() call has been moved around to correct it.
drivers/mtd/nand/sh_flctl.c | 5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/mtd/nand/sh_flctl.c b/drivers/mtd/nand/sh_flctl.c
index 93b1f74..9291066 100644
--- a/drivers/mtd/nand/sh_flctl.c
+++ b/drivers/mtd/nand/sh_flctl.c
@@ -525,7 +525,6 @@ static void flctl_cmdfunc(struct mtd_info *mtd, unsigned int command,
execmd_read_page_sector(mtd, page_addr);
break;
}
- empty_fifo(flctl);
if (flctl->page_size)
set_cmd_regs(mtd, command, (NAND_CMD_READSTART << 8)
| command);
@@ -547,7 +546,6 @@ static void flctl_cmdfunc(struct mtd_info *mtd, unsigned int command,
break;
}
- empty_fifo(flctl);
if (flctl->page_size) {
set_cmd_regs(mtd, command, (NAND_CMD_READSTART << 8)
| NAND_CMD_READ0);
@@ -560,12 +558,12 @@ static void flctl_cmdfunc(struct mtd_info *mtd, unsigned int command,
goto read_normal_exit;
case NAND_CMD_READID:
- empty_fifo(flctl);
set_cmd_regs(mtd, command, command);
set_addr(mtd, 0, 0);
flctl->read_bytes = 4;
writel(flctl->read_bytes, FLDTCNTR(flctl)); /* set read size */
+ empty_fifo(flctl);
start_translation(flctl);
read_datareg(flctl, 0); /* read and end */
break;
@@ -654,6 +652,7 @@ static void flctl_cmdfunc(struct mtd_info *mtd, unsigned int command,
read_normal_exit:
writel(flctl->read_bytes, FLDTCNTR(flctl)); /* set read size */
+ empty_fifo(flctl);
start_translation(flctl);
read_fiforeg(flctl, flctl->read_bytes, 0);
wait_completion(flctl);
--
1.7.5.4
next prev parent reply other threads:[~2012-03-01 9:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-01 9:48 [PATCH v3 1/7] mtd: sh_flctl: Expand FLCMNCR register bit field Bastian Hecht
2012-03-01 9:48 ` Bastian Hecht [this message]
2012-03-01 9:48 ` [PATCH v3 3/7] mtd: sh_flctl: Expand the READID command to 8 bytes Bastian Hecht
2012-03-01 9:48 ` [PATCH v3 4/7] mtd: sh_flctl: Implement NAND_CMD_RNDOUT command Bastian Hecht
2012-03-01 9:48 ` [PATCH v3 5/7] mtd: sh_flctl: Use cached register value for FLCMNCR Bastian Hecht
2012-03-01 9:48 ` [PATCH v3 6/7] mtd: sh_flctl: Add FLHOLDCR register Bastian Hecht
2012-03-01 9:48 ` [PATCH v3 7/7] ARM: mach-shmobile: mackerel: Add the flash controller flctl Bastian Hecht
2012-03-01 15:19 ` [PATCH v3 1/7] mtd: sh_flctl: Expand FLCMNCR register bit field Laurent Pinchart
2012-03-09 12:48 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1330595321-2728-2-git-send-email-hechtb@gmail.com \
--to=hechtb@googlemail.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).