From: Artem Bityutskiy <dedekind1@gmail.com>
To: Bastian Hecht <hechtb@googlemail.com>
Cc: Magnus Damm <magnus.damm@gmail.com>,
Brian Norris <computersforpeace@gmail.com>,
linux-mtd@lists.infradead.org,
Laurent Pichart <laurent.pinchart@ideasonboard.com>,
linux-sh@vger.kernel.org
Subject: Re: [PATCH v3 0/10] sh_flctl hardware ECC mode cleanup
Date: Wed, 02 May 2012 10:38:42 +0000 [thread overview]
Message-ID: <1335955122.10293.39.camel@sauron.fi.intel.com> (raw)
In-Reply-To: <1335951710-9390-1-git-send-email-hechtb@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1854 bytes --]
On Wed, 2012-05-02 at 11:41 +0200, Bastian Hecht wrote:
> changelog v3:
>
> Just a rebase on current l2-mtd.git.
Aiaiai says that your patch-set introduced several warnings, could you
please take a look:
--------------------------------------------------------------------------------
Bisectability test results for configuration "l2_mackerel_defconfig,arm,arm-unknown-linux-gnueabi-"
Bisecability test passed
--------------------------------------------------------------------------------
Successfully built configuration "l2_mackerel_defconfig,arm,arm-unknown-linux-gnueabi-", results:
--- before_patching.log
+++ after_patching.log
@@ @@
-drivers/mtd/nand/sh_flctl.c:264:30: warning: incorrect type in argument 1 (different address spaces) [sparse]
-drivers/mtd/nand/sh_flctl.c:264:30: expected void const volatile [noderef] <asn:2>*<noident> [sparse]
-drivers/mtd/nand/sh_flctl.c:264:30: got void *fifo_addr [sparse]
+drivers/mtd/nand/sh_flctl.c:301:38: warning: incorrect type in argument 1 (different address spaces) [sparse]
+drivers/mtd/nand/sh_flctl.c:301:38: expected void const volatile [noderef] <asn:2>*<noident> [sparse]
+drivers/mtd/nand/sh_flctl.c:301:38: got void *fifo_addr [sparse]
+drivers/mtd/nand/sh_flctl.c:326:28: warning: cast removes address space of expression [sparse]
+drivers/mtd/nand/sh_flctl.c:331:17: warning: incorrect type in argument 1 (different address spaces) [sparse]
+drivers/mtd/nand/sh_flctl.c:331:17: expected void const volatile [noderef] <asn:2>*<noident> [sparse]
+drivers/mtd/nand/sh_flctl.c:331:17: got void *fifo_addr [sparse]
+drivers/mtd/nand/sh_flctl.c:967 flctl_probe() warn: 'irq' was not released on error [smatch]
--------------------------------------------------------------------------------
--
Best Regards,
Artem Bityutskiy
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-05-02 10:38 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-02 9:41 [PATCH v3 0/10] sh_flctl hardware ECC mode cleanup Bastian Hecht
2012-05-02 9:41 ` [PATCH v3 01/10] mtd: sh_flctl: Add missing iounmap() Bastian Hecht
2012-05-02 9:41 ` [PATCH v3 02/10] ARM: sh-mobile: mackerel: Add error IRQ resource Bastian Hecht
2012-05-02 20:49 ` Rafael J. Wysocki
2012-05-02 21:03 ` Magnus Damm
2012-05-03 6:00 ` Artem Bityutskiy
2012-05-03 6:01 ` Artem Bityutskiy
[not found] ` <CABYn4szWZP4zZcz1MJ1xk5oCxiWh0nyJczcHGUqw4wE5MfJunA@mail.gmail.com>
2012-05-03 10:05 ` Artem Bityutskiy
2012-05-03 13:31 ` Rafael J. Wysocki
2012-05-02 9:41 ` [PATCH v3 03/10] mtd: sh_flctl: Add support for error IRQ Bastian Hecht
2012-05-02 9:41 ` [PATCH v3 04/10] mtd: sh_flctl: Use different OOB layout Bastian Hecht
2012-05-02 9:41 ` [PATCH v3 05/10] mtd: sh_flctl: Fix hardware ECC behaviour Bastian Hecht
2012-05-02 9:41 ` [PATCH v3 06/10] mtd: sh_flctl: Simplify the hardware ecc page read/write Bastian Hecht
2012-05-02 9:41 ` [PATCH v3 07/10] mtd: sh_flctl: Group sector accesses into a single transfer Bastian Hecht
2012-05-02 9:41 ` [PATCH v3 08/10] mtd: sh_flctl: Restructure the hardware ECC handling Bastian Hecht
2012-05-02 9:41 ` [PATCH v3 09/10] mtd: sh_flctl: Use user oob data in hardware ECC mode Bastian Hecht
2012-05-02 9:41 ` [PATCH v3 10/10] ARM: sh-mobile: mackerel: Use hardware error correction Bastian Hecht
2012-05-02 10:38 ` Artem Bityutskiy [this message]
2012-05-02 11:51 ` [PATCH v3 0/10] sh_flctl hardware ECC mode cleanup Bastian Hecht
2012-05-02 12:02 ` Artem Bityutskiy
2012-05-02 13:41 ` Bastian Hecht
2012-05-02 13:55 ` Artem Bityutskiy
2012-05-02 14:00 ` Bastian Hecht
2012-05-02 14:08 ` Artem Bityutskiy
2012-05-02 14:40 ` Bastian Hecht
2012-05-02 14:46 ` Bastian Hecht
2012-05-02 14:51 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1335955122.10293.39.camel@sauron.fi.intel.com \
--to=dedekind1@gmail.com \
--cc=computersforpeace@gmail.com \
--cc=hechtb@googlemail.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).