From: David Woodhouse <dwmw2@infradead.org>
To: Bastian Hecht <hechtb@googlemail.com>
Cc: Bastian Hecht <hechtb@gmail.com>,
magnus.damm@gmail.com, linux-mtd@lists.infradead.org,
laurent.pinchart@ideasonboard.com, linux-sh@vger.kernel.org
Subject: Re: [PATCH v4 2/8] mtd: sh_flctl: Add support for error IRQ
Date: Fri, 06 Jul 2012 15:51:48 +0000 [thread overview]
Message-ID: <1341589908.26921.14.camel@shinybook.infradead.org> (raw)
In-Reply-To: <1336997687-6868-3-git-send-email-hechtb@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 324 bytes --]
On Mon, 2012-05-14 at 14:14 +0200, Bastian Hecht wrote:
> + irq = platform_get_irq(pdev, 0);
> + if (irq < 0) {
Is that correct? I know we have sometimes suffered from the insanity of
assuming that irq 0 is *invalid*, and you're treating it as valid here.
Did we recover from our insanity?
--
dwmw2
[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 6171 bytes --]
next prev parent reply other threads:[~2012-07-06 15:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-14 12:14 [PATCH v4 0/8] sh_flctl hardware ECC mode cleanup Bastian Hecht
2012-05-14 12:14 ` [PATCH v4 1/8] mtd: sh_flctl: Add missing iounmap() Bastian Hecht
2012-05-14 12:14 ` [PATCH v4 2/8] mtd: sh_flctl: Add support for error IRQ Bastian Hecht
2012-07-06 15:51 ` David Woodhouse [this message]
2012-07-06 16:39 ` Bastian Hecht
2012-05-14 12:14 ` [PATCH v4 3/8] mtd: sh_flctl: Use different OOB layout Bastian Hecht
2012-05-14 12:14 ` [PATCH v4 4/8] mtd: sh_flctl: Fix hardware ECC behaviour Bastian Hecht
2012-05-14 12:14 ` [PATCH v4 5/8] mtd: sh_flctl: Simplify the hardware ecc page read/write Bastian Hecht
2012-05-14 12:14 ` [PATCH v4 6/8] mtd: sh_flctl: Group sector accesses into a single transfer Bastian Hecht
2012-05-14 12:14 ` [PATCH v4 7/8] mtd: sh_flctl: Restructure the hardware ECC handling Bastian Hecht
2012-05-14 12:14 ` [PATCH v4 8/8] mtd: sh_flctl: Use user oob data in hardware ECC mode Bastian Hecht
2012-05-14 15:12 ` Brian Norris
2012-05-16 9:37 ` Bastian Hecht
2012-05-15 10:47 ` [PATCH v4 0/8] sh_flctl hardware ECC mode cleanup Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1341589908.26921.14.camel@shinybook.infradead.org \
--to=dwmw2@infradead.org \
--cc=hechtb@gmail.com \
--cc=hechtb@googlemail.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).