* [PATCH] ARM: shmobile: kzm9g: enable restarting
@ 2012-07-20 6:16 Tetsuyuki Kobayshi
2012-07-23 1:21 ` Simon Horman
` (4 more replies)
0 siblings, 5 replies; 13+ messages in thread
From: Tetsuyuki Kobayshi @ 2012-07-20 6:16 UTC (permalink / raw)
To: linux-sh
From: Tetsuyuki Kobayashi <koba@kmckk.co.jp>
Do soft-power-on-reset in sys_reboot system call.
How to test this patch
Execute "sudo reboot" from command line. The system will start shutdown
sequence and finally reboot and U-Boot restarts.
Cc: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Simon Horman <horms@verge.net.au>
Signed-off-by: Tetsuyuki Kobayashi <koba@kmckk.co.jp>
---
This patch is based on renesas.git next branch.
arch/arm/mach-shmobile/board-kzm9g.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/arch/arm/mach-shmobile/board-kzm9g.c b/arch/arm/mach-shmobile/board-kzm9g.c
index 53b7ea9..fd21fb6 100644
--- a/arch/arm/mach-shmobile/board-kzm9g.c
+++ b/arch/arm/mach-shmobile/board-kzm9g.c
@@ -763,6 +763,13 @@ static void __init kzm_init(void)
platform_add_devices(kzm_devices, ARRAY_SIZE(kzm_devices));
}
+static void kzm9g_restart(char mode, const char *cmd)
+{
+#define RESCNT2 0xe6188020
+ /* Do soft power on reset */
+ writel((1 << 31), RESCNT2);
+}
+
static const char *kzm9g_boards_compat_dt[] __initdata = {
"renesas,kzm9g",
NULL,
@@ -777,5 +784,6 @@ DT_MACHINE_START(KZM9G_DT, "kzm9g")
.init_machine = kzm_init,
.init_late = shmobile_init_late,
.timer = &shmobile_timer,
+ .restart = kzm9g_restart,
.dt_compat = kzm9g_boards_compat_dt,
MACHINE_END
--
1.7.9.5
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH] ARM: shmobile: kzm9g: enable restarting
2012-07-20 6:16 [PATCH] ARM: shmobile: kzm9g: enable restarting Tetsuyuki Kobayshi
@ 2012-07-23 1:21 ` Simon Horman
2012-07-23 2:37 ` Tetsuyuki Kobayashi
` (3 subsequent siblings)
4 siblings, 0 replies; 13+ messages in thread
From: Simon Horman @ 2012-07-23 1:21 UTC (permalink / raw)
To: linux-sh
On Fri, Jul 20, 2012 at 03:16:30PM +0900, Tetsuyuki Kobayshi wrote:
> From: Tetsuyuki Kobayashi <koba@kmckk.co.jp>
>
> Do soft-power-on-reset in sys_reboot system call.
>
> How to test this patch
> Execute "sudo reboot" from command line. The system will start shutdown
> sequence and finally reboot and U-Boot restarts.
Hi Kobayashi-san,
I am testing using Iwamatsu-san's uboot which can be found at
http://git.denx.de/?p=u-boot/u-boot-sh.git
I am using the next branch of Rafael's renesas branch,
commit 45c7a01f070146e08f5c838315ffca5ade6e3844 ("Merge branch
'renesas-marzen' into renesas-board").
I am using the default config with the following also enabled.
CONFIG_ARM_APPENDED_DTB=y
CONFIG_CMDLINE_FORCE=y
This patch seems to work fine when booting a uImage from uBoot using
bootp;bootm. But it seems to prevent the board from booting a zImage from
uBoot using bootp;bootz. I am unsure why.
Note that I am referring to the first boot: a cold start.
Not booting for a second time after issuing the reboot command in Linux.
> Cc: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
> Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> Cc: Simon Horman <horms@verge.net.au>
> Signed-off-by: Tetsuyuki Kobayashi <koba@kmckk.co.jp>
> ---
> This patch is based on renesas.git next branch.
>
> arch/arm/mach-shmobile/board-kzm9g.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm/mach-shmobile/board-kzm9g.c b/arch/arm/mach-shmobile/board-kzm9g.c
> index 53b7ea9..fd21fb6 100644
> --- a/arch/arm/mach-shmobile/board-kzm9g.c
> +++ b/arch/arm/mach-shmobile/board-kzm9g.c
> @@ -763,6 +763,13 @@ static void __init kzm_init(void)
> platform_add_devices(kzm_devices, ARRAY_SIZE(kzm_devices));
> }
>
> +static void kzm9g_restart(char mode, const char *cmd)
> +{
> +#define RESCNT2 0xe6188020
> + /* Do soft power on reset */
> + writel((1 << 31), RESCNT2);
> +}
> +
> static const char *kzm9g_boards_compat_dt[] __initdata = {
> "renesas,kzm9g",
> NULL,
> @@ -777,5 +784,6 @@ DT_MACHINE_START(KZM9G_DT, "kzm9g")
> .init_machine = kzm_init,
> .init_late = shmobile_init_late,
> .timer = &shmobile_timer,
> + .restart = kzm9g_restart,
> .dt_compat = kzm9g_boards_compat_dt,
> MACHINE_END
> --
> 1.7.9.5
>
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] ARM: shmobile: kzm9g: enable restarting
2012-07-20 6:16 [PATCH] ARM: shmobile: kzm9g: enable restarting Tetsuyuki Kobayshi
2012-07-23 1:21 ` Simon Horman
@ 2012-07-23 2:37 ` Tetsuyuki Kobayashi
2012-07-23 8:47 ` Tetsuyuki Kobayashi
` (2 subsequent siblings)
4 siblings, 0 replies; 13+ messages in thread
From: Tetsuyuki Kobayashi @ 2012-07-23 2:37 UTC (permalink / raw)
To: linux-sh
Thank you, Simon-san.
I have never used bootz command to boot zImage. I will try it.
(2012/07/23 10:21), Simon Horman wrote:
> On Fri, Jul 20, 2012 at 03:16:30PM +0900, Tetsuyuki Kobayshi wrote:
>> From: Tetsuyuki Kobayashi <koba@kmckk.co.jp>
>>
>> Do soft-power-on-reset in sys_reboot system call.
>>
>> How to test this patch
>> Execute "sudo reboot" from command line. The system will start shutdown
>> sequence and finally reboot and U-Boot restarts.
>
> Hi Kobayashi-san,
>
> I am testing using Iwamatsu-san's uboot which can be found at
> http://git.denx.de/?p=u-boot/u-boot-sh.git
>
> I am using the next branch of Rafael's renesas branch,
> commit 45c7a01f070146e08f5c838315ffca5ade6e3844 ("Merge branch
> 'renesas-marzen' into renesas-board").
>
> I am using the default config with the following also enabled.
>
> CONFIG_ARM_APPENDED_DTB=y
> CONFIG_CMDLINE_FORCE=y
>
> This patch seems to work fine when booting a uImage from uBoot using
> bootp;bootm. But it seems to prevent the board from booting a zImage from
> uBoot using bootp;bootz. I am unsure why.
>
> Note that I am referring to the first boot: a cold start.
> Not booting for a second time after issuing the reboot command in Linux.
>
>> Cc: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
>> Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>> Cc: Simon Horman <horms@verge.net.au>
>> Signed-off-by: Tetsuyuki Kobayashi <koba@kmckk.co.jp>
>> ---
>> This patch is based on renesas.git next branch.
>>
>> arch/arm/mach-shmobile/board-kzm9g.c | 8 ++++++++
>> 1 file changed, 8 insertions(+)
>>
>> diff --git a/arch/arm/mach-shmobile/board-kzm9g.c b/arch/arm/mach-shmobile/board-kzm9g.c
>> index 53b7ea9..fd21fb6 100644
>> --- a/arch/arm/mach-shmobile/board-kzm9g.c
>> +++ b/arch/arm/mach-shmobile/board-kzm9g.c
>> @@ -763,6 +763,13 @@ static void __init kzm_init(void)
>> platform_add_devices(kzm_devices, ARRAY_SIZE(kzm_devices));
>> }
>>
>> +static void kzm9g_restart(char mode, const char *cmd)
>> +{
>> +#define RESCNT2 0xe6188020
>> + /* Do soft power on reset */
>> + writel((1 << 31), RESCNT2);
>> +}
>> +
>> static const char *kzm9g_boards_compat_dt[] __initdata = {
>> "renesas,kzm9g",
>> NULL,
>> @@ -777,5 +784,6 @@ DT_MACHINE_START(KZM9G_DT, "kzm9g")
>> .init_machine = kzm_init,
>> .init_late = shmobile_init_late,
>> .timer = &shmobile_timer,
>> + .restart = kzm9g_restart,
>> .dt_compat = kzm9g_boards_compat_dt,
>> MACHINE_END
>> --
>> 1.7.9.5
>>
>
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] ARM: shmobile: kzm9g: enable restarting
2012-07-20 6:16 [PATCH] ARM: shmobile: kzm9g: enable restarting Tetsuyuki Kobayshi
2012-07-23 1:21 ` Simon Horman
2012-07-23 2:37 ` Tetsuyuki Kobayashi
@ 2012-07-23 8:47 ` Tetsuyuki Kobayashi
2012-07-23 8:57 ` Simon Horman
2012-08-25 6:17 ` Simon Horman
4 siblings, 0 replies; 13+ messages in thread
From: Tetsuyuki Kobayashi @ 2012-07-23 8:47 UTC (permalink / raw)
To: linux-sh
Hi, Simon-san
I tried bootz command to boot zImage with dtb.
I used tftpboot instead of bootp.
It works fine with me with/without this patch.
(2012/07/23 11:37), Tetsuyuki Kobayashi wrote:
> Thank you, Simon-san.
> I have never used bootz command to boot zImage. I will try it.
>
> (2012/07/23 10:21), Simon Horman wrote:
>> On Fri, Jul 20, 2012 at 03:16:30PM +0900, Tetsuyuki Kobayshi wrote:
>>> From: Tetsuyuki Kobayashi <koba@kmckk.co.jp>
>>>
>>> Do soft-power-on-reset in sys_reboot system call.
>>>
>>> How to test this patch
>>> Execute "sudo reboot" from command line. The system will start
>>> shutdown
>>> sequence and finally reboot and U-Boot restarts.
>>
>> Hi Kobayashi-san,
>>
>> I am testing using Iwamatsu-san's uboot which can be found at
>> http://git.denx.de/?p=u-boot/u-boot-sh.git
>>
>> I am using the next branch of Rafael's renesas branch,
>> commit 45c7a01f070146e08f5c838315ffca5ade6e3844 ("Merge branch
>> 'renesas-marzen' into renesas-board").
>>
>> I am using the default config with the following also enabled.
>>
>> CONFIG_ARM_APPENDED_DTB=y
>> CONFIG_CMDLINE_FORCE=y
>>
>> This patch seems to work fine when booting a uImage from uBoot using
>> bootp;bootm. But it seems to prevent the board from booting a zImage
>> from
>> uBoot using bootp;bootz. I am unsure why.
>>
>> Note that I am referring to the first boot: a cold start.
>> Not booting for a second time after issuing the reboot command in Linux.
>>
>>> Cc: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
>>> Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>>> Cc: Simon Horman <horms@verge.net.au>
>>> Signed-off-by: Tetsuyuki Kobayashi <koba@kmckk.co.jp>
>>> ---
>>> This patch is based on renesas.git next branch.
>>>
>>> arch/arm/mach-shmobile/board-kzm9g.c | 8 ++++++++
>>> 1 file changed, 8 insertions(+)
>>>
>>> diff --git a/arch/arm/mach-shmobile/board-kzm9g.c
>>> b/arch/arm/mach-shmobile/board-kzm9g.c
>>> index 53b7ea9..fd21fb6 100644
>>> --- a/arch/arm/mach-shmobile/board-kzm9g.c
>>> +++ b/arch/arm/mach-shmobile/board-kzm9g.c
>>> @@ -763,6 +763,13 @@ static void __init kzm_init(void)
>>> platform_add_devices(kzm_devices, ARRAY_SIZE(kzm_devices));
>>> }
>>>
>>> +static void kzm9g_restart(char mode, const char *cmd)
>>> +{
>>> +#define RESCNT2 0xe6188020
>>> + /* Do soft power on reset */
>>> + writel((1 << 31), RESCNT2);
>>> +}
>>> +
>>> static const char *kzm9g_boards_compat_dt[] __initdata = {
>>> "renesas,kzm9g",
>>> NULL,
>>> @@ -777,5 +784,6 @@ DT_MACHINE_START(KZM9G_DT, "kzm9g")
>>> .init_machine = kzm_init,
>>> .init_late = shmobile_init_late,
>>> .timer = &shmobile_timer,
>>> + .restart = kzm9g_restart,
>>> .dt_compat = kzm9g_boards_compat_dt,
>>> MACHINE_END
>>> --
>>> 1.7.9.5
>>>
>>
>
>
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] ARM: shmobile: kzm9g: enable restarting
2012-07-20 6:16 [PATCH] ARM: shmobile: kzm9g: enable restarting Tetsuyuki Kobayshi
` (2 preceding siblings ...)
2012-07-23 8:47 ` Tetsuyuki Kobayashi
@ 2012-07-23 8:57 ` Simon Horman
2012-08-25 6:17 ` Simon Horman
4 siblings, 0 replies; 13+ messages in thread
From: Simon Horman @ 2012-07-23 8:57 UTC (permalink / raw)
To: linux-sh
On Mon, Jul 23, 2012 at 05:47:07PM +0900, Tetsuyuki Kobayashi wrote:
> Hi, Simon-san
>
> I tried bootz command to boot zImage with dtb.
> I used tftpboot instead of bootp.
> It works fine with me with/without this patch.
Thanks, I guess that there was something wrong with my test.
Acked-by: Simon Horman <horms@verge.net.au>
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] ARM: shmobile: kzm9g: enable restarting
2012-07-20 6:16 [PATCH] ARM: shmobile: kzm9g: enable restarting Tetsuyuki Kobayshi
` (3 preceding siblings ...)
2012-07-23 8:57 ` Simon Horman
@ 2012-08-25 6:17 ` Simon Horman
4 siblings, 0 replies; 13+ messages in thread
From: Simon Horman @ 2012-08-25 6:17 UTC (permalink / raw)
To: linux-sh
On Mon, Jul 23, 2012 at 05:57:36PM +0900, Simon Horman wrote:
> On Mon, Jul 23, 2012 at 05:47:07PM +0900, Tetsuyuki Kobayashi wrote:
> > Hi, Simon-san
> >
> > I tried bootz command to boot zImage with dtb.
> > I used tftpboot instead of bootp.
> > It works fine with me with/without this patch.
>
> Thanks, I guess that there was something wrong with my test.
Hi Kobayashi-san,
I have queued this change up in the kzm9g branch of my renesas tree,
git://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas.git
I will endeavour to get it included in 3.7.
^ permalink raw reply [flat|nested] 13+ messages in thread
* [GIT PULL] Renesas ARM-based SoC: KZM-9A-GT for 3.7
@ 2012-08-28 0:18 Simon Horman
2012-08-28 0:18 ` [PATCH] ARM: shmobile: kzm9g: enable restarting Simon Horman
` (3 more replies)
0 siblings, 4 replies; 13+ messages in thread
From: Simon Horman @ 2012-08-28 0:18 UTC (permalink / raw)
To: linux-arm-kernel
Hi Olaf, Hi Arnd,
please consider the following enhancement for the KZM-9A-GT board
from Tetsuyuki Kobayashi for inclusion in 3.7.
----------------------------------------------------------------
The following changes since commit fea7a08acb13524b47711625eebea40a0ede69a0:
Linux 3.6-rc3 (2012-08-22 13:29:06 -0700)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas.git kzm9g
for you to fetch changes up to 7952717adb69efc1d2443a1858f96d23c2fb93e0:
ARM: shmobile: kzm9g: enable restarting (2012-08-25 14:39:44 +0900)
----------------------------------------------------------------
Tetsuyuki Kobayashi (1):
ARM: shmobile: kzm9g: enable restarting
arch/arm/mach-shmobile/board-kzm9g.c | 8 ++++++++
1 file changed, 8 insertions(+)
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH] ARM: shmobile: kzm9g: enable restarting
2012-08-28 0:18 [GIT PULL] Renesas ARM-based SoC: KZM-9A-GT for 3.7 Simon Horman
@ 2012-08-28 0:18 ` Simon Horman
2012-08-28 1:15 ` [GIT PULL] Renesas ARM-based SoC: KZM-9A-GT for 3.7 Tetsuyuki Kobayashi
` (2 subsequent siblings)
3 siblings, 0 replies; 13+ messages in thread
From: Simon Horman @ 2012-08-28 0:18 UTC (permalink / raw)
To: linux-arm-kernel
From: Tetsuyuki Kobayashi <koba@kmckk.co.jp>
Do soft-power-on-reset in sys_reboot system call.
How to test this patch
Execute "sudo reboot" from command line. The system will start shutdown
sequence and finally reboot and U-Boot restarts.
Cc: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Tetsuyuki Kobayashi <koba@kmckk.co.jp>
Signed-off-by: Simon Horman <horms@verge.net.au>
---
arch/arm/mach-shmobile/board-kzm9g.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/arch/arm/mach-shmobile/board-kzm9g.c b/arch/arm/mach-shmobile/board-kzm9g.c
index 53b7ea9..fd21fb6 100644
--- a/arch/arm/mach-shmobile/board-kzm9g.c
+++ b/arch/arm/mach-shmobile/board-kzm9g.c
@@ -763,6 +763,13 @@ static void __init kzm_init(void)
platform_add_devices(kzm_devices, ARRAY_SIZE(kzm_devices));
}
+static void kzm9g_restart(char mode, const char *cmd)
+{
+#define RESCNT2 0xe6188020
+ /* Do soft power on reset */
+ writel((1 << 31), RESCNT2);
+}
+
static const char *kzm9g_boards_compat_dt[] __initdata = {
"renesas,kzm9g",
NULL,
@@ -777,5 +784,6 @@ DT_MACHINE_START(KZM9G_DT, "kzm9g")
.init_machine = kzm_init,
.init_late = shmobile_init_late,
.timer = &shmobile_timer,
+ .restart = kzm9g_restart,
.dt_compat = kzm9g_boards_compat_dt,
MACHINE_END
--
1.7.10.2.484.gcd07cc5
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [GIT PULL] Renesas ARM-based SoC: KZM-9A-GT for 3.7
2012-08-28 0:18 [GIT PULL] Renesas ARM-based SoC: KZM-9A-GT for 3.7 Simon Horman
2012-08-28 0:18 ` [PATCH] ARM: shmobile: kzm9g: enable restarting Simon Horman
@ 2012-08-28 1:15 ` Tetsuyuki Kobayashi
2012-08-30 5:43 ` Simon Horman
2012-09-05 22:34 ` Olof Johansson
2012-09-28 20:02 ` Arnd Bergmann
3 siblings, 1 reply; 13+ messages in thread
From: Tetsuyuki Kobayashi @ 2012-08-28 1:15 UTC (permalink / raw)
To: linux-arm-kernel
(2012/08/28 9:18), Simon Horman wrote:
> Hi Olaf, Hi Arnd,
>
> please consider the following enhancement for the KZM-9A-GT board
Just a minor correction :)
The board name is KZM-A9-GT.
> from Tetsuyuki Kobayashi for inclusion in 3.7.
>
> ----------------------------------------------------------------
> The following changes since commit fea7a08acb13524b47711625eebea40a0ede69a0:
>
> Linux 3.6-rc3 (2012-08-22 13:29:06 -0700)
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas.git kzm9g
>
> for you to fetch changes up to 7952717adb69efc1d2443a1858f96d23c2fb93e0:
>
> ARM: shmobile: kzm9g: enable restarting (2012-08-25 14:39:44 +0900)
>
> ----------------------------------------------------------------
> Tetsuyuki Kobayashi (1):
> ARM: shmobile: kzm9g: enable restarting
>
> arch/arm/mach-shmobile/board-kzm9g.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [GIT PULL] Renesas ARM-based SoC: KZM-9A-GT for 3.7
2012-08-28 1:15 ` [GIT PULL] Renesas ARM-based SoC: KZM-9A-GT for 3.7 Tetsuyuki Kobayashi
@ 2012-08-30 5:43 ` Simon Horman
0 siblings, 0 replies; 13+ messages in thread
From: Simon Horman @ 2012-08-30 5:43 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Aug 28, 2012 at 10:15:03AM +0900, Tetsuyuki Kobayashi wrote:
> (2012/08/28 9:18), Simon Horman wrote:
> > Hi Olaf, Hi Arnd,
> >
> > please consider the following enhancement for the KZM-9A-GT board
>
> Just a minor correction :)
> The board name is KZM-A9-GT.
Thanks, sorry about that.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [GIT PULL] Renesas ARM-based SoC: KZM-9A-GT for 3.7
2012-08-28 0:18 [GIT PULL] Renesas ARM-based SoC: KZM-9A-GT for 3.7 Simon Horman
2012-08-28 0:18 ` [PATCH] ARM: shmobile: kzm9g: enable restarting Simon Horman
2012-08-28 1:15 ` [GIT PULL] Renesas ARM-based SoC: KZM-9A-GT for 3.7 Tetsuyuki Kobayashi
@ 2012-09-05 22:34 ` Olof Johansson
2012-09-28 20:02 ` Arnd Bergmann
3 siblings, 0 replies; 13+ messages in thread
From: Olof Johansson @ 2012-09-05 22:34 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Aug 28, 2012 at 09:18:35AM +0900, Simon Horman wrote:
> Hi Olaf, Hi Arnd,
>
> please consider the following enhancement for the KZM-9A-GT board
> from Tetsuyuki Kobayashi for inclusion in 3.7.
>
> ----------------------------------------------------------------
> The following changes since commit fea7a08acb13524b47711625eebea40a0ede69a0:
>
> Linux 3.6-rc3 (2012-08-22 13:29:06 -0700)
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas.git kzm9g
Thanks, pulled into next/soc.
-Olof
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [GIT PULL] Renesas ARM-based SoC: KZM-9A-GT for 3.7
2012-08-28 0:18 [GIT PULL] Renesas ARM-based SoC: KZM-9A-GT for 3.7 Simon Horman
` (2 preceding siblings ...)
2012-09-05 22:34 ` Olof Johansson
@ 2012-09-28 20:02 ` Arnd Bergmann
2012-10-01 0:03 ` Simon Horman
3 siblings, 1 reply; 13+ messages in thread
From: Arnd Bergmann @ 2012-09-28 20:02 UTC (permalink / raw)
To: linux-arm-kernel
On Tuesday 28 August 2012, Simon Horman wrote:
> ----------------------------------------------------------------
> Tetsuyuki Kobayashi (1):
> ARM: shmobile: kzm9g: enable restarting
>
> arch/arm/mach-shmobile/board-kzm9g.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
This patch ended up causing a new build warning in combination
with the io.h changes in Russell's tree.
I've just applied this patch on top, which is the same thing we
did to all the other open-coded mmio locations.
Arnd
commit 28901c1fed11dfeab65f640878e85a9b61d311ed
Author: Arnd Bergmann <arnd@arndb.de>
Date: Sun Sep 23 22:41:21 2012 +0000
ARM: shmobile: add new __iomem annotation for new code
While we fixed up all instances that were already present in v3.6,
this one came in through new code.
Without this patch, building kzm9g_defconfig results in:
arch/arm/mach-shmobile/board-kzm9g.c: In function 'kzm9g_restart':
arch/arm/mach-shmobile/board-kzm9g.c:781:2: warning: passing argument 2 of '__raw_writel' makes pointer from integer without a cast [enabled by default]
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Tetsuyuki Kobayashi <koba@kmckk.co.jp>
Cc: Simon Horman <horms@verge.net.au>
diff --git a/arch/arm/mach-shmobile/board-kzm9g.c b/arch/arm/mach-shmobile/board-kzm9g.c
index fd21fb6..5d792e4 100644
--- a/arch/arm/mach-shmobile/board-kzm9g.c
+++ b/arch/arm/mach-shmobile/board-kzm9g.c
@@ -765,7 +765,7 @@ static void __init kzm_init(void)
static void kzm9g_restart(char mode, const char *cmd)
{
-#define RESCNT2 0xe6188020
+#define RESCNT2 IOMEM(0xe6188020)
/* Do soft power on reset */
writel((1 << 31), RESCNT2);
}
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [GIT PULL] Renesas ARM-based SoC: KZM-9A-GT for 3.7
2012-09-28 20:02 ` Arnd Bergmann
@ 2012-10-01 0:03 ` Simon Horman
0 siblings, 0 replies; 13+ messages in thread
From: Simon Horman @ 2012-10-01 0:03 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Sep 28, 2012 at 08:02:28PM +0000, Arnd Bergmann wrote:
> On Tuesday 28 August 2012, Simon Horman wrote:
> > ----------------------------------------------------------------
> > Tetsuyuki Kobayashi (1):
> > ARM: shmobile: kzm9g: enable restarting
> >
> > arch/arm/mach-shmobile/board-kzm9g.c | 8 ++++++++
> > 1 file changed, 8 insertions(+)
>
> This patch ended up causing a new build warning in combination
> with the io.h changes in Russell's tree.
>
> I've just applied this patch on top, which is the same thing we
> did to all the other open-coded mmio locations.
Thanks, sorry for missing that.
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2012-10-01 0:03 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-08-28 0:18 [GIT PULL] Renesas ARM-based SoC: KZM-9A-GT for 3.7 Simon Horman
2012-08-28 0:18 ` [PATCH] ARM: shmobile: kzm9g: enable restarting Simon Horman
2012-08-28 1:15 ` [GIT PULL] Renesas ARM-based SoC: KZM-9A-GT for 3.7 Tetsuyuki Kobayashi
2012-08-30 5:43 ` Simon Horman
2012-09-05 22:34 ` Olof Johansson
2012-09-28 20:02 ` Arnd Bergmann
2012-10-01 0:03 ` Simon Horman
-- strict thread matches above, loose matches on Subject: below --
2012-07-20 6:16 [PATCH] ARM: shmobile: kzm9g: enable restarting Tetsuyuki Kobayshi
2012-07-23 1:21 ` Simon Horman
2012-07-23 2:37 ` Tetsuyuki Kobayashi
2012-07-23 8:47 ` Tetsuyuki Kobayashi
2012-07-23 8:57 ` Simon Horman
2012-08-25 6:17 ` Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).