* Re: [PATCH 0/2] Preliminary Armadillo DT support
2012-12-16 13:54 [PATCH 0/2] Preliminary Armadillo DT support Bastian Hecht
@ 2012-12-17 1:01 ` Kuninori Morimoto
2012-12-17 11:23 ` Bastian Hecht
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Kuninori Morimoto @ 2012-12-17 1:01 UTC (permalink / raw)
To: linux-sh
Hi Bastian
> This is a minimal setup for DT booting Armadillo boards. It's based on Simon
> Horman's reference implementation for the kz9mg board.
>
> The only device added so far is the ethernet controller sh_eth. For this the
> driver is enhanced to support DT-based probing in the 2nd patch.
>
> Care should be taken as the lines
> - /* armadillo 800 eva extal1 is 24MHz */
> - clk_set_rate(xtal1, 24000000);
> are removed and the r8a7740 code uses 25MHz by default. I'm unsure if just some clock
> calculations get incorrect or if we overclock our board somewhere.
>
> The patches are based on git://git.kernel.org/pub/scm/linux/kernel/git/horms/devel/of
> revision 9fcbfcfd31c782840ebb57f283c174c749467434.
>
> Bastian Hecht (2):
> ARM: shmobile: Armadillo800eva: DT boot testcase with ethernet
> support
> net: sh_eth: Add Device Tree support
>
> arch/arm/boot/dts/r8a7740-armadillo800eva.dts | 7 +
> arch/arm/mach-shmobile/board-armadillo800eva.c | 1167 +-----------------------
> arch/arm/mach-shmobile/clock-r8a7740.c | 1 +
> arch/arm/mach-shmobile/include/mach/common.h | 2 +
> drivers/net/ethernet/renesas/sh_eth.c | 72 +-
> 5 files changed, 86 insertions(+), 1163 deletions(-)
Preliminary Armadillo800eva DT support itself is very good.
But I guess these patches kill off "current" Armadillo800eva users who are using many devices ?
How about this ?
1) add new file like board-armadillo800eva-dt.c for DT support
2) keep adding new DT suuport on board-armadillo800eva-dt.c
3) If board-armadillo800eva-dt.c has full-support,
remove old board-armadillo800eva.c
Best regards
---
Kuninori Morimoto
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 0/2] Preliminary Armadillo DT support
2012-12-16 13:54 [PATCH 0/2] Preliminary Armadillo DT support Bastian Hecht
2012-12-17 1:01 ` Kuninori Morimoto
@ 2012-12-17 11:23 ` Bastian Hecht
2012-12-18 0:05 ` Simon Horman
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Bastian Hecht @ 2012-12-17 11:23 UTC (permalink / raw)
To: linux-sh
Hi,
>
> Preliminary Armadillo800eva DT support itself is very good.
> But I guess these patches kill off "current" Armadillo800eva users who are using many devices ?
>
> How about this ?
> 1) add new file like board-armadillo800eva-dt.c for DT support
> 2) keep adding new DT suuport on board-armadillo800eva-dt.c
> 3) If board-armadillo800eva-dt.c has full-support,
> remove old board-armadillo800eva.c
>
Sounds like a plan!
Yes this looks like the way Simon has made up his kzm9g reference
implementation. So I suppose we want this extra board file in the
mainline until 3) happens?
Cheers,
Bastian
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 0/2] Preliminary Armadillo DT support
2012-12-16 13:54 [PATCH 0/2] Preliminary Armadillo DT support Bastian Hecht
2012-12-17 1:01 ` Kuninori Morimoto
2012-12-17 11:23 ` Bastian Hecht
@ 2012-12-18 0:05 ` Simon Horman
2012-12-18 0:08 ` Kuninori Morimoto
2012-12-18 0:30 ` Simon Horman
4 siblings, 0 replies; 6+ messages in thread
From: Simon Horman @ 2012-12-18 0:05 UTC (permalink / raw)
To: linux-sh
On Mon, Dec 17, 2012 at 12:23:44PM +0100, Bastian Hecht wrote:
> Hi,
>
> >
> > Preliminary Armadillo800eva DT support itself is very good.
> > But I guess these patches kill off "current" Armadillo800eva users who are using many devices ?
> >
> > How about this ?
> > 1) add new file like board-armadillo800eva-dt.c for DT support
> > 2) keep adding new DT suuport on board-armadillo800eva-dt.c
> > 3) If board-armadillo800eva-dt.c has full-support,
> > remove old board-armadillo800eva.c
> >
>
> Sounds like a plan!
> Yes this looks like the way Simon has made up his kzm9g reference
> implementation. So I suppose we want this extra board file in the
> mainline until 3) happens?
Yes, I think that is the plan.
Could you please call the new file "-reference" to be consistent with
kam9g? You may or may not also need to have a "-reference" .dts and
.dtsi files.
Strictly speaking board-armadillo800eva.c already uses DT,
albeit in a very minimal way. This is the reason I would like to
avoid using "-dt" in the new file names.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 0/2] Preliminary Armadillo DT support
2012-12-16 13:54 [PATCH 0/2] Preliminary Armadillo DT support Bastian Hecht
` (2 preceding siblings ...)
2012-12-18 0:05 ` Simon Horman
@ 2012-12-18 0:08 ` Kuninori Morimoto
2012-12-18 0:30 ` Simon Horman
4 siblings, 0 replies; 6+ messages in thread
From: Kuninori Morimoto @ 2012-12-18 0:08 UTC (permalink / raw)
To: linux-sh
Hi Bastian
Cc Simon
> > How about this ?
> > 1) add new file like board-armadillo800eva-dt.c for DT support
> > 2) keep adding new DT suuport on board-armadillo800eva-dt.c
> > 3) If board-armadillo800eva-dt.c has full-support,
> > remove old board-armadillo800eva.c
> >
>
> Sounds like a plan!
> Yes this looks like the way Simon has made up his kzm9g reference
> implementation. So I suppose we want this extra board file in the
> mainline until 3) happens?
It is nice for users.
But I'm not sure detail of patch maintenance side work. >> Simon
Best regards
---
Kuninori Morimoto
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 0/2] Preliminary Armadillo DT support
2012-12-16 13:54 [PATCH 0/2] Preliminary Armadillo DT support Bastian Hecht
` (3 preceding siblings ...)
2012-12-18 0:08 ` Kuninori Morimoto
@ 2012-12-18 0:30 ` Simon Horman
4 siblings, 0 replies; 6+ messages in thread
From: Simon Horman @ 2012-12-18 0:30 UTC (permalink / raw)
To: linux-sh
On Mon, Dec 17, 2012 at 04:08:01PM -0800, Kuninori Morimoto wrote:
>
> Hi Bastian
> Cc Simon
>
> > > How about this ?
> > > 1) add new file like board-armadillo800eva-dt.c for DT support
> > > 2) keep adding new DT suuport on board-armadillo800eva-dt.c
> > > 3) If board-armadillo800eva-dt.c has full-support,
> > > remove old board-armadillo800eva.c
> > >
> >
> > Sounds like a plan!
> > Yes this looks like the way Simon has made up his kzm9g reference
> > implementation. So I suppose we want this extra board file in the
> > mainline until 3) happens?
>
> It is nice for users.
> But I'm not sure detail of patch maintenance side work. >> Simon
Users are more important :^)
^ permalink raw reply [flat|nested] 6+ messages in thread