From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Date: Thu, 14 Feb 2013 12:26:42 +0000 Subject: Re: [PATCH] sh-pfc: sh_pfc_probe() sizeof() fix Message-Id: <136086880.YvIUptHpB2@avalon> List-Id: References: <20130214122347.20778.10789.sendpatchset@w520> In-Reply-To: <20130214122347.20778.10789.sendpatchset@w520> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-sh@vger.kernel.org Hi Magnus, Thanks for the patch. On Thursday 14 February 2013 21:23:47 Magnus Damm wrote: > From: Magnus Damm > > Fix sizeof() usage in sh-pfc/core.c to allocate space > for the full data structure instead of a pointer. Oops :-) This is v3.9 material. Simon, could you please take this and push it upstream for v3.9 ? > Signed-off-by: Magnus Damm > --- > > Written against -next in renesas.git > > drivers/pinctrl/sh-pfc/core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- 0001/drivers/pinctrl/sh-pfc/core.c > +++ work/drivers/pinctrl/sh-pfc/core.c 2013-02-14 21:04:20.000000000 +0900 > @@ -495,7 +495,7 @@ static int sh_pfc_probe(struct platform_ > if (info = NULL) > return -ENODEV; > > - pfc = devm_kzalloc(&pdev->dev, sizeof(pfc), GFP_KERNEL); > + pfc = devm_kzalloc(&pdev->dev, sizeof(*pfc), GFP_KERNEL); > if (pfc = NULL) > return -ENOMEM; -- Regards, Laurent Pinchart