From: Simon Horman <horms+renesas@verge.net.au>
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: shmobile: r8a7779: Correct TMU clock support again
Date: Tue, 19 Feb 2013 03:49:05 +0000 [thread overview]
Message-ID: <1361245745-23355-2-git-send-email-horms+renesas@verge.net.au> (raw)
In-Reply-To: <1361245745-23355-1-git-send-email-horms+renesas@verge.net.au>
After discussion on the linux-sh mailing list and reference to the
hardware documentation it appears that 'TMU00', 'TMU01' and 'TMU02'
use a common clock.
The sh_tmu.1 portion of this change resolves a regression introduced in
58079fa7d54a0929d304054ee759187a2ccd3cdf (ARM: shmobile: r8a7779: Correct
TMU clock support) and fixes a regression introduced by that patch. That
patch is queued up for v3.9.
...
hub 4-0:1.0: USB hub found
hub 4-0:1.0: 2 ports detected
INFO: rcu_sched self-detected stall on CPUINFO: rcu_sched detected stalls on
+CPUs/tasks: { 1} (detected by 2, t'9640 jiffies, gB94967052, cB94967051,
+q8)
Task dump for CPU 1:
swapper/0 R running 0 1 0 0x00000002
[<c02b8f5c>] (__schedule+0x1b0/0x4c0) from [<c013c590>] (__loop_delay+0x4/0xc)
{ 1} (t'9640 jiffies gB94967052 cB94967052 q7)
[<c000ef9c>] (unwind_backtrace+0x0/0xf8) from [<c0068488>]
+(rcu_check_callbacks+0x218/0x6b8)
[<c0068488>] (rcu_check_callbacks+0x218/0x6b8) from [<c0026774>]
+(update_process_times+0x38/0x4c)
[<c0026774>] (update_process_times+0x38/0x4c) from [<c00569e0>]
+(tick_nohz_handler+0xb4/0x11c)
[<c00569e0>] (tick_nohz_handler+0xb4/0x11c) from [<c000e518>]
+(twd_handler+0x34/0x44)
[<c000e518>] (twd_handler+0x34/0x44) from [<c0063484>]
+(handle_percpu_devid_irq+0x68/0x80)
[<c0063484>] (handle_percpu_devid_irq+0x68/0x80) from [<c005febc>]
+(generic_handle_irq+0x20/0x30)
[<c005febc>] (generic_handle_irq+0x20/0x30) from [<c000a5ec>]
+(handle_IRQ+0x40/0x90)
[<c000a5ec>] (handle_IRQ+0x40/0x90) from [<c000934c>] (gic_handle_irq+0x2c/0x5c)
[<c000934c>] (gic_handle_irq+0x2c/0x5c) from [<c0009a40>] (__irq_svc+0x40/0x50)
Exception stack(0xef03ddf8 to 0xef03de40)
dde0: 000001c1 ffffffff
de00: 000001d8 01bf01bf ef35ec40 ef35e800 ef35ec6c 0000002b ef35ec68 c013c560
de20: c0392994 60000113 00000000 ef03de40 c01a5d40 c013c590 20000113 ffffffff
[<c0009a40>] (__irq_svc+0x40/0x50) from [<c013c590>] (__loop_delay+0x4/0xc)
Cc: Denis Oliver Kropp <dok@directfb.org>
Cc: Magnus Damm <damm@opensource.se>
Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Paul Mundt <lethal@linux-sh.org>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
arch/arm/mach-shmobile/clock-r8a7779.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-shmobile/clock-r8a7779.c b/arch/arm/mach-shmobile/clock-r8a7779.c
index 202370d..1db3653 100644
--- a/arch/arm/mach-shmobile/clock-r8a7779.c
+++ b/arch/arm/mach-shmobile/clock-r8a7779.c
@@ -161,8 +161,8 @@ static struct clk_lookup lookups[] = {
CLKDEV_DEV_ID("ehci-platform.0", &mstp_clks[MSTP100]), /* USB EHCI port0/1 */
CLKDEV_DEV_ID("ohci-platform.0", &mstp_clks[MSTP100]), /* USB OHCI port0/1 */
CLKDEV_DEV_ID("sh_tmu.0", &mstp_clks[MSTP016]), /* TMU00 */
- CLKDEV_DEV_ID("sh_tmu.1", &mstp_clks[MSTP015]), /* TMU01 */
- CLKDEV_DEV_ID("sh_tmu.2", &mstp_clks[MSTP014]), /* TMU02 */
+ CLKDEV_DEV_ID("sh_tmu.1", &mstp_clks[MSTP016]), /* TMU01 */
+ CLKDEV_DEV_ID("sh_tmu.2", &mstp_clks[MSTP016]), /* TMU02 */
CLKDEV_DEV_ID("i2c-rcar.0", &mstp_clks[MSTP030]), /* I2C0 */
CLKDEV_DEV_ID("i2c-rcar.1", &mstp_clks[MSTP029]), /* I2C1 */
CLKDEV_DEV_ID("i2c-rcar.2", &mstp_clks[MSTP028]), /* I2C2 */
--
1.7.10.4
next prev parent reply other threads:[~2013-02-19 3:49 UTC|newest]
Thread overview: 79+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-07 8:34 [GIT PULL] Renesas ARM-based SoC for v3.8 #2 Simon Horman
2012-11-07 8:34 ` [PATCH 1/4] ARM: shmobile: r8a7779: PFC rename PENCx -> USB_PENCx Simon Horman
2012-11-07 8:34 ` [PATCH 2/4] ARM: shmobile: r8a7740: add USB24 clock explain Simon Horman
2012-11-07 8:34 ` [PATCH 3/4] ARM: shmobile: r8a7779: add USB EHCI clock support Simon Horman
2012-11-07 8:34 ` [PATCH 4/4] ARM: shmobile: r8a7779: add USB OHCI " Simon Horman
2013-10-04 6:45 ` [PATCH 4/4] ARM: shmobile: r8a7779: add I2C clock for DT Kuninori Morimoto
2013-10-08 1:50 ` Simon Horman
2012-11-08 6:30 ` [GIT PULL] Renesas ARM-based SoC for v3.8 #2 Simon Horman
2012-11-13 3:10 ` [GIT PULL] Renesas ARM-based SoC for v3.8 #4 Simon Horman
2012-11-13 3:10 ` [PATCH 1/4] Revert "ARM: shmobile: emev2: Replace modify_scu_cpu_psr with scu_power_mode" Simon Horman
2012-11-13 3:10 ` [PATCH 2/4] Revert "ARM: shmobile: sh73a0: " Simon Horman
2012-11-13 3:10 ` [PATCH 3/4] Revert "ARM: shmobile: r8a7779: " Simon Horman
2012-11-13 3:10 ` [PATCH 4/4] sh: clkfwk: fixup unsed variable warning Simon Horman
2012-11-13 12:50 ` [GIT PULL] Renesas ARM-based SoC for v3.8 #4 Arnd Bergmann
2013-01-25 2:13 ` [GIT PULL] Renesas ARM-based SoC for v3.9 Simon Horman
2013-01-25 2:13 ` [PATCH 01/15] ARM: shmobile: Remove duplicate inclusion of dma-mapping.h in setup-r8a7740.c Simon Horman
2013-01-25 2:55 ` Sachin Kamat
2013-01-25 3:38 ` Simon Horman
2013-01-25 3:56 ` Sachin Kamat
2013-01-25 2:13 ` [PATCH 02/15] ARM: shmobile: r8a7740: add TMU timer support Simon Horman
2013-01-25 2:13 ` [PATCH 03/15] ARM: shmobile: sh73a0: fixup div4_clks bitmap Simon Horman
2013-01-25 2:13 ` [PATCH 04/15] ARM: mach-shmobile: sh73a0 external IRQ wake update Simon Horman
2013-01-25 2:13 ` [PATCH 05/15] ARM: sh7372: add clock lookup entries for DT-based devices Simon Horman
2013-01-25 2:13 ` [PATCH 06/15] ARM: sh7372: fix cache clean / invalidate order Simon Horman
2013-01-25 2:13 ` [PATCH 07/15] ARM: shmobile: add function declarations for sh7372 DT helper functions Simon Horman
2013-01-25 2:13 ` [PATCH 08/15] ARM: shmobile: sh73a0: Add CPU sleep suspend Simon Horman
2013-01-25 2:13 ` [PATCH 09/15] ARM: shmobile: r8a7740: " Simon Horman
2013-01-25 2:13 ` [PATCH 10/15] ARM: SH-Mobile: sh73a0: Secondary CPUs handle own SCU flags Simon Horman
2013-01-25 2:13 ` [PATCH 11/15] ARM: SH-Mobile: sh73a0: Add CPU Hotplug Simon Horman
2013-01-25 2:13 ` [PATCH 12/15] ARM: mach-shmobile: sh73a0: Allow initialisation of GIC by DT Simon Horman
2013-01-25 10:08 ` Mark Rutland
2013-01-25 2:13 ` [PATCH 13/15] ARM: mach-shmobile: sh73a0: Minimal setup using DT Simon Horman
2013-01-25 2:13 ` [PATCH 14/15] ARM: mach-shmobile: sh73a0: Initialise MMCIF " Simon Horman
2013-01-25 2:13 ` [PATCH 15/15] ARM: shmobile: r8a7779: scif .irqs used SCIx_IRQ_MUXED() Simon Horman
2013-01-25 3:43 ` [GIT PULL] Renesas ARM-based SoC for v3.9 Simon Horman
2013-01-31 6:23 ` [GIT PULL] Renesas ARM-based SoC for v3.9 #2 Simon Horman
2013-01-31 6:23 ` [PATCH 1/9] ARM: shmobile: ag5evm: Use gpio_request_one() Simon Horman
2013-01-31 6:23 ` [PATCH 2/9] ARM: shmobile: ap4evb: " Simon Horman
2013-01-31 6:23 ` [PATCH 3/9] ARM: shmobile: armadillo800eva: " Simon Horman
2013-01-31 6:23 ` [PATCH 4/9] ARM: shmobile: armadillo800eva: Use gpio_set_value() to set GPIO value Simon Horman
2013-01-31 6:23 ` [PATCH 5/9] ARM: shmobile: kota2: Use gpio_request_one() Simon Horman
2013-01-31 6:23 ` [PATCH 6/9] ARM: shmobile: bonito: " Simon Horman
2013-01-31 6:24 ` [PATCH 7/9] ARM: shmobile: kzm9g: " Simon Horman
2013-01-31 6:24 ` [PATCH 8/9] ARM: shmobile: mackerel: " Simon Horman
2013-01-31 6:24 ` [PATCH 9/9] ARM: shmobile: armadillo800eva: set clock rates before timer init Simon Horman
2013-02-01 3:40 ` [GIT PULL] Renesas ARM-based SoC for v3.9 #2 Olof Johansson
2013-01-31 6:26 ` Simon Horman
2013-01-31 6:26 ` [PATCH 1/4] ARM: mach-shmobile: sh73a0: Add reg and device_type properties to cpus Simon Horman
2013-01-31 6:26 ` [PATCH 2/4] ARM: mach-shmobile: emev2: " Simon Horman
2013-01-31 6:26 ` [PATCH 3/4] ARM: mach-shmobile: add shmobile_cpu_disable_any() Simon Horman
2013-01-31 6:26 ` [PATCH 4/4] ARM: mach-shmobile: sh73a0: allow unplugging of CPU0 Simon Horman
2013-02-01 3:40 ` [GIT PULL] Renesas ARM-based SoC for v3.9 #2 Olof Johansson
2013-02-05 3:47 ` [GIT PULL] Renesas ARM-based SoC for v3.9 #3 Simon Horman
2013-02-05 3:47 ` [PATCH] ARM: shmobile: r8a7779: Correct TMU clock support Simon Horman
2013-02-05 19:12 ` [GIT PULL] Renesas ARM-based SoC for v3.9 #3 Olof Johansson
2013-02-06 2:03 ` [GIT PULL] Renesas ARM-based SoC for v3.9 #4 Simon Horman
2013-02-06 2:03 ` [PATCH] ARM: shmobile: Register ARM architected timer Simon Horman
2013-02-10 0:50 ` [GIT PULL] Renesas ARM-based SoC for v3.9 #4 Olof Johansson
2013-02-19 3:49 ` [GIT PULL] Renesas ARM-based SoC for v3.9 #5 Simon Horman
2013-02-19 3:49 ` Simon Horman [this message]
2013-02-19 15:41 ` Arnd Bergmann
-- strict thread matches above, loose matches on Subject: below --
2013-02-05 3:28 [PATCH] ARM: shmobile: r8a7779: Correct TMU clock support Simon Horman
2013-02-14 3:43 ` [PATCH] ARM: shmobile: r8a7779: Correct TMU clock support again Simon Horman
2013-02-14 4:03 ` Kuninori Morimoto
2013-02-14 4:04 ` Magnus Damm
2013-02-14 4:12 ` Kuninori Morimoto
2013-02-14 4:14 ` Kuninori Morimoto
2013-02-14 4:20 ` Simon Horman
2013-02-14 4:25 ` Kuninori Morimoto
2013-02-14 4:36 ` Simon Horman
2013-02-14 4:42 ` Simon Horman
2013-02-14 5:20 ` Magnus Damm
2013-02-14 8:34 ` Simon Horman
2013-02-14 4:16 ` Simon Horman
2013-02-14 9:10 ` Paul Mundt
2013-02-14 16:08 ` Simon Horman
2013-02-14 16:18 ` Paul Mundt
2013-02-15 13:53 ` Simon Horman
2013-02-18 0:52 ` Simon Horman
2013-02-15 13:35 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1361245745-23355-2-git-send-email-horms+renesas@verge.net.au \
--to=horms+renesas@verge.net.au \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).