From: Katsuya Matsubara <matsu@igel.co.jp>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: linux-media@vger.kernel.org, linux-sh@vger.kernel.org,
Hans Verkuil <hverkuil@xs4all.nl>,
Sakari Ailus <sakari.ailus@iki.fi>,
Sylwester Nawrocki <sylvester.nawrocki@gmail.com>,
Katsuya Matsubara <matsu@igel.co.jp>
Subject: [PATCH 1/7] [media] vsp1: Fix lack of the sink entity registration for enabled links
Date: Fri, 26 Jul 2013 09:32:11 +0000 [thread overview]
Message-ID: <1374831137-9219-2-git-send-email-matsu@igel.co.jp> (raw)
In-Reply-To: <1374831137-9219-1-git-send-email-matsu@igel.co.jp>
Each source entity maintains a pointer to the counterpart sink
entity while an enabled link connects them. It should be managed by
the setup_link callback in the media controller framework at runtime.
However, enabled links which connect RPFs and WPFs that have an
equivalent index number are created during initialization.
This registers the pointer to a sink entity from the source entity
when an enabled link is created.
Signed-off-by: Katsuya Matsubara <matsu@igel.co.jp>
---
drivers/media/platform/vsp1/vsp1_drv.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/media/platform/vsp1/vsp1_drv.c b/drivers/media/platform/vsp1/vsp1_drv.c
index 756929e..0ead308 100644
--- a/drivers/media/platform/vsp1/vsp1_drv.c
+++ b/drivers/media/platform/vsp1/vsp1_drv.c
@@ -101,6 +101,9 @@ static int vsp1_create_links(struct vsp1_device *vsp1, struct vsp1_entity *sink)
entity, pad, flags);
if (ret < 0)
return ret;
+
+ if (flags & MEDIA_LNK_FL_ENABLED)
+ source->sink = entity;
}
}
--
1.7.9.5
next prev parent reply other threads:[~2013-07-26 9:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-26 9:32 [PATCH 0/7] [media] vsp1: Add VIO6 support Katsuya Matsubara
2013-07-26 9:32 ` Katsuya Matsubara [this message]
2013-07-26 9:32 ` [PATCH 2/7] [media] vsp1: Use the maximum number defined in platform data Katsuya Matsubara
2013-07-26 9:32 ` [PATCH 3/7] [media] vsp1: Rewrite the definition of registers' offset as enum and arrays Katsuya Matsubara
2013-07-26 9:32 ` [PATCH 4/7] [media] vsp1: Rewrite the value definitions for DPR routing " Katsuya Matsubara
2013-07-26 9:32 ` [PATCH 5/7] [media] vsp1: Introduce bit operations for the DPR route registers Katsuya Matsubara
2013-07-26 9:32 ` [PATCH 6/7] [media] vsp1: Move the DPR_WPF_FPORCH register settings into the device initialization Katsuya Matsubara
2013-07-26 9:32 ` [PATCH 7/7] [media] vsp1: Add VIO6 support Katsuya Matsubara
2013-07-26 16:18 ` [PATCH 0/7] " Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1374831137-9219-2-git-send-email-matsu@igel.co.jp \
--to=matsu@igel.co.jp \
--cc=hverkuil@xs4all.nl \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=sakari.ailus@iki.fi \
--cc=sylvester.nawrocki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox