From: Joe Perches <joe@perches.com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: netdev@vger.kernel.org, wg@grandegger.com, mkl@pengutronix.de,
linux-can@vger.kernel.org, linux-sh@vger.kernel.org
Subject: Re: [PATCH] can: add Renesas R-Car CAN driver
Date: Sat, 28 Sep 2013 00:40:29 +0000 [thread overview]
Message-ID: <1380328829.2965.3.camel@joe-AO722> (raw)
In-Reply-To: <201309280211.39068.sergei.shtylyov@cogentembedded.com>
On Sat, 2013-09-28 at 02:11 +0400, Sergei Shtylyov wrote:
> Add support for the CAN controller found in Renesas R-Car SoCs.
trivia:
> +++ linux-can-next/drivers/net/can/rcar_can.c
[]
> +static void rcar_can_rx_pkt(struct rcar_can_priv *priv, int mbx)
> +{
> + struct net_device_stats *stats = &priv->ndev->stats;
> + struct can_frame *cf;
> + struct sk_buff *skb;
> + u32 data;
> + u8 dlc;
> +
> + skb = alloc_can_skb(priv->ndev, &cf);
> + if (!skb) {
> + stats->rx_dropped++;
> + if (printk_ratelimit())
> + netdev_err(priv->ndev,
> + "%s: alloc_can_skb() failed\n", __func__);
This logging message is unnecessary because it's
redundant to the generic OOM error in __alloc_skb.
It already gets a dump_stack();
next prev parent reply other threads:[~2013-09-28 0:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-27 22:11 [PATCH] can: add Renesas R-Car CAN driver Sergei Shtylyov
2013-09-28 0:40 ` Joe Perches [this message]
2013-09-28 0:45 ` Stephen Hemminger
2013-09-28 0:52 ` Sergei Shtylyov
2013-09-29 19:03 ` Marc Kleine-Budde
2013-10-17 21:54 ` Sergei Shtylyov
2013-10-02 6:09 ` Wolfgang Grandegger
2013-10-17 22:16 ` Sergei Shtylyov
2013-10-21 19:12 ` Wolfgang Grandegger
2013-11-09 0:02 ` Sergei Shtylyov
2013-11-09 10:53 ` Wolfgang Grandegger
2013-11-09 14:47 ` Wolfgang Grandegger
2013-11-12 20:45 ` Sergei Shtylyov
2013-11-12 22:17 ` Wolfgang Grandegger
2013-10-05 17:57 ` Wolfgang Grandegger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1380328829.2965.3.camel@joe-AO722 \
--to=joe@perches.com \
--cc=linux-can@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).