* [PATCH 1/2] ARM: shmobile: lager: set .debounce_interval
2013-10-29 8:57 [PATCH 0/2] ARM: shmobile: lager, koelsch: set .debounce_interval Simon Horman
@ 2013-10-29 8:57 ` Simon Horman
2013-10-29 8:57 ` [PATCH 2/2] ARM: shmobile: koelsch: " Simon Horman
2013-10-31 5:13 ` [PATCH 0/2] ARM: shmobile: lager, " Simon Horman
2 siblings, 0 replies; 4+ messages in thread
From: Simon Horman @ 2013-10-29 8:57 UTC (permalink / raw)
To: linux-arm-kernel
From: Shinya Kuribayashi <shinya.kuribayashi.px@renesas.com>
In R-Car GPIO hardware block, 'chattering removal' feature can be
enabled on GPIO-n-[3:0] pins, but it's not supported on rest of pins
GPIO-n-[31:4].
Set an appropriate debounce interval, instead. We could confirm that
spurious/unnecessary GPIO interrupts are prevented by this settings.
Signed-off-by: Shinya Kuribayashi <shinya.kuribayashi.px@renesas.com>
Acked-by: Magnus Damm <damm@opensource.se>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
arch/arm/mach-shmobile/board-lager.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/arm/mach-shmobile/board-lager.c b/arch/arm/mach-shmobile/board-lager.c
index 78a31b6..fcf06fd 100644
--- a/arch/arm/mach-shmobile/board-lager.c
+++ b/arch/arm/mach-shmobile/board-lager.c
@@ -120,7 +120,8 @@ static const struct gpio_led_platform_data lager_leds_pdata __initconst = {
/* GPIO KEY */
#define GPIO_KEY(c, g, d, ...) \
- { .code = c, .gpio = g, .desc = d, .active_low = 1 }
+ { .code = c, .gpio = g, .desc = d, .active_low = 1, \
+ .debounce_interval = 20 }
static struct gpio_keys_button gpio_buttons[] = {
GPIO_KEY(KEY_4, RCAR_GP_PIN(1, 28), "SW2-pin4"),
--
1.8.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 2/2] ARM: shmobile: koelsch: set .debounce_interval
2013-10-29 8:57 [PATCH 0/2] ARM: shmobile: lager, koelsch: set .debounce_interval Simon Horman
2013-10-29 8:57 ` [PATCH 1/2] ARM: shmobile: lager: " Simon Horman
@ 2013-10-29 8:57 ` Simon Horman
2013-10-31 5:13 ` [PATCH 0/2] ARM: shmobile: lager, " Simon Horman
2 siblings, 0 replies; 4+ messages in thread
From: Simon Horman @ 2013-10-29 8:57 UTC (permalink / raw)
To: linux-arm-kernel
In R-Car GPIO hardware block, 'chattering removal' feature can be
enabled on GPIO-n-[3:0] pins, but it's not supported on rest of pins
GPIO-n-[31:4].
Set an appropriate debounce interval, instead. We could confirm that
spurious/unnecessary GPIO interrupts are prevented by this settings.
Based on work for the lager board by Shinya Kuribayashi.
Cc: Shinya Kuribayashi <shinya.kuribayashi.px@renesas.com>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
arch/arm/mach-shmobile/board-koelsch.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/arm/mach-shmobile/board-koelsch.c b/arch/arm/mach-shmobile/board-koelsch.c
index 59fa0b9..5b81a34 100644
--- a/arch/arm/mach-shmobile/board-koelsch.c
+++ b/arch/arm/mach-shmobile/board-koelsch.c
@@ -56,7 +56,8 @@ static const struct gpio_led_platform_data koelsch_leds_pdata __initconst = {
/* GPIO KEY */
#define GPIO_KEY(c, g, d, ...) \
- { .code = c, .gpio = g, .desc = d, .active_low = 1 }
+ { .code = c, .gpio = g, .desc = d, .active_low = 1, \
+ .debounce_interval = 20 }
static struct gpio_keys_button gpio_buttons[] = {
GPIO_KEY(KEY_4, RCAR_GP_PIN(5, 3), "SW2-pin4"),
--
1.8.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 0/2] ARM: shmobile: lager, koelsch: set .debounce_interval
2013-10-29 8:57 [PATCH 0/2] ARM: shmobile: lager, koelsch: set .debounce_interval Simon Horman
2013-10-29 8:57 ` [PATCH 1/2] ARM: shmobile: lager: " Simon Horman
2013-10-29 8:57 ` [PATCH 2/2] ARM: shmobile: koelsch: " Simon Horman
@ 2013-10-31 5:13 ` Simon Horman
2 siblings, 0 replies; 4+ messages in thread
From: Simon Horman @ 2013-10-31 5:13 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Oct 29, 2013 at 05:57:29PM +0900, Simon Horman wrote:
> This short series sets .debounce_interval for GPIO keys
> for the lager and koelsch boards.
>
> This resolves a problem on the lager board reported, tested and fixed by
> Kuribayashi-san. I have extended the solution to the koelsch board.
I have queued up these patches.
^ permalink raw reply [flat|nested] 4+ messages in thread