* [PATCH 8/9] usb: phy: rcar-gen2: register using usb_add_phy_dev()
@ 2013-11-20 17:38 Ulrich Hecht
2013-11-20 21:15 ` Valentine
0 siblings, 1 reply; 2+ messages in thread
From: Ulrich Hecht @ 2013-11-20 17:38 UTC (permalink / raw)
To: linux-sh
Allows binding of PCI USB host controllers to this phy.
Signed-off-by: Ulrich Hecht <ulrich.hecht@gmail.com>
---
drivers/usb/phy/phy-rcar-gen2-usb.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/phy/phy-rcar-gen2-usb.c b/drivers/usb/phy/phy-rcar-gen2-usb.c
index a99a695..25fdd91 100644
--- a/drivers/usb/phy/phy-rcar-gen2-usb.c
+++ b/drivers/usb/phy/phy-rcar-gen2-usb.c
@@ -212,8 +212,9 @@ static int rcar_gen2_usb_phy_probe(struct platform_device *pdev)
priv->phy.init = rcar_gen2_usb_phy_init;
priv->phy.shutdown = rcar_gen2_usb_phy_shutdown;
priv->phy.set_suspend = rcar_gen2_usb_phy_set_suspend;
+ priv->phy.type = USB_PHY_TYPE_USB2;
- retval = usb_add_phy(&priv->phy, USB_PHY_TYPE_USB2);
+ retval = usb_add_phy_dev(&priv->phy);
if (retval < 0) {
dev_err(dev, "Failed to add USB phy\n");
return retval;
--
1.8.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 8/9] usb: phy: rcar-gen2: register using usb_add_phy_dev()
2013-11-20 17:38 [PATCH 8/9] usb: phy: rcar-gen2: register using usb_add_phy_dev() Ulrich Hecht
@ 2013-11-20 21:15 ` Valentine
0 siblings, 0 replies; 2+ messages in thread
From: Valentine @ 2013-11-20 21:15 UTC (permalink / raw)
To: linux-sh
On 11/20/2013 09:38 PM, Ulrich Hecht wrote:
> Allows binding of PCI USB host controllers to this phy.
>
> Signed-off-by: Ulrich Hecht <ulrich.hecht@gmail.com>
> ---
> drivers/usb/phy/phy-rcar-gen2-usb.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/phy/phy-rcar-gen2-usb.c b/drivers/usb/phy/phy-rcar-gen2-usb.c
> index a99a695..25fdd91 100644
> --- a/drivers/usb/phy/phy-rcar-gen2-usb.c
> +++ b/drivers/usb/phy/phy-rcar-gen2-usb.c
> @@ -212,8 +212,9 @@ static int rcar_gen2_usb_phy_probe(struct platform_device *pdev)
> priv->phy.init = rcar_gen2_usb_phy_init;
> priv->phy.shutdown = rcar_gen2_usb_phy_shutdown;
> priv->phy.set_suspend = rcar_gen2_usb_phy_set_suspend;
> + priv->phy.type = USB_PHY_TYPE_USB2;
The above line is not really needed.
I think we should switch to usb_bind_phy and bind USB phy to the renesas_usbhs device instead.
In this case usbhs device probe will be deferred unless usb phy is available.
>
> - retval = usb_add_phy(&priv->phy, USB_PHY_TYPE_USB2);
> + retval = usb_add_phy_dev(&priv->phy);
> if (retval < 0) {
> dev_err(dev, "Failed to add USB phy\n");
> return retval;
>
Thanks,
Val.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-11-20 21:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-20 17:38 [PATCH 8/9] usb: phy: rcar-gen2: register using usb_add_phy_dev() Ulrich Hecht
2013-11-20 21:15 ` Valentine
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).