* [PATCH] ARM: shmobile: lager: Constify lager_boards_compat_dt
@ 2013-11-22 1:02 Simon Horman
2013-11-22 13:40 ` Sergei Shtylyov
0 siblings, 1 reply; 3+ messages in thread
From: Simon Horman @ 2013-11-22 1:02 UTC (permalink / raw)
To: linux-arm-kernel
lager_boards_compat_dt is kmemdup()ed when the corresponding devices are
registered and can thus be declared as const. Do so.
This replicates a portion of 27113d63daac0aac ("ARM: shmobile: lager:
Constify platform data and resources") which appears to have inadvertently
been lost during merging.
Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
arch/arm/mach-shmobile/board-lager.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-shmobile/board-lager.c b/arch/arm/mach-shmobile/board-lager.c
index d47052e..04c5ca8 100644
--- a/arch/arm/mach-shmobile/board-lager.c
+++ b/arch/arm/mach-shmobile/board-lager.c
@@ -249,7 +249,7 @@ static void __init lager_init(void)
phy_register_fixup_for_id("r8a7790-ether-ff:01", lager_ksz8041_fixup);
}
-static const char * const lager_boards_compat_dt[] __initconst = {
+static const char *lager_boards_compat_dt[] __initdata = {
"renesas,lager",
NULL,
};
--
1.8.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] ARM: shmobile: lager: Constify lager_boards_compat_dt
2013-11-22 1:02 [PATCH] ARM: shmobile: lager: Constify lager_boards_compat_dt Simon Horman
@ 2013-11-22 13:40 ` Sergei Shtylyov
2013-11-28 2:22 ` Simon Horman
0 siblings, 1 reply; 3+ messages in thread
From: Sergei Shtylyov @ 2013-11-22 13:40 UTC (permalink / raw)
To: linux-arm-kernel
Hello.
On 22-11-2013 5:02, Simon Horman wrote:
> lager_boards_compat_dt is kmemdup()ed when the corresponding devices are
> registered and can thus be declared as const. Do so.
> This replicates a portion of 27113d63daac0aac ("ARM: shmobile: lager:
> Constify platform data and resources") which appears to have inadvertently
> been lost during merging.
> Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> ---
> arch/arm/mach-shmobile/board-lager.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> diff --git a/arch/arm/mach-shmobile/board-lager.c b/arch/arm/mach-shmobile/board-lager.c
> index d47052e..04c5ca8 100644
> --- a/arch/arm/mach-shmobile/board-lager.c
> +++ b/arch/arm/mach-shmobile/board-lager.c
> @@ -249,7 +249,7 @@ static void __init lager_init(void)
> phy_register_fixup_for_id("r8a7790-ether-ff:01", lager_ksz8041_fixup);
> }
>
> -static const char * const lager_boards_compat_dt[] __initconst = {
> +static const char *lager_boards_compat_dt[] __initdata = {
> "renesas,lager",
> NULL,
But aren't you in fact reverting the described change?
WBR, Sergei
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] ARM: shmobile: lager: Constify lager_boards_compat_dt
2013-11-22 13:40 ` Sergei Shtylyov
@ 2013-11-28 2:22 ` Simon Horman
0 siblings, 0 replies; 3+ messages in thread
From: Simon Horman @ 2013-11-28 2:22 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Nov 22, 2013 at 05:40:25PM +0400, Sergei Shtylyov wrote:
> Hello.
>
> On 22-11-2013 5:02, Simon Horman wrote:
>
> >lager_boards_compat_dt is kmemdup()ed when the corresponding devices are
> >registered and can thus be declared as const. Do so.
>
> >This replicates a portion of 27113d63daac0aac ("ARM: shmobile: lager:
> >Constify platform data and resources") which appears to have inadvertently
> >been lost during merging.
>
> >Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> >Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> >---
> > arch/arm/mach-shmobile/board-lager.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> >diff --git a/arch/arm/mach-shmobile/board-lager.c b/arch/arm/mach-shmobile/board-lager.c
> >index d47052e..04c5ca8 100644
> >--- a/arch/arm/mach-shmobile/board-lager.c
> >+++ b/arch/arm/mach-shmobile/board-lager.c
> >@@ -249,7 +249,7 @@ static void __init lager_init(void)
> > phy_register_fixup_for_id("r8a7790-ether-ff:01", lager_ksz8041_fixup);
> > }
> >
> >-static const char * const lager_boards_compat_dt[] __initconst = {
> >+static const char *lager_boards_compat_dt[] __initdata = {
> > "renesas,lager",
> > NULL,
>
> But aren't you in fact reverting the described change?
Yes. This patch is completely bogus.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-11-28 2:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-22 1:02 [PATCH] ARM: shmobile: lager: Constify lager_boards_compat_dt Simon Horman
2013-11-22 13:40 ` Sergei Shtylyov
2013-11-28 2:22 ` Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).