SUPERH platform development
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] ARM: shmobile: r8a7740: Fix ethernet device name in clock definition
Date: Wed, 17 Jul 2013 10:47:22 +0000	[thread overview]
Message-ID: <1387552.daX06F2NAK@avalon> (raw)
In-Reply-To: <1373966374-15716-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com>

Hi Sergei,

On Tuesday 16 July 2013 18:26:23 Sergei Shtylyov wrote:
> Hello.
> 
> On 07/16/2013 04:27 PM, Sergei Shtylyov wrote:
> >> The ethernet device is named r8a7740-gether, fix the clock definition
> >> accordingly.
> >> 
> >> Signed-off-by: Laurent Pinchart
> >> <laurent.pinchart+renesas@ideasonboard.com>
> >> ---
> >> 
> >>   arch/arm/mach-shmobile/clock-r8a7740.c | 2 +-
> >>   1 file changed, 1 insertion(+), 1 deletion(-)
> >> 
> >> diff --git a/arch/arm/mach-shmobile/clock-r8a7740.c
> >> b/arch/arm/mach-shmobile/clock-r8a7740.c
> >> index de10fd7..e1e8710 100644
> >> --- a/arch/arm/mach-shmobile/clock-r8a7740.c
> >> +++ b/arch/arm/mach-shmobile/clock-r8a7740.c
> >> @@ -595,7 +595,7 @@ static struct clk_lookup lookups[] = {
> >> 
> >>       CLKDEV_DEV_ID("sh_mmcif",        &mstp_clks[MSTP312]),
> >>       CLKDEV_DEV_ID("e6bd0000.mmcif",         &mstp_clks[MSTP312]),
> >>       CLKDEV_DEV_ID("r8a7740-gether",        &mstp_clks[MSTP309]),
> >> 
> >> -    CLKDEV_DEV_ID("e9a00000.sh-eth",    &mstp_clks[MSTP309]),
> >> +    CLKDEV_DEV_ID("e9a00000.r8a7740-gether", &mstp_clks[MSTP309]),
> >> 
> >     Al Ethernet devices should be named "ethernet", according to ePAPR
> >     spec.
> 
>     BTW, I'm not seeing a patch to r8a7740.dtsi, describing this device.

Let's delay this patch until the device gets added to r8a7740.dtsi then.

-- 
Regards,

Laurent Pinchart


  parent reply	other threads:[~2013-07-17 10:47 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-16  9:19 [PATCH] ARM: shmobile: r8a7740: Fix ethernet device name in clock definition Laurent Pinchart
2013-07-16 12:27 ` Sergei Shtylyov
2013-07-16 14:26 ` Sergei Shtylyov
2013-07-17 10:47 ` Laurent Pinchart [this message]
2013-07-17 13:05 ` Sergei Shtylyov
2013-07-17 13:11 ` Laurent Pinchart
2013-07-17 13:40 ` Sergei Shtylyov
2013-07-17 14:04 ` Laurent Pinchart
2013-07-17 14:20 ` Sergei Shtylyov
2013-07-17 14:48 ` Laurent Pinchart
2013-07-17 23:04 ` Simon Horman
2013-07-18 20:28 ` Sergei Shtylyov
2013-07-18 20:57 ` Laurent Pinchart
2013-07-19  4:30 ` Shimoda, Yoshihiro
2013-07-19 12:17 ` Sergei Shtylyov
2013-07-22  9:15 ` Shimoda, Yoshihiro
2013-07-22 11:47 ` Sergei Shtylyov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1387552.daX06F2NAK@avalon \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=linux-sh@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox