From: William Towle <william.towle@codethink.co.uk>
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] ARM: shmobile: r8a7790: specify multiple parents for cpg_clks
Date: Tue, 04 Feb 2014 18:17:37 +0000 [thread overview]
Message-ID: <1391537858-28593-3-git-send-email-william.towle@codethink.co.uk> (raw)
In-Reply-To: <1391537858-28593-1-git-send-email-william.towle@codethink.co.uk>
The current drivers/clk/shmobile/clk-rcar-gen2.c uses the
extal_clk reference for the parent of all the clocks that
it registers. However the lb, qspi, sdh, sd0 and sd1 clocks
are all parented to either pll1 or pll1_div2 which means
that the clock rates are incorrect.
This is part of the fix that corrects the SDHI0 clock
rate error where it reports 1MHz instead of 97.5:
sh_mobile_sdhi ee100000.sd: mmc0 base at 0xee100000 clock rate 1 MHz
Notes:
- May require cross-merge with clk-rcar-gen2.c fix
- Also not clear which clock "z" is to fix it.
[ben.dooks@codethink.co.uk: updated patch description]
Signed-off-by: William Towle <william.towle@codethink.co.uk>
Reviewed-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
arch/arm/boot/dts/r8a7790.dtsi | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi
index ff55c6e..242e6e2 100644
--- a/arch/arm/boot/dts/r8a7790.dtsi
+++ b/arch/arm/boot/dts/r8a7790.dtsi
@@ -446,7 +446,13 @@
compatible = "renesas,r8a7790-cpg-clocks",
"renesas,rcar-gen2-cpg-clocks";
reg = <0 0xe6150000 0 0x1000>;
- clocks = <&extal_clk>;
+ clocks = <&extal_clk>, <&extal_clk>, <&extal_clk>, <&extal_clk>,
+ <&cpg_clocks R8A7790_CLK_PLL1>,
+ <&pll1_div2_clk>,
+ <&cpg_clocks R8A7790_CLK_PLL1>,
+ <&cpg_clocks R8A7790_CLK_PLL1>,
+ <&cpg_clocks R8A7790_CLK_PLL1>
+ /* not known for "z" ...,<> */;
#clock-cells = <1>;
clock-output-names = "main", "pll0", "pll1", "pll3",
"lb", "qspi", "sdh", "sd0", "sd1",
--
1.7.10.4
next prev parent reply other threads:[~2014-02-04 18:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-04 18:17 Clock divisor/parent settings changes William Towle
2014-02-04 18:17 ` [PATCH 1/3] clk: rcar-h2: fix sd0/sd1 divisor table William Towle
2014-02-05 10:56 ` Laurent Pinchart
2014-02-05 11:55 ` Ben Dooks
2014-02-05 12:41 ` Ben Dooks
2014-02-05 13:07 ` Laurent Pinchart
2014-02-06 0:43 ` Kuninori Morimoto
2014-02-07 6:43 ` Kuninori Morimoto
2014-02-07 9:55 ` Ben Dooks
2014-02-04 18:17 ` William Towle [this message]
2014-02-05 9:15 ` [Linux-kernel] [PATCH 2/3] ARM: shmobile: r8a7790: specify multiple parents for cpg_clks Ben Dooks
2014-02-05 10:32 ` Laurent Pinchart
2014-02-05 10:36 ` Ben Dooks
2014-02-05 10:57 ` Laurent Pinchart
2014-02-04 18:17 ` [PATCH 3/3] clk: shmobile: handle multiple parent clocks for cpg clocks William Towle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1391537858-28593-3-git-send-email-william.towle@codethink.co.uk \
--to=william.towle@codethink.co.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).