From: Patrick Titiano <ptitiano@baylibre.com>
To: magnus.damm@gmail.com, kuninori.morimoto.gx@renesas.com,
eduardo.valentin@ti.com
Cc: bcousson@baylibre.com, linux-pm@vger.kernel.org,
linux-sh@vger.kernel.org, Patrick Titiano <ptitiano@baylibre.com>
Subject: [PATCH 0/2] thermal: rcar-thermal: minor fixes
Date: Fri, 28 Feb 2014 13:10:02 +0000 [thread overview]
Message-ID: <1393593004-16285-1-git-send-email-ptitiano@baylibre.com> (raw)
Hi,
Here are 2 minor updates to the rcar-thermal driver.
First patch removes an unecessary mask applied in a if statement.
Because the same mask was already applied in the preceding statement,
the second one can be removed.
Second patch avoids updating the thermal zone in case an IRQ was triggered but
the temperature didn't effectively change.
Note this is not a driver issue.
Below is a captured debug trace illustrating the purpose of this patch:
out of 8 thermal zone updates, only 2 are actually necessary.
[ 41.120000] rcar_thermal_work(): cctemp%000
[ 41.120000] rcar_thermal_work(): new_ctemp0000
[ 41.120000] rcar_thermal_work(): temp is now 30000C, update thermal zone
[ 58.990000] rcar_thermal_work(): cctemp0000
[ 58.990000] rcar_thermal_work(): nctemp0000
[ 58.990000] rcar_thermal_work(): same temp, do not update thermal zone
[ 59.290000] rcar_thermal_work(): cctemp0000
[ 59.290000] rcar_thermal_work(): nctemp0000
[ 59.290000] rcar_thermal_work(): same temp, do not update thermal zone
[ 59.590000] rcar_thermal_work(): cctemp0000
[ 59.590000] rcar_thermal_work(): nctemp0000
[ 59.590000] rcar_thermal_work(): same temp, do not update thermal zone
[ 59.890000] rcar_thermal_work(): cctemp0000
[ 59.890000] rcar_thermal_work(): nctemp0000
[ 59.890000] rcar_thermal_work(): same temp, do not update thermal zone
[ 60.190000] rcar_thermal_work(): cctemp0000
[ 60.190000] rcar_thermal_work(): nctemp0000
[ 60.190000] rcar_thermal_work(): same temp, do not update thermal zone
[ 60.490000] rcar_thermal_work(): cctemp0000
[ 60.490000] rcar_thermal_work(): nctemp0000
[ 60.490000] rcar_thermal_work(): same temp, do not update thermal zone
[ 60.790000] rcar_thermal_work(): cctemp0000
[ 60.790000] rcar_thermal_work(): nctemp5000
[ 60.790000] rcar_thermal_work(): temp is now 35000C, update thermal zone
I suspect this may be due to sensor sampling accuracy / fluctuation,
but no formal proof.
Patrick Titiano (2):
thermal: rcar-thermal: fix same mask applied twice
thermal: rcar-thermal: update thermal zone only when temperature
changes
drivers/thermal/rcar_thermal.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
--
1.8.3.2
next reply other threads:[~2014-02-28 13:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-28 13:10 Patrick Titiano [this message]
2014-02-28 13:10 ` [PATCH 1/2] thermal: rcar-thermal: fix same mask applied twice Patrick Titiano
2014-02-28 13:10 ` [PATCH 2/2] thermal: rcar-thermal: update thermal zone only when temperature changes Patrick Titiano
2014-03-02 23:52 ` [PATCH 0/2] thermal: rcar-thermal: minor fixes Kuninori Morimoto
2014-03-03 14:51 ` Zhang Rui
2014-03-05 14:45 ` Patrick Titiano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1393593004-16285-1-git-send-email-ptitiano@baylibre.com \
--to=ptitiano@baylibre.com \
--cc=bcousson@baylibre.com \
--cc=eduardo.valentin@ti.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-pm@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).